Skip to content

Issue/7139 signup magic link#7170

Merged
hypest merged 6 commits intofeature/new-signupfrom
issue/7139-signup-magic-link
Jan 29, 2018
Merged

Issue/7139 signup magic link#7170
hypest merged 6 commits intofeature/new-signupfrom
issue/7139-signup-magic-link

Conversation

@theck13
Copy link
Copy Markdown
Contributor

@theck13 theck13 commented Jan 27, 2018

Fix

Add email signup screen as described in #7139. The new SignupMagicLinkFragment class is similar to the LoginMagicLinkSentFragment class, but not entirely. We can create a BaseMagicLinkFragment class to help abstract common code as an optimization when we move the signup code into the WordPressLoginFlow library. I chose not to do that at this time to avoid conflicts with ongoing development.

Test

  1. Clear app data.
  2. Tap Sign Up button.
  3. Tap Sign Up with Email button.
  4. Enter email address not associated with WordPress.com account.
  5. Notice Signup Magic Link screen.
  6. Check email inbox of address used in Step 3.
  7. Notice signup email from WordPress.com.
  8. Tap Try Again button.
  9. Check email inbox of address used in Step 3.
  10. Notice another signup email from WordPress.com.

Note

These changes do not include handling interception of the magic link from the signup email. That will be covered in the subsequent epilogue issue.

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Jan 29, 2018

LGTM!

@hypest hypest merged commit f8eaab0 into feature/new-signup Jan 29, 2018
@hypest hypest deleted the issue/7139-signup-magic-link branch January 29, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants