Skip to content

Issue/7138 add email signup#7167

Merged
hypest merged 5 commits intofeature/new-signupfrom
issue/7138-add-email-signup
Jan 26, 2018
Merged

Issue/7138 add email signup#7167
hypest merged 5 commits intofeature/new-signupfrom
issue/7138-add-email-signup

Conversation

@theck13
Copy link
Copy Markdown
Contributor

@theck13 theck13 commented Jan 25, 2018

Fix

Add email signup screen as described in #7138. The new SignupEmailFragment class is similar to the LoginEmailFragment class, but not entirely. We can create a BaseEmailFragment class to help abstract common code as an optimization when we move the signup code into the WordPressLoginFlow library. I chose not to do that at this time to avoid conflicts with ongoing development. The "Continue to magic link" message denotes the flow that will be handled in the subsequent magic link issue.

Test

  1. Clear app data.
  2. Tap Sign Up button.
  3. Tap Sign Up with Email button.
  4. Enter email address associated with WordPress.com account.
  5. Notice message and login flow.
  6. Tap back arrow.
  7. Enter email address not associated with WordPress.com account.
  8. Notice "Continue to magic link" message.

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Jan 26, 2018

LGTM!

@hypest hypest merged commit a3bd076 into feature/new-signup Jan 26, 2018
@hypest hypest deleted the issue/7138-add-email-signup branch January 26, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants