Skip to content

Issue/7137 update sites empty#7141

Merged
nbradbury merged 6 commits intofeature/new-signupfrom
issue/7137-update-sites-empty
Jan 22, 2018
Merged

Issue/7137 update sites empty#7141
nbradbury merged 6 commits intofeature/new-signupfrom
issue/7137-update-sites-empty

Conversation

@theck13
Copy link
Copy Markdown
Contributor

@theck13 theck13 commented Jan 20, 2018

Fix

Update Sites tab empty state as described in #7137.

Test

  1. Create account with no sites.
  2. Go to Sites tab.
  3. Notice updated layout.

@aerych aerych mentioned this pull request Jan 20, 2018
10 tasks
@nbradbury nbradbury self-assigned this Jan 22, 2018
@nbradbury
Copy link
Copy Markdown
Contributor

@theck13 Looks good - I'll merge it now, but wanted to mention an unrelated problem: the FAB still shows up when there aren't any sites.

screenshot_1516644334

@nbradbury
Copy link
Copy Markdown
Contributor

:shipit:

@nbradbury nbradbury merged commit 9be5650 into feature/new-signup Jan 22, 2018
@nbradbury nbradbury deleted the issue/7137-update-sites-empty branch January 22, 2018 18:12
@theck13
Copy link
Copy Markdown
Contributor Author

theck13 commented Jan 22, 2018

FAB still shows up when there aren't any sites.

I created a new issue for the floating action button behavior. Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants