Skip to content

Use new newSendAuthEmailAction's method signature#6841

Merged
nbradbury merged 5 commits intodevelopfrom
feature/updated-magiclink-api-method-signature
Jan 4, 2018
Merged

Use new newSendAuthEmailAction's method signature#6841
nbradbury merged 5 commits intodevelopfrom
feature/updated-magiclink-api-method-signature

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Nov 8, 2017

FluxC's newSendAuthEmailAction has been updated to pass the email via a structure along with more parameters. This PR updates the call which is currently broken.

Needs wordpress-mobile/WordPress-FluxC-Android#605 to be merged first.

To test:

  • Compile and run wpandroid. It should work.

@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Nov 8, 2017

This PR will be updated with a commit to point to the FluxC hash that includes the change, when it lands.

@aerych aerych mentioned this pull request Nov 8, 2017
10 tasks
@oguzkocer
Copy link
Copy Markdown
Contributor

@hypest Since you're afk and the changes in this PR is a blocker for me, I took the liberty to merge develop into this branch (to fix app versioning issue for test) and updating the FluxC to the latest. I hope that's OK with you.

@nbradbury
Copy link
Copy Markdown
Contributor

:shipit:

@nbradbury nbradbury merged commit 52ccd25 into develop Jan 4, 2018
@nbradbury nbradbury deleted the feature/updated-magiclink-api-method-signature branch January 4, 2018 00:30
@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Jan 8, 2018

Thanks @oguzkocer for picking this up and seeing it through while I was AFK!! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants