Move a few login-related helper classes to the utils library#6776
Move a few login-related helper classes to the utils library#6776
Conversation
Background: Since the design support library was added to the utils library, two cases of custom views that extend android.widget classes were reported as errors by the linter, prompting to instead extend AppCompat versions of those views.
df9aa58 to
0370f89
Compare
|
Hey @aforcier , nice to see this happening! Quick q, are you planning to move |
| <dimen name="margin_text_input_layout_baseline">20dp</dimen> | ||
| <dimen name="margin_extra_extra_extra_large">92dp</dimen> | ||
| <dimen name="promo_indicator_bullet_size">4dp</dimen> | ||
| <dimen name="textinputlayout_baseline_correction">2dp</dimen> |
There was a problem hiding this comment.
Can we also move textinputlayout_correction_padding and textinputlayout_correction_margin_right. Those are part of the same set of "hacks" to fix issues of the TextInputLayout an pretty much are used in tandem. WDYT?
| * | ||
| */ | ||
| public class AutoResizeTextView extends TextView { | ||
| public class AutoResizeTextView extends AppCompatTextView { |
There was a problem hiding this comment.
Just wondering, can you share some background about this change? Is it some lint related warning or something else? Thanks! Scratch that, the individual commit message has the info I needed 👍 . Apologies and thanks!
I felt that, since ( |
Aaah, I see, makes sense. All good 👍 |
|
LGTM! |
Moves
ViewUtilsandWPTextInputLayoutto the utils library, where they can be used by the extracted login UI library (once we release a new artifact).(WIP branch for the login extraction, for reference.)
There might be some other pieces in the future, but these are the most glaring ones so far (with all fragments except Prologue and Epilogue extracted).
cc @hypest