Feature/reader full post refresh featured image#4652
Merged
khaykov merged 4 commits intofeature/reader-full-post-refresh-masterfrom Oct 19, 2016
Merged
Conversation
khaykov
reviewed
Oct 19, 2016
Contributor
khaykov
left a comment
There was a problem hiding this comment.
Looks good to me! Just have one suggestion about coping.
| * crops the passed bitmap to fit the passed width/height - bitmap will be resized if | ||
| * necessary to ensure it fills the desired size before cropping | ||
| */ | ||
| private static Bitmap cropBitmap(Bitmap bitmap, int newWidth, int newHeight) { |
Contributor
There was a problem hiding this comment.
There is a ThumbnailUtils helper in Android, that's supposed to handle cropping in situations like this, so maybe we could replace call to this method with ThumbnailUtils.extractThumbnail(bitmap, mCropWidth, mCropHeight); ?
They produce really similar results:
Contributor
Author
I had completely forgotten about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4640 - in #4626 we redesigned how related posts appear in the reader detail, but featured images on those related posts were stretched rather than cropped. This PR corrects that problem.
Before & after pics below:
