People management analytics#4128
Merged
daniloercoli merged 3 commits intofeature/people-management-syncfrom May 26, 2016
Merged
People management analytics#4128daniloercoli merged 3 commits intofeature/people-management-syncfrom
daniloercoli merged 3 commits intofeature/people-management-syncfrom
Conversation
Contributor
We can reorder the list if that helps. I think we've grouped items by functionalities. Also, it' s not important the name you give to the enum item, the important part is the name given to the event, that should follow nosara rules. |
| Intent intent = new Intent(context, PeopleManagementActivity.class); | ||
| slideInFromRight(context, intent); | ||
| // TODO: add -> AnalyticsTracker.track(AnalyticsTracker.Stat.OPENED_PEOPLE_MANAGEMENT); | ||
| AnalyticsUtils.trackWithCurrentBlogDetails(AnalyticsTracker.Stat.OPENED_PEOPLE); |
Contributor
There was a problem hiding this comment.
Can we use the old name for this enum OPENED_PEOPLE_MANAGEMENT. It feels more clear to me what's used for.
Contributor
Author
There was a problem hiding this comment.
Hah, that was just a reminder comment I've added for myself, but sure we can 👍
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant #3901. This PR adds the analytics events for people management. It follows the iOS counterpart. Thanks @jleandroperez!
P.S: I feel the
AnalyticsTrackerenum is a bit disordered. It's hard to decide where to put the event name and decide on the correct naming. It'd be great if we can maybe order it alphabetically and set some rules. Just my 2 cents./cc @astralbodies & @nbradbury
Needs review: @daniloercoli