Feature/reader search toolbar by nbradbury · Pull Request #4085 · wordpress-mobile/WordPress-Android

nbradbury · 2016-05-11T00:16:13Z

This is the first of several PRs which will implement WordPress.com search in the Android reader. This PR doesn't perform any search yet - it simply adds a basic search UI to the reader, which includes:

Modifying FilteredRecyclerView to allow for a menu to be inflated in the toolbar
Adding a search icon in the reader toolbar which expands to show a standard Android SearchView
Remembering previous searches and using them as suggestions when typing a new search query

Note that the wording used in this PR isn't final - it's simply a placeholder until a later design review.

…e user could have cancelled them on the PlayStore). Re-synch purchases when the user buys a subscription from the store.

…ss-Android into feature/plans-integrate-store-step-one

Add comments.

…ss-Android into feature/plans-integrate-store-step-one

… during release checksum

…ss-Android into feature/plans-integrate-store-step-one

…an subscription, and redirect the user to support. We're not going to enable upgrades whitin the apps.

…ss-Android into feature/plans-integrate-store-step-one # Conflicts: # WordPress/src/main/res/values/strings.xml

…lan attached to it.

… approach - just add a menu

…ss-Android into feature/reader-search-toolbar

daniloercoli · 2016-05-12T10:08:24Z

Seems that the back button is highlighted in the result screen. See the GIF below:

daniloercoli · 2016-05-12T10:19:31Z

~~I see the DB field query_string declared as nocase query_string TEXT NOT NULL COLLATE NOCASE PRIMARY KEY, but the suggestions UI seems to remember the case.~~

Nevermind: I got now how nocase works.

Should we call a toLowercase() on the string before inserting it in the DB?

nbradbury · 2016-05-12T11:20:56Z

Seems that the back button is highlighted in the result screen.

I see this quite often in the emulator, not just with this PR but with others. I don't see this on a real device, though - are you also only seeing it in the emulator?

nbradbury · 2016-05-12T11:22:00Z

Should we call a toLowercase() on the string before inserting it in the DB?

I'm not sure if you wanted me to ignore this, but just in case you didn't: I don't think we need to lowercase the string. I think the user would expect to see it remembered using the same casing they used when they entered the query.

nbradbury · 2016-05-12T12:15:39Z

I found a small UI issue if you tap the Search icon while a tag is loading from remote

Good catch! Fixed in 62317a9.

daniloercoli · 2016-05-12T12:26:58Z

Noticed that with the "Search interface" on the screen the back button closes the app, instead of returning you to the main Reader interface.

daniloercoli · 2016-05-12T12:28:16Z

Seems that the back button is highlighted in the result screen.

I see this quite often in the emulator, not just with this PR but with others. I don't see this on a real device, though - are you also only seeing it in the emulator?

Seeing it on emulators only. Sorry for the false alarm, usually emulators don't have this kind of issue.

daniloercoli · 2016-05-12T12:47:01Z

I found a small UI issue if you tap the Search icon while a tag is loading from remote

Good catch! Fixed in 62317a9.

I see a similar behavior if you start tapping something in the "search field" and then rotate the device.
The string just typed is remembered, but the main UI shows the previous topic items.

…ss-Android into feature/reader-search-toolbar

nbradbury · 2016-05-12T17:27:52Z

the "Search interface" on the screen the back button closes the app

Glad you found that one - fixed in 6279f18.

nbradbury · 2016-05-12T18:40:18Z

I see a similar behavior if you start tapping something in the "search field" and then rotate the device.
The string just typed is remembered, but the main UI shows the previous topic items.

That turned out to be a nasty one to fix, but it's taken care of now. So, ready for another round. Thanks!

…e-store-step-one [Plans] Integrate Google Store calls, and synch IAP with backend - step one

…ss-Android into feature/reader-search-toolbar

daniloercoli · 2016-05-12T21:05:15Z

That turned out to be a nasty one to fix, but it's taken care of now. So, ready for another round. Thanks!

~~Sorry @nbradbury, it seems to partially fix the issue. he main text is not visible when I turn the device to landscape.~~

Nevermind it was a design decision.

daniloercoli · 2016-05-12T21:10:56Z

@aerych - I've done with the review. If you want to take a look at this PR you're welcome.
Otherwise, this is ready to be merged.

aerych · 2016-05-12T21:57:24Z

Otherwise, this is ready to be merged.

Merge away :) No need to wait for me

daniloercoli · 2016-05-12T22:10:45Z

daniloercoli and others added 30 commits April 10, 2016 22:30

Use our logger in IabHelper

2341d26

Start integrating the store calls

9cda45d

Re-synch purchases with wpcom server on startup and periodically. (Th…

db846cf

…e user could have cancelled them on the PlayStore). Re-synch purchases when the user buys a subscription from the store.

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

eecf66f

…ss-Android into feature/plans-integrate-store-step-one

Remove unused imports.

443d963

Add comments.

Remove custom hardcoded SKUs since REST Endpoint has been updated.

8f553c9

Fix log message

2b9d5a6

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

63ef93b

…ss-Android into feature/plans-integrate-store-step-one

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

6be91fa

…ss-Android into feature/plans-integrate-store-step-one

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

3835ec3

…ss-Android into feature/plans-integrate-store-step-one

Use the new endpoint name, and remove unused parameters.

691e6a8

add a "wp." prefix to crashlytics.apikey so that value will be tested…

d18fb25

… during release checksum

update release check sha1sum with optimizely and crashlytics keys

c5253ca

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

cc3c871

…ss-Android into feature/plans-integrate-store-step-one

Change the label to "upgrade" when the selected blog already has a pl…

569e2b0

…an subscription, and redirect the user to support. We're not going to enable upgrades whitin the apps.

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

9cfa151

…ss-Android into feature/plans-integrate-store-step-one # Conflicts: # WordPress/src/main/res/values/strings.xml

Remove links to unused subprojects used during development

20c7335

Revert unwanted commits

27765fb

Fix merge conflicts

ef9b80d

Fix merge conflicts - tentative #2

97baa8c

New plans strings

7c28243

Do not show the Upgrade|Purchase button when the blog already has a p…

90e71a4

…lan attached to it.

First pass at adding toolbar above reader post list

2c25280

Replaced filtered recycler's ability to add components with a simpler…

56f0bee

… approach - just add a menu

Check isAdded() in toolbar listener

f9e5ca3

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

0a015bc

…ss-Android into feature/reader-search-toolbar

First pass at adding SearchView

518db33

Fixed centering of menu items in toolbar

ca0890d

Toggle settings icon with search

5666942

Removed toolbar listener from addToolbarMenu

b295c04

Don't show updated posts during search

62317a9

daniloercoli and others added 6 commits May 12, 2016 15:41

Change the visibilty of mContext to private in UpdateIAPTask

858cfa8

Drop unused variable

d0d361e

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

09fbec3

…ss-Android into feature/reader-search-toolbar

Added a comment that describe how the sync with wpcom works

70d4012

Revert changes made to IabHelper

84932ae

Tapping back button when search is expanded now closes it

6279f18

nbradbury added 3 commits May 12, 2016 13:38

Don't show empty message for search when in landscape

d5b0364

Use a separate view for the search explainer

1284722

Recycler is now hidden rather than cleared when searching

e3e95df

nbradbury and others added 2 commits May 12, 2016 15:27

Merge pull request #4078 from wordpress-mobile/feature/plans-integrat…

f963389

…e-store-step-one [Plans] Integrate Google Store calls, and synch IAP with backend - step one

Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…

8b96bec

…ss-Android into feature/reader-search-toolbar

daniloercoli merged commit 6e3335b into feature/reader-search-master May 12, 2016

daniloercoli deleted the feature/reader-search-toolbar branch May 12, 2016 22:10

This was referenced May 16, 2016

Feature/reader search results #4094

Closed

Feature/reader search results #4096

Merged

Conversation

nbradbury commented May 11, 2016

Uh oh!

daniloercoli commented May 12, 2016

Uh oh!

daniloercoli commented May 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nbradbury commented May 12, 2016

Uh oh!

nbradbury commented May 12, 2016

Uh oh!

nbradbury commented May 12, 2016

Uh oh!

daniloercoli commented May 12, 2016

Uh oh!

daniloercoli commented May 12, 2016

Uh oh!

daniloercoli commented May 12, 2016

Uh oh!

nbradbury commented May 12, 2016

Uh oh!

nbradbury commented May 12, 2016

Uh oh!

daniloercoli commented May 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daniloercoli commented May 12, 2016

Uh oh!

aerych commented May 12, 2016

Uh oh!

daniloercoli commented May 12, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

daniloercoli commented May 12, 2016 •

edited

Loading

daniloercoli commented May 12, 2016 •

edited

Loading