Blogs comparator handles empty titles properly#2349
Blogs comparator handles empty titles properly#2349solinger10 wants to merge 1 commit intowordpress-mobile:developfrom
Conversation
|
I think we should sort blogs with an empty title by their "hostname". Here is my proposed patch for |
|
@solinger10 What do you think about the proposed solution? |
|
I don't really like the blogs with no title being compared to all other blogs using the host name. It just seems to make more sense to me to have the no title blogs at the top of the list, but that's all personal preference. Both options solve the problem. |
I agree, on this screen it's not the best UX. But we're using that comparator in other places like here: (taliwuttandfood2.wordpress.com has an empty title) Where we only show blog titles or blog url if the title is empty, in that case that's weird to have it on top. We could have different blog comparators, but IMO 2 blog lists with 2 different orders is just another issue. |
|
Yeah, I see what you mean. I think it looks worse there and not so bad in comparison on the other list. I'd say your patch is the way to go. |
|
ref #2403 |


Fixes #2328. The comparator used the url to compare blogs with no titles to blogs with titles. This results in blogs with no title being put in the 'h' section (for 'http://...') in a sorted list. I changed it to only use the url for comparing two blogs if both blogs don't have a title.