Initial support for VideoPress v5 by SiobhyB · Pull Request #20181 · wordpress-mobile/WordPress-Android

SiobhyB · 2024-02-13T17:02:28Z

Related PRs

Gutenberg: RNMobile: Add new Video block capability WordPress/gutenberg#59144
Gutenberg Mobile: Initial support for VideoPress v5 gutenberg-mobile#6634
Jetpack: [RNMobile] Initial support for VideoPress v5 Automattic/jetpack#35637
iOS: Initial support for VideoPress v5 WordPress-iOS#22602

To Test:

Please refer to the Jetpack PR as the central place for these changes, with the most up-to-date testing instructions.

Regression Notes

Potential unintended areas of impact
- This PR introduces changes to the way the Video block is rendered, as such there is a chance of unintended changes to that block. However, as we are re-using most of the block's existing code, the risk should be minimal.
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manually went through existing test cases for the Video block.
What automated tests I added (or what prevented me from doing so)
- No tests were added, partly due to the current difficulty adding tests within the Jetpack repo. This an area I'd like to revisit at a future date.

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

wpmobilebot · 2024-02-13T17:18:47Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20181-a44b752
	Commit	`a44b752`
	Direct Download	`wordpress-prototype-build-pr20181-a44b752.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-02-13T17:20:53Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20181-a44b752
	Commit	`a44b752`
	Direct Download	`jetpack-prototype-build-pr20181-a44b752.apk`

Note: Google Login is not supported on these builds.

codecov · 2024-02-17T18:21:44Z

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.37%. Comparing base (efa163c) to head (a44b752).

Files	Patch %	Lines
...ain/java/org/wordpress/android/util/SiteUtils.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #20181      +/-   ##
==========================================
- Coverage   40.37%   40.37%   -0.01%     
==========================================
  Files        1469     1469              
  Lines       67698    67699       +1     
  Branches    11212    11213       +1     
==========================================
  Hits        27336    27336              
- Misses      37861    37862       +1     
  Partials     2501     2501

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SiobhyB · 2024-02-21T16:49:08Z

    public static final String GB_EDITOR_NAME = "gutenberg";
    public static final String AZTEC_EDITOR_NAME = "aztec";
    public static final String WP_STORIES_CREATOR_NAME = "wp_stories_creator";
+    public static final String WP_VIDEOPRESS_V5_JETPACK_VERSION = "8.5";


Note, I chose this version number based on the Jetpack version we support for the Contact Info block.

I couldn't find a definite version that the VideoPress v5 code was introduced on the web, and could find it supported as far back as Jetpack v7.2. I know the official stance is that we support "two releases prior to the current version", which is why I simply chose the oldest version we support for another block rather than going back to find a specific older version where web began supporting v5.

I'm open to changing this if others have feelings about what the version should be.

fluiddot

LGTM 🎊 !

wpmobilebot · 2024-02-23T18:35:42Z

Found 1 violations:

The PR caused some dependency changes (expand to see details)

 \--- project :libs:editor
-     \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.112.0
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.11.0 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.11.0 (*)
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
-          +--- org.wordpress.react-native-libraries.v4:react-native-get-random-values:1.4.0
-          +--- org.wordpress.react-native-libraries.v4:react-native-safe-area-context:4.6.3
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.20 (*)
-          +--- org.wordpress.react-native-libraries.v4:react-native-screens:3.22.0
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.9.10 (*)
-          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
-          |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
-          |    \--- androidx.core:core-ktx:1.5.0 -> 1.12.0 (*)
-          +--- org.wordpress.react-native-libraries.v4:react-native-svg:13.9.0
-          +--- org.wordpress.react-native-libraries.v4:react-native-webview:11.26.1
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.20 (*)
-          |    \--- androidx.webkit:webkit:1.4.0 -> 1.10.0 (*)
-          +--- org.wordpress.react-native-libraries.v4:react-native-masked-view:0.2.9
-          +--- org.wordpress.react-native-libraries.v4:react-native-clipboard:1.11.2
-          +--- org.wordpress.react-native-libraries.v4:react-native-fast-image:8.5.11
-          |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
-          |    |    +--- com.github.bumptech.glide:gifdecoder:4.16.0
-          |    |    |    \--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
-          |    |    +--- com.github.bumptech.glide:disklrucache:4.16.0
-          |    |    +--- com.github.bumptech.glide:annotations:4.16.0
-          |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-          |    |    +--- androidx.exifinterface:exifinterface:1.3.6 (*)
-          |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
-          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-          |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0 (*)
-          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.11.0 (*)
-          |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-          +--- org.wordpress.react-native-libraries.v4:react-native-reanimated:2.17.0
-          +--- org.wordpress.react-native-libraries.v4:react-native-gesture-handler:2.10.2
-          |    +--- org.wordpress.react-native-libraries.v4:react-native-reanimated:2.17.0
-          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
-          |    +--- androidx.core:core-ktx:1.6.0 -> 1.12.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.20 (*)
-          +--- org.wordpress.react-native-libraries.v4:react-native-linear-gradient:2.7.3
-          +--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.112.0
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0
-          |    |    +--- androidx.core:core:1.0.0 -> 1.12.0 (*)
-          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-          |    +--- org.wordpress:aztec:v1.9.0 -> v2.0 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.9.0 -> v2.0 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v1.9.0 -> v2.0 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v1.9.0
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-          |    |    +--- org.wordpress:aztec:v1.9.0 -> v2.0 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.113.0-alpha1
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.11.0 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.11.0 (*)
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
+          +--- org.wordpress.react-native-libraries.v4:react-native-get-random-values:1.4.0
+          +--- org.wordpress.react-native-libraries.v4:react-native-safe-area-context:4.6.3
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.20 (*)
+          +--- org.wordpress.react-native-libraries.v4:react-native-screens:3.22.0
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.9.10 (*)
+          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
+          |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
+          |    \--- androidx.core:core-ktx:1.5.0 -> 1.12.0 (*)
+          +--- org.wordpress.react-native-libraries.v4:react-native-svg:13.9.0
+          +--- org.wordpress.react-native-libraries.v4:react-native-webview:11.26.1
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.20 (*)
+          |    \--- androidx.webkit:webkit:1.4.0 -> 1.10.0 (*)
+          +--- org.wordpress.react-native-libraries.v4:react-native-masked-view:0.2.9
+          +--- org.wordpress.react-native-libraries.v4:react-native-clipboard:1.11.2
+          +--- org.wordpress.react-native-libraries.v4:react-native-fast-image:8.5.11
+          |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
+          |    |    +--- com.github.bumptech.glide:gifdecoder:4.16.0
+          |    |    |    \--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
+          |    |    +--- com.github.bumptech.glide:disklrucache:4.16.0
+          |    |    +--- com.github.bumptech.glide:annotations:4.16.0
+          |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+          |    |    +--- androidx.exifinterface:exifinterface:1.3.6 (*)
+          |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
+          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+          |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0 (*)
+          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.11.0 (*)
+          |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+          +--- org.wordpress.react-native-libraries.v4:react-native-reanimated:2.17.0
+          +--- org.wordpress.react-native-libraries.v4:react-native-gesture-handler:2.10.2
+          |    +--- org.wordpress.react-native-libraries.v4:react-native-reanimated:2.17.0
+          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
+          |    +--- androidx.core:core-ktx:1.6.0 -> 1.12.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.20 (*)
+          +--- org.wordpress.react-native-libraries.v4:react-native-linear-gradient:2.7.3
+          +--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.113.0-alpha1
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0
+          |    |    +--- androidx.core:core:1.0.0 -> 1.12.0 (*)
+          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          |    +--- org.wordpress:aztec:v1.9.0 -> v2.0 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.9.0 -> v2.0 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v1.9.0 -> v2.0 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v1.9.0
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+          |    |    +--- org.wordpress:aztec:v1.9.0 -> v2.0 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)

Please review and act accordingly

Update reference to Gutenberg Mobile

35a1610

SiobhyB added Do Not Merge labels Feb 13, 2024

Merge branch 'trunk' into gutenberg/support-for-videopress-v5

a574539

Update Gutenberg Mobile reference

d681f37

This was referenced Feb 13, 2024

Initial support for VideoPress v5 wordpress-mobile/gutenberg-mobile#6634

Merged

[RNMobile] Initial support for VideoPress v5 Automattic/jetpack#35637

Merged

SiobhyB added 6 commits February 14, 2024 09:30

Update Gutenberg Mobile reference

c6b319e

Update reference to Gutenberg Mobile

3059ae9

Update Gutenberg Mobile reference

a47307f

Update Gutenberg Mobile reference

ffcb279

feat: Enable VideoPress v5 capability

0f5ba32

Update Gutenberg Mobile reference

00401bf

SiobhyB changed the title ~~[TESTING ONLY] Initial support for VideoPress v5~~ Initial support for VideoPress v5 Feb 17, 2024

SiobhyB added Media and removed Do Not Merge labels Feb 19, 2024

SiobhyB marked this pull request as ready for review February 19, 2024 10:33

SiobhyB mentioned this pull request Feb 19, 2024

Initial support for VideoPress v5 wordpress-mobile/WordPress-iOS#22602

Merged

13 tasks

fix: Limit v5 conversion to site with VideoPress

2e02fe2

SiobhyB added this to the 24.3 ❄️ milestone Feb 21, 2024

SiobhyB added 5 commits February 21, 2024 00:04

Update RELEASE-NOTES

85b686f

Refine site types that support VideoPress v5

44beba0

Merge branch 'trunk' into gutenberg/support-for-videopress-v5

984cc88

Update Gutenberg Mobile reference

fcfaefe

refactor: Fix linting issue with long line

f72c15e

SiobhyB commented Feb 21, 2024

View reviewed changes

SiobhyB requested a review from fluiddot February 21, 2024 16:50

SiobhyB requested a review from derekblank February 21, 2024 16:50

fluiddot approved these changes Feb 22, 2024

View reviewed changes

Comment thread RELEASE-NOTES.txt Outdated

SiobhyB modified the milestones: 24.3 ❄️, 24.4 Feb 23, 2024

SiobhyB added 3 commits February 23, 2024 17:02

Refine RELEASE-NOTE

1f5d8b7

Update Gutenberg Mobile reference

8800532

Merge branch 'trunk' into gutenberg/support-for-videopress-v5

a44b752

SiobhyB merged commit 961d85f into trunk Feb 23, 2024

SiobhyB deleted the gutenberg/support-for-videopress-v5 branch February 23, 2024 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Initial support for VideoPress v5#20181

Initial support for VideoPress v5#20181
SiobhyB merged 18 commits into
trunkfrom
gutenberg/support-for-videopress-v5

SiobhyB commented Feb 13, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 13, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 13, 2024 •

edited

Loading

Uh oh!

codecov Bot commented Feb 17, 2024 •

edited

Loading

Uh oh!

SiobhyB Feb 21, 2024

Uh oh!

fluiddot left a comment

Uh oh!

Uh oh!

wpmobilebot commented Feb 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

SiobhyB commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related PRs

To Test:

Regression Notes

PR Submission Checklist:

Testing Checklist:

Uh oh!

wpmobilebot commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Feb 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SiobhyB Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

fluiddot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wpmobilebot commented Feb 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SiobhyB commented Feb 13, 2024 •

edited

Loading

wpmobilebot commented Feb 13, 2024 •

edited

Loading

wpmobilebot commented Feb 13, 2024 •

edited

Loading

codecov Bot commented Feb 17, 2024 •

edited

Loading