[Dependency Updates] Test Instructions Documentations per Dependency Update#19552
Merged
[Dependency Updates] Test Instructions Documentations per Dependency Update#19552
Conversation
TODOs got added on both those test scenarios as I am not sure how to test this functionality and can't easily find the entry point to it. All I could do to test this was to manually comment out some code and verify that the functions were called after setting the device's date to days/weeks after today. Still, I think it is better to have that there and inform future dependency update testers about this functionality and the fact that this needs to be (somehow) tested, rather than ignore both completely. For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/17892
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/17960
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/17960
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/17936
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/18552
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/17994
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/17996
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/18554
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/18113
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/18090
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/18102
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/18076
TODOs got added on all those test scenarios. I think it is better to have that there and inform future dependency update testers about this functionality and the fact that this needs to be (somehow) tested, rather than ignore both completely. For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/17571
For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/18060
TODOs got added on all those test scenarios. I think it is better to have that there and inform future dependency update testers about this functionality and the fact that this needs to be (somehow) tested, rather than ignore both completely.
FYI: Some smoke test instructions might have an 'Extra' section with addition instructions.
FYI: Every special test instructions have a 'Why & Extra' section to further explain why that dependency update is so special and how to deal with it.
Generated by 🚫 dangerJS |
Contributor
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19552-2f1403d | |
| Commit | 2f1403d | |
| Direct Download | wordpress-prototype-build-pr19552-2f1403d.apk |
Contributor
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19552-2f1403d | |
| Commit | 2f1403d | |
| Direct Download | jetpack-prototype-build-pr19552-2f1403d.apk |
irfano
requested changes
Nov 9, 2023
Member
irfano
left a comment
There was a problem hiding this comment.
Thank you for your efforts on this. I've added some comments for your review.
This is done for 'WorkManager' and 'Preference', which were both incorrectly pointing to a specific line number, instead of the default line one. Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1388166635
Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1388166635
Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1388214910
Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1388217235
Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1388224370
Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1388231514
Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1388239341
irfano
reviewed
Nov 10, 2023
Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1389360965
Related PR Comment: https://github.com/wordpress-mobile/ WordPress-Android/pull/19552#discussion_r1389373449
Contributor
Generated by 🚫 Danger |
irfano
approved these changes
Nov 10, 2023
Member
irfano
left a comment
There was a problem hiding this comment.
Thank you for submitting this PR and addressing my comments.
LGTM. 👍🏻
Contributor
Author
|
Awesome, thank you so much reviewing and merging this, more so for being as thorough as you were, you rock! 🙇 ❤️ 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #17551
Internal Discussion
pcdRpT-2Hp-p2This PR adds a new documentations page with test instructions per dependency update.
FYI: The goal is to further automate the dependency update process by documenting all the specific dependency updates that require explicit testing instructions. The hypothesis here is that this approach would not only save time and effort for each update, but also elevate the quality of dependency update work by ensuring that the testing aspect is not left to chance.
PS: This PR is also slightly updating the pull request template by:
@irfano I added you as the main reviewer, not so randomly (you shared lots of good ideas), since I just wanted someone from the Jetpack/WordPress mobile team to be aware and sign-off on that change. Feel free to merge this PR directly yourself if you deem so.
To Test:
FYI: Note that the Smoke Test and Special sections can be further improved. However, I didn't want make this improvement now and instead added TODO for devs to keep improving the documentation themselves when and if needed.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To Testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: