Part-2: Compiler Warnings as Errors - WordPress Module - FragmentManager#19490
Conversation
|
@antonis Please add yourself as a reviewer. |
| } | ||
| } else { | ||
| mDialog = (FullScreenDialogFragment) getFragmentManager().findFragmentByTag(FullScreenDialogFragment.TAG); | ||
| mDialog = (FullScreenDialogFragment) getParentFragmentManager().findFragmentByTag(FullScreenDialogFragment.TAG); |
There was a problem hiding this comment.
I've noticed a minor checkstyle issue on this line:
Line is longer than 120 characters (found 124). [LineLength]
There was a problem hiding this comment.
Oops looks like the checkstyle error might have went out of screen as well haha. Will fix it!
There was a problem hiding this comment.
Also i will be leaving test directions soon so I would request you to wait on this one until then.
There was a problem hiding this comment.
Thank you for the heads up @07jasjeet 🙇
My plan is to review the PR later today or tomorrow.
Needs no testing. The behaviour should be same as the new API's will throw IllegalStateException instead of NullPointerException if activity was null.
WordPress/src/main/java/org/wordpress/android/ui/main/SitePickerActivity.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/people/PersonDetailFragment.java
Outdated
Show resolved
Hide resolved
1) Used requireArguments() instead of assertion.
antonis
left a comment
There was a problem hiding this comment.
Thank you for your work on this @07jasjeet and for handling the review feedback 🙇
I've tested the implementation and everything worked as expected for me:
- AddCategoryFragment.java
- CollapseFullScreenDialogFragment.java
- SignupEpilogueFragment.java
- SitePickerActivity.java
- PersonDetailFragment.java
- FullScreenDialogFragment.java
The code also looks good 🎉
ONLY merge this after Part 1 has been merged! (Derivative branch)
Fixes #17253 partially. (Sub-ticket of #17246)
To Test:
AddCategoryFragment.java:
CollapseFullScreenDialogFragment.java:
SignupEpilogueFragment.java:
SitePickerActivity.java:
PersonDetailFragment.java:
Regression Notes
Potential unintended areas of impact
Mostly none because the newer API's are a direct replacement.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual Testing
What automated tests I added (or what prevented me from doing so)
None
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: