Merged
Conversation
This related to the below compose switch PR, which got merged before the main non-transitive resources PR below, and thus still using transitive resources for 'Material' related R classes. - Compose Switch PR: https://github.com/wordpress-mobile/ WordPress-Android/pull/18721 - Non-Transitive Resources PR: https://github.com/wordpress-mobile/ WordPress-Android/pull/18707
12 tasks
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18733-addb9e3 | |
| Commit | addb9e3 | |
| Direct Download | wordpress-prototype-build-pr18733-addb9e3.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18733-addb9e3 | |
| Commit | addb9e3 | |
| Direct Download | jetpack-prototype-build-pr18733-addb9e3.apk |
AjeshRPai
approved these changes
Jul 4, 2023
Contributor
AjeshRPai
left a comment
There was a problem hiding this comment.
LGTM 👍🏼 . Thanks for fixing this quickly
Contributor
Author
|
You rock @AjeshRPai , thank you for the quick review! 🙇 ❤️ 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR fixes some non-transitive resources related build errors for
MaterialR classes onWPSwitchandWPSwitchCompatclasses.FYI: This issue relates to this #18721 compose switch PR (cc @thomashorta), which got merged before this #18707 main non-transitive resources PR, and thus was still using transitive resources for
Materialrelated R classes.To test:
WPSwitchandWPSwitchCompatclasses, are still working as expected.Regression Notes
Potential unintended areas of impact
WPSwitchandWPSwitchCompat).What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: