[JP Social] Update UI for Post Settings screen by RenanLukas · Pull Request #18708 · wordpress-mobile/WordPress-Android

RenanLukas · 2023-06-28T02:25:19Z

To test:
Nothing to test yet, except the UI. Please run EditPostSettingsJetpackSocialContainerConnectionsListViewPreview and EditPostSettingsJetpackSocialNoConnectionsPreview.

Regression Notes

Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
--
What automated tests I added (or what prevented me from doing so)
--

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

wpmobilebot · 2023-06-28T02:44:28Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18708-4eab6db
	Commit	`4eab6db`
	Direct Download	`wordpress-prototype-build-pr18708-4eab6db.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-06-28T02:45:10Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18708-4eab6db
	Commit	`4eab6db`
	Direct Download	`jetpack-prototype-build-pr18708-4eab6db.apk`

Note: Google Login is not supported on these builds.

…ng JP (more info wordpress-mobile/gutenberg-mobile#4889)

…connections

RenanLukas · 2023-07-14T16:35:51Z

...s/src/main/java/org/wordpress/android/ui/posts/EditPostSettingsJetpackSocialContainerView.kt

+    onConnectProfilesCLick: () -> Unit,
+) {
+    Column {
+        if (postSocialConnectionList.isNotEmpty()) {


This decision will be moved to the ViewModel in another PR.

peril-wordpress-mobile · 2023-07-14T17:00:44Z

	Warnings
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

thomashorta

Thanks for the PR, Renan!
I added some minor comments and a concern that might require changes.

thomashorta · 2023-07-14T18:54:36Z

...src/main/java/org/wordpress/android/ui/posts/EditPostSettingsJetpackSocialConnectionsList.kt

+                connection = connection,
+                onSharingChange = {},//TODO
+            )
+            Divider()


💡 Do we want this trailing Divider for all items, including the last one? In case we don't, we can use the index to avoid showing for the last one, wdyt?

In case we want for all items then we might want to use forEach instead of forEachIndexed.

That's a good point. Initially I wasn't showing the last line using the index, like you said, but then I realized the design specs show the divider even for the last row. I believe the reason might be to have a clear separation between the last row and the Message container. WDYT?

...ain/java/org/wordpress/android/ui/posts/EditPostSettingsJetpackSocialContainerComposeView.kt

...s/src/main/java/org/wordpress/android/ui/posts/EditPostSettingsJetpackSocialContainerView.kt

…kSocialContainer

RenanLukas · 2023-07-14T20:08:15Z

Thanks for the review, @thomashorta . I've updated the code and replied to the comments. Please let me know if it makes sense 👍

thomashorta

Hey, thanks for renaming the Compose and View files! 🙇

I just added a comment about the modifier parameter which should be quick to fix.

...Press/src/main/java/org/wordpress/android/ui/posts/EditPostSettingsJetpackSocialContainer.kt

thomashorta

LGTM! Nice job!!!

RenanLukas added the Jetpack Social label Jun 28, 2023

RenanLukas added this to the 22.8 milestone Jun 28, 2023

thomashorta mentioned this pull request Jun 30, 2023

[Compose] Make Compose and View-based switch visually identical #18721

Merged

12 tasks

RenanLukas marked this pull request as ready for review June 30, 2023 22:43

RenanLukas added 4 commits July 4, 2023 20:44

[Jetpack Social] Implement base UI on post settings

ee08424

[Jetpack Social] Add shouldFillMaxWidth parameter to PrimaryButton

fb8227d

Use WP colors on post settings social sharing section even when runni…

1cc6193

…ng JP (more info wordpress-mobile/gutenberg-mobile#4889)

Update post settings Jetpack social container with TrainOfIcons changes

827b7a4

RenanLukas force-pushed the issue/18571-jp-social-post-settings-social-connections branch from d67b425 to 827b7a4 Compare July 5, 2023 15:41

RenanLukas modified the milestones: 22.8, 22.9 Jul 7, 2023

RenanLukas added the [Status] Not Ready for Review label Jul 10, 2023

RenanLukas added 4 commits July 13, 2023 21:16

Merge branch 'trunk' into issue/18571-jp-social-post-settings-social-…

80b5e06

…connections

Implement Modifier.conditionalThen function

c1e2993

Fix subscribe button padding in JP social section (post settings)

7aa3b2c

Update no connections state for JP social section in post settings

382cf26

RenanLukas marked this pull request as draft July 14, 2023 16:33

RenanLukas commented Jul 14, 2023

View reviewed changes

RenanLukas added [Type] Task and removed [Status] Not Ready for Review labels Jul 14, 2023

Rename preview functions in EditPostSettingsJetpackSocialContainerView

ef83a6a

RenanLukas requested review from develric and thomashorta July 14, 2023 17:00

RenanLukas marked this pull request as ready for review July 14, 2023 17:00

thomashorta suggested changes Jul 14, 2023

View reviewed changes

RenanLukas added 2 commits July 14, 2023 16:57

Apply PR suggestion: rename compose container

2a933ac

Apply PR suggestion: add modifier parameter to EditPostSettingsJetpac…

dcd0cc9

…kSocialContainer

thomashorta reviewed Jul 14, 2023

View reviewed changes

...Press/src/main/java/org/wordpress/android/ui/posts/EditPostSettingsJetpackSocialContainer.kt Outdated Show resolved Hide resolved

Apply PR suggestion: change order of Modifier parameter

4eab6db

RenanLukas mentioned this pull request Jul 14, 2023

[JP Social/Post Settings] JP Social connections and message #18571

Closed

3 tasks

thomashorta approved these changes Jul 14, 2023

View reviewed changes

RenanLukas merged commit 132b5c0 into trunk Jul 14, 2023

RenanLukas deleted the issue/18571-jp-social-post-settings-social-connections branch July 14, 2023 21:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JP Social] Update UI for Post Settings screen#18708

[JP Social] Update UI for Post Settings screen#18708
RenanLukas merged 12 commits intotrunkfrom
issue/18571-jp-social-post-settings-social-connections

RenanLukas commented Jun 28, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Jun 28, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Jun 28, 2023 •

edited

Loading

Uh oh!

RenanLukas Jul 14, 2023 •

edited

Loading

Uh oh!

peril-wordpress-mobile bot commented Jul 14, 2023

Uh oh!

thomashorta left a comment

Uh oh!

thomashorta Jul 14, 2023

Uh oh!

RenanLukas Jul 14, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RenanLukas commented Jul 14, 2023

Uh oh!

thomashorta left a comment

Uh oh!

Uh oh!

thomashorta left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

RenanLukas commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

wpmobilebot commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RenanLukas Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peril-wordpress-mobile bot commented Jul 14, 2023

Uh oh!

thomashorta left a comment

Choose a reason for hiding this comment

Uh oh!

thomashorta Jul 14, 2023

Choose a reason for hiding this comment

Uh oh!

RenanLukas Jul 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RenanLukas commented Jul 14, 2023

Uh oh!

thomashorta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thomashorta left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RenanLukas commented Jun 28, 2023 •

edited

Loading

wpmobilebot commented Jun 28, 2023 •

edited

Loading

wpmobilebot commented Jun 28, 2023 •

edited

Loading

RenanLukas Jul 14, 2023 •

edited

Loading