Migrate from Firebase remote config to BE remote config #18537
Merged
Migrate from Firebase remote config to BE remote config #18537
Conversation
…ncy, codeable_get_free_estimate_url, and wp_android_performance_monitoring_sample_rate
…rt open_web_links_with_jetpack_flow_frequency and update supporting tests
…rt wp_android_performance_monitoring_sample_rate and update supporting tests
…o url can be passed in
…rt codeable_get_free_estimate_url and update supporting tests
Generated by 🚫 dangerJS |
Contributor
|
Found 1 violations: The PR caused the following dependency changes:-\--- com.google.firebase:firebase-config:19.1.3
- +--- com.google.firebase:firebase-abt:19.0.1
- | +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
- | +--- com.google.firebase:firebase-common:19.3.0 -> 19.5.0 (*)
- | +--- com.google.firebase:firebase-components:16.0.0 -> 16.1.0 (*)
- | +--- com.google.firebase:firebase-measurement-connector:18.0.0 (*)
- | \--- com.google.protobuf:protobuf-lite:3.0.1
- +--- com.google.firebase:firebase-common:19.3.0 -> 19.5.0 (*)
- +--- com.google.firebase:firebase-components:16.0.0 -> 16.1.0 (*)
- +--- com.google.firebase:firebase-iid:20.0.1 -> 21.1.0 (*)
- +--- com.google.firebase:firebase-measurement-connector:18.0.0 (*)
- \--- com.google.protobuf:protobuf-lite:3.0.1
Please review and act accordingly
|
Contributor
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18537-01f5b01 | |
| Commit | 01f5b01 | |
| Direct Download | wordpress-prototype-build-pr18537-01f5b01.apk |
Contributor
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18537-01f5b01 | |
| Commit | 01f5b01 | |
| Direct Download | jetpack-prototype-build-pr18537-01f5b01.apk |
5 tasks
ParaskP7
approved these changes
May 29, 2023
Contributor
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @zwarm @AjeshRPai !
I have reviewing and tested this PR as per the instructions, thank you both so much for working on that and migrating Firebase Remote Config to our BE Remote Config, you rock! 🌟 ❤️ 🌟
FYI: I am approving but not merging this to give the change to @AjeshRPai to review this too, that is, before merging to trunk. No matter, feel free to merge it at any point in time, if you feel comfortable doing so. 🚀
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the following remote config fields from Firebase Remote Config to our BE remote config
A new remote config class was created for each field and default values set:
Default local value and remote config values are set as follows:
wp_android_performance_monitoring_sample_rate= 0.0codeable_get_free_estimate_url= https://codeable.io/partners/jetpack-scan/open_web_links_with_jetpack_flow_frequency= 0FYI: @oguzkocer and @AjeshRPai - Please verify the default values are correct
FirebaseRemoteConfigWrapperand replaced it withRemoteConfigWrapperFirebaseConfigdependency. @ParaskP7 🤞 that this was okay. Unless there is a dependency in a library that I am unaware of. Want to give this a second set of eyes?To test:
Note: The default values are the same across local and remote.
🔵 Tracked: remote_field_config_synced_statelog item contains the new fields:"open_web_links_with_jetpack_flow_frequency":"0",
"wp_android_performance_monitoring_sample_rate":"0.0",
"codeable_get_free_estimate_url":"https://codeable.io/partners/jetpack-scan/"
Remote Field ConfigssectionsRegression Notes
Potential unintended areas of impact
The default values are used for remote config values
What I did to test those areas of impact (or what existing automated tests I relied on)
Unit testing
What automated tests I added (or what prevented me from doing so)
Updated existing unit tests
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A