[Dependency Updates] Update `androidxConstraintlayoutVersion` to 2.1.4 by ParaskP7 · Pull Request #18395 · wordpress-mobile/WordPress-Android

ParaskP7 · 2023-05-10T13:30:34Z

This PR updates androidxConstraintlayoutVersion to 2.1.4.

PS: @zwarm I added you as the main reviewer, randomly so, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

To test:

See the dependency tree diff result and verify correctness.
Thoroughly smoke test both, the WordPress and Jetpack apps, and see if everything is working as expected.
In addition to the above smoke test, you can expand the below and follow the inner and more explicitly test steps within, which is mainly related to the transitive updates on external and internal libraries (see diff):

1. Login Flow [org.wordpress:login]

ℹ️ This test applies to both, the WordPress and Jetpack apps.
❗️ This test makes sure that the Login flow, which comes from the com.wordpress:login library is also working as expected and that any transitive dependency changes aren't affecting any Constraint Layout related screens.

Log out of the app (if already logged-in).
Verify that the Login screen is shown and functioning as expected.

2. Story Flow [com.automattic:stories]

ℹ️ This test applies to the Jetpack app.
❗️ This test makes sure that the Story flow, which comes from the [com.automattic:stories(https://github.com/Automattic/stories-android) library is also working as expected and that any transitive dependency changes aren't affecting any Constraint Layout related screens.

Create a new story post.
Add a couple of images to that story.
Add a some text on top of any image you uploaded.
Verify that everything is functioning as expected and that you can publish the story.
Publish the story and make sure that the story has been published as expected.

3. Image Editing Flow [libs:image-editor]

ℹ️ This test applies to both, the WordPress and Jetpack apps.
❗️ This test makes sure that the Image Editing flow, which comes from the libs:image-editor module is also working as expected and that any transitive dependency changes aren't affecting any Constraint Layout related screens.

Add a new blog post.
Add a new image block.
Choose an image and wait for it to be uploaded within the image block.
Click on the media options of this image (top right) and then click edit.
Verify that the Edit Image screen is shown and functioning as expected.
Crop the image and click the done menu option (top right).
Make sure the image is updated accordingly.

Regression Notes

Potential unintended areas of impact
- Potential breakage or misbehaviour on any or all screens that are utilizing androidx.constraintlayout.widget.ConstraintLayout to build their UI.
- Some of the transitive dependencies added might be causing some kind of misbehaviour.
What I did to test those areas of impact (or what existing automated tests I relied on)
- See To test section.
What automated tests I added (or what prevented me from doing so)
- N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Release Notes: https://developer.android.com/jetpack/androidx/releases/ constraintlayout#constraintlayout-2.0.4

Release Notes: https://developer.android.com/jetpack/androidx/releases/ constraintlayout#constraintlayout-2.1.4

wpmobilebot · 2023-05-10T13:37:39Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:image-editor
-|    +--- androidx.constraintlayout:constraintlayout:1.1.3 -> 2.0.4
-|    |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
-|    |    +--- androidx.core:core:1.3.1 -> 1.8.0 (*)
-|    |    \--- androidx.constraintlayout:constraintlayout-solver:2.0.4
+|    +--- androidx.constraintlayout:constraintlayout:2.1.4
+|    |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+|    |    +--- androidx.core:core:1.3.2 -> 1.8.0 (*)
+|    |    \--- androidx.constraintlayout:constraintlayout-core:1.0.4
 |    \--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01
-|         \--- androidx.constraintlayout:constraintlayout:2.0.1 -> 2.0.4 (*)
+|         \--- androidx.constraintlayout:constraintlayout:2.0.1 -> 2.1.4 (*)
 +--- org.wordpress:login:1.3.0
-|    \--- androidx.constraintlayout:constraintlayout:2.0.4 (*)
+|    \--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.4 (*)
 +--- com.automattic:stories:2.1.0
-|    \--- androidx.constraintlayout:constraintlayout:1.1.3 -> 2.0.4 (*)
+|    \--- androidx.constraintlayout:constraintlayout:1.1.3 -> 2.1.4 (*)
-\--- androidx.constraintlayout:constraintlayout:1.1.3 -> 2.0.4 (*)
+\--- androidx.constraintlayout:constraintlayout:2.1.4 (*)

Please review and act accordingly

wpmobilebot · 2023-05-10T13:48:38Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18395-86d4936
	Commit	`86d4936`
	Direct Download	`jetpack-prototype-build-pr18395-86d4936.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-05-10T13:48:48Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18395-86d4936
	Commit	`86d4936`
	Direct Download	`wordpress-prototype-build-pr18395-86d4936.apk`

Note: Google Login is not supported on these builds.

zwarm

Thanks @ParaskP7 for wrangling this.
I followed your testing instructions for:
(1) Login
(2) Story Post (Only JP - WP doesn't have this feature in static posters phase)
(3) Image editing
All of the above worked as expected. In addition, I did a general review of the app; hitting the major features: posts, pages, reader, stats, etc. Again, all works as expected.

I will approve and merge. 🥳

ParaskP7 · 2023-05-17T07:17:42Z

This is awesome, thank you so much for the review, testing and merging @zwarm , you rock! 🙇 ❤️ 🚀

ParaskP7 added 2 commits May 10, 2023 13:42

Deps: Update androidx constraint layout to 2.0.4

0ced5ae

Release Notes: https://developer.android.com/jetpack/androidx/releases/ constraintlayout#constraintlayout-2.0.4

Deps: Update androidx constraint layout to 2.1.4

86d4936

Release Notes: https://developer.android.com/jetpack/androidx/releases/ constraintlayout#constraintlayout-2.1.4

ParaskP7 added Tech Debt dependency update labels May 10, 2023

ParaskP7 added this to the Future milestone May 10, 2023

ParaskP7 requested review from a team and zwarm May 10, 2023 13:30

ParaskP7 self-assigned this May 10, 2023

This was referenced May 10, 2023

[Dependency Updates] Main Batch - AndroidX Compose/Kotlin (plus Core) #18364

Merged

Dependency Updates - Main Batch - Material/Google #17798

Closed

[Dependency Updates] Update googleMaterialVersion to 1.9.0 #18433

Merged

zwarm approved these changes May 16, 2023

View reviewed changes

zwarm merged commit d143f3f into trunk May 16, 2023

zwarm deleted the deps/update-androidx-constraintlayout-to-2.1.4 branch May 16, 2023 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency Updates] Update `androidxConstraintlayoutVersion` to 2.1.4#18395

[Dependency Updates] Update `androidxConstraintlayoutVersion` to 2.1.4#18395
zwarm merged 2 commits intotrunkfrom
deps/update-androidx-constraintlayout-to-2.1.4

ParaskP7 commented May 10, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented May 10, 2023

Uh oh!

wpmobilebot commented May 10, 2023

Uh oh!

wpmobilebot commented May 10, 2023

Uh oh!

zwarm left a comment

Uh oh!

ParaskP7 commented May 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ParaskP7 commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To test:

Regression Notes

Uh oh!

wpmobilebot commented May 10, 2023

The PR caused the following dependency changes:

Uh oh!

wpmobilebot commented May 10, 2023

Uh oh!

wpmobilebot commented May 10, 2023

Uh oh!

zwarm left a comment

Choose a reason for hiding this comment

Uh oh!

ParaskP7 commented May 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ParaskP7 commented May 10, 2023 •

edited

Loading