Merged
Conversation
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18365-4bac06d | |
| Commit | 4bac06d | |
| Direct Download | wordpress-prototype-build-pr18365-4bac06d.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18365-4bac06d | |
| Commit | 4bac06d | |
| Direct Download | jetpack-prototype-build-pr18365-4bac06d.apk |
50b749c to
201782f
Compare
Contributor
Author
201782f to
4bac06d
Compare
Generated by 🚫 dangerJS |
mkevins
reviewed
May 8, 2023
...s/src/main/java/org/wordpress/android/ui/sitecreation/domains/SiteCreationDomainsFragment.kt
Show resolved
Hide resolved
mkevins
approved these changes
May 8, 2023
Contributor
mkevins
left a comment
There was a problem hiding this comment.
This is working as described, and the code changes look great! Tested on a Pixel 3a, physical device. Thanks for also taking the opportunity to refactor / clean up a few things in the nearby code 🏅 😄 👍
...s/src/main/java/org/wordpress/android/ui/sitecreation/domains/SiteCreationDomainsFragment.kt
Show resolved
Hide resolved
Contributor
Author
You're not my father, Peril |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Resolves #18314
This PR:
To Test
Prerequisite
◐ Toggle the
SiteCreationDomainPurchasingFeatureConfigflagMe→App Settings→Debug settingsFeatures in developmentsectionRESTART THE APPbutton● Treatment Variation
○ Control Variation
Previews
Regression Notes
Potential unintended areas of impact
N/a
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and unit testing
What automated tests I added (or what prevented me from doing so)
N/a
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: