Skip to content

Redesign domain empty state#18365

Merged
ovitrif merged 14 commits intotrunkfrom
issue/18314-domain-empty-state-alignments
May 8, 2023
Merged

Redesign domain empty state#18365
ovitrif merged 14 commits intotrunkfrom
issue/18314-domain-empty-state-alignments

Conversation

@ovitrif
Copy link
Copy Markdown
Contributor

@ovitrif ovitrif commented May 4, 2023

Resolves #18314

This PR:

  • ★ Redesigns the empty view at the beginning of the domains step in site creation by:
    • ⊕ Replacing the site example illustration with the latest version from the design
    • ⊕ Left-aligning the title and subtitle
    • ⊕ Set serif font for title in landscape orientation

To Test

Prerequisite

◐ Toggle the SiteCreationDomainPurchasingFeatureConfig flag
  1. Go to MeApp SettingsDebug settings
  2. Scroll to the Features in development section
  3. Tap on the item corresponding to the flag
  4. Tap RESTART THE APP button

● Treatment Variation

  • Verify the new illustration is shown on the domains step in site creation

○ Control Variation

  • Verify The original illustration is shown

Previews

1 2 3

Regression Notes

  1. Potential unintended areas of impact
    N/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and unit testing

  3. What automated tests I added (or what prevented me from doing so)
    N/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@ovitrif ovitrif linked an issue May 4, 2023 that may be closed by this pull request
@ovitrif ovitrif self-assigned this May 4, 2023
@ovitrif ovitrif added this to the 22.4 milestone May 4, 2023
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 4, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18365-4bac06d
Commit4bac06d
Direct Downloadwordpress-prototype-build-pr18365-4bac06d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 4, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18365-4bac06d
Commit4bac06d
Direct Downloadjetpack-prototype-build-pr18365-4bac06d.apk
Note: Google Login is not supported on these builds.

@ovitrif ovitrif force-pushed the issue/18314-domain-empty-state-alignments branch from 50b749c to 201782f Compare May 4, 2023 17:43
@ovitrif
Copy link
Copy Markdown
Contributor Author

ovitrif commented May 4, 2023

📸 More Screenshots

Landscape Large Text

@ovitrif ovitrif marked this pull request as ready for review May 4, 2023 17:50
@ovitrif ovitrif requested a review from mkevins May 4, 2023 17:51
@ovitrif ovitrif force-pushed the issue/18314-domain-empty-state-alignments branch from 201782f to 4bac06d Compare May 5, 2023 10:41
@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

Copy link
Copy Markdown
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as described, and the code changes look great! Tested on a Pixel 3a, physical device. Thanks for also taking the opportunity to refactor / clean up a few things in the nearby code 🏅 😄 👍

@ovitrif
Copy link
Copy Markdown
Contributor Author

ovitrif commented May 8, 2023

Warnings
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.
Generated by 🚫 dangerJS

You're not my father, Peril :trollface:

@ovitrif ovitrif merged commit 4e8936f into trunk May 8, 2023
@ovitrif ovitrif deleted the issue/18314-domain-empty-state-alignments branch May 8, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align UI in the Domains screen of Site Creation

3 participants