Skip to content

[UI Tests] Add Domains Dashboard Card UI test#18345

Merged
irfano merged 6 commits intotrunkfrom
add-domains-card-ui-test
May 4, 2023
Merged

[UI Tests] Add Domains Dashboard Card UI test#18345
irfano merged 6 commits intotrunkfrom
add-domains-card-ui-test

Conversation

@pachlava
Copy link
Copy Markdown
Contributor

@pachlava pachlava commented May 1, 2023

Description

Following the maximum similarity to its iOS counterpart, this PR adds a UI test for the Domains Dashboard card:

Screenshot 2023-05-01 at 22 43 35

What the test does:

  • Checks that that card with expected header and text is available at Home screen
  • Taps the card and checks that the redirect to Domains screen takes place

I hope the code is pretty self-explanatory, so I'm not providing a lot of notes on it.

To test

  • All tests are green on CI, including the new e2eDomainsCardNavigation

Regression Notes

I'm not filling the regression notes since the PR adds a UI test, it does not change the app behaviour in any way.

@pachlava pachlava requested a review from a team as a code owner May 1, 2023 18:42
@pachlava pachlava marked this pull request as draft May 1, 2023 18:42
@pachlava pachlava added the UI Tests Anything related to automated UI Tests. label May 1, 2023
@pachlava pachlava added this to the Future milestone May 1, 2023
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 1, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18345-83ed21c
Commit83ed21c
Direct Downloadwordpress-prototype-build-pr18345-83ed21c.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 1, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18345-83ed21c
Commit83ed21c
Direct Downloadjetpack-prototype-build-pr18345-83ed21c.apk
Note: Google Login is not supported on these builds.

@pachlava pachlava changed the title [UI Tests] Add domains card UI test [UI Tests] Add Domains Dashboard Card UI test May 1, 2023
@peril-wordpress-mobile
Copy link
Copy Markdown

Warnings
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@pachlava pachlava force-pushed the add-domains-card-ui-test branch from ff1dd8e to 8b20640 Compare May 2, 2023 06:53
@pachlava pachlava marked this pull request as ready for review May 2, 2023 09:10
@staskus staskus requested a review from irfano May 2, 2023 09:14
Copy link
Copy Markdown
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pachlava, for adding these tests! The tests are working well.
I have added one comment, and I would appreciate it if you could take it into consideration.

@pachlava pachlava requested a review from irfano May 4, 2023 06:46
@pachlava
Copy link
Copy Markdown
Contributor Author

pachlava commented May 4, 2023

FTL is back to normal again, so the Builkite is finally 🟢. Could you please take another look @irfano? 🙇

Copy link
Copy Markdown
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for addressing my request, everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Tests Anything related to automated UI Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants