[Dependency Updates] Update androidxComposeCompilerVersion and kotlinVersion to 1.4.6 and 1.8.20#18338
Merged
ovitrif merged 5 commits intodeps/update-dagger-to-2.45from May 2, 2023
Conversation
9 tasks
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18338-39baa12 | |
| Commit | 39baa12 | |
| Direct Download | wordpress-prototype-build-pr18338-39baa12.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18338-39baa12 | |
| Commit | 39baa12 | |
| Direct Download | jetpack-prototype-build-pr18338-39baa12.apk |
3 tasks
f665d11 to
fac613b
Compare
Release Notes (Compose Compiler): https://developer.android.com/ jetpack/androidx/releases/compose-compiler#1.4.6 Release Notes (Kotlin): https://github.com/ JetBrains/kotlin/releases/tag/v1.8.20
Warning Message: "Companion object of enum class 'FieldType' is uninitialized here. This warning will become an error in future releases. See https://youtrack.jetbrains.com/issue/KT-49110 for details" FYI: This warning will be raised to error in Kotlin version '1.9.0'. ------------------------------------------------------------------------ Existing Behavior: "When one accesses companion object or its members of an enum from the enum entry initializer, they can get an NPE there because the entries of an enum are initialized before the companion object of that enum at runtime. Some of such code was prohibited in Kotlin 1.1 (see KT-11769), but there are still ways to access companion from enum initializer. Note that sometimes the code does not throw an exception, just like this case, however it still observes an uninitialized state of a companion property, and thus needs fixing to avoid any future misbehavior." Proposed Changes: "It's proposed to prohibit all kinds of access to the companion object of an enum from an enum entry initializer." Impact: "Code like this won't compile. This is a rare case, because in most cases such code throws NPE or acts differently than users expect, so it should be fixed right away." ------------------------------------------------------------------------ This commit resolves this warning by creating a regular object inside the enum itself. Initialization of nested objects is not bound to initialization of the enum itself (in opposite to companion objects), so it's safe to access them during initialization of enum entries. Dmitriy Novozhilov (JetBrains): https://youtrack.jetbrains.com/issue/ KT-49110/Prohibit-access-to-members-of-companion-of-enum-class-from- initializers-of-entries-of-this-enum#focus=Comments-27-7246774.0-0 PS: Another idea would be to extract these function to a file, but I chose the 'regular object' idea so as to include only the bare minimum changes here.
Warning Message: "Composable functions with a return type should start with a lowercase letter" Explanation: "@composable functions without a return type should use similar naming to classes, starting with an uppercase letter and ending with a noun. @composable functions with a return type should be treated as normal Kotlin functions, starting with a lowercase letter." ------------------------------------------------------------------------ Renaming all composable functions with a return type to lowercase letter fix these warnings.
Warning Message: "Use AppCompatActivity.setSupportActionBar" Explanation: "Use AppCompatActivity.setSupportActionBar" ------------------------------------------------------------------------ Renaming 'setActionBar()' extension function to 'initActionBar()' automatically resolves this Lint warning as the 'setActionBar(...)' naming no longer collides with the legacy 'android.app.Activity' such, method, which was causing Lint to report a false positive Lint warning in the first place.
Warning Message: "This animation should be started with #start()" Explanation: "Many resources, such as TypedArrays, VelocityTrackers, etc., should be recycled (with a recycle() call) after use. This lint check looks for missing recycle() calls." ------------------------------------------------------------------------ These Lint warnings are suppressed, that is, instead of them being resolved, since a resolution would require a proper investigation and testing. As such, it might be best to ignore this as out of scope, for now, and so as to not introduce any breaking changes to this animation related functionalities that are related to 'AnimatorSet'. PS: Also the fact that the warning mentions 'start()' not being called, while it is, but it is calling upon missing 'recycler()' call, is a bit confusing.
59a3db1 to
39baa12
Compare
Contributor
|
Found 1 violations: The PR caused the following dependency changes: +--- androidx.databinding:viewbinding:7.2.1
| \--- androidx.annotation:annotation:1.0.0 -> 1.5.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20
-| +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.20
-| \--- org.jetbrains:annotations:13.0
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20
+| +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.20
+| \--- org.jetbrains:annotations:13.0
-+--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.20
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
++--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.20
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 (*)
+--- project :libs:analytics
| +--- com.automattic:Automattic-Tracks-Android:2.2.0
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.8.20 (*)
| | \--- io.sentry:sentry-android-okhttp -> 5.4.3
| | +--- com.squareup.okhttp3:okhttp -> 4.10.0
| | | +--- com.squareup.okio:okio:3.0.0 -> 3.2.0
| | | | \--- com.squareup.okio:okio-jvm:3.2.0
-| | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.7.20 (*)
+| | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.8.20 (*)
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.20 -> 1.7.20
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.20 -> 1.8.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.32 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.32 -> 1.8.20 (*)
| \--- androidx.preference:preference:1.2.0
| +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2
| | +--- androidx.activity:activity:1.2.4 -> 1.5.1
| | | +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1
| | | | +--- androidx.core:core-ktx:1.2.0 -> 1.8.0
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | | +--- androidx.savedstate:savedstate:1.2.0
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.7.20 (*)
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.8.20 (*)
-| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | | \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4
| | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4
| | | | | \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4
-| | | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.7.20 (*)
+| | | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.8.20 (*)
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21 -> 1.7.20
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21 -> 1.8.20
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | \--- androidx.fragment:fragment:1.3.6 -> 1.5.5
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| +--- androidx.fragment:fragment-ktx:1.3.6 -> 1.5.5
| | +--- androidx.activity:activity-ktx:1.5.1
| | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | +--- androidx.savedstate:savedstate-ktx:1.2.0
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | +--- androidx.collection:collection-ktx:1.1.0
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.8.20 (*)
| | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.5.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0
| | \--- androidx.customview:customview-poolingcontainer:1.0.0
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| \--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
| \--- androidx.window:window:1.0.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
+--- project :libs:image-editor
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20 (*)
| +--- androidx.navigation:navigation-fragment:2.4.2
| | +--- androidx.navigation:navigation-runtime:2.4.2
| | | +--- androidx.navigation:navigation-common:2.4.2
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.7.20
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.8.20
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.8.20
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 (*)
+--- project :libs:editor
| +--- org.wordpress:aztec:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| +--- org.wordpress.aztec:wordpress-comments:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20 (*)
| +--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.94.0
| | +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.8.20 (*)
| | +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.8.20 (*)
| | +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.94.0
| | | +--- org.wordpress.aztec:glide-loader:v1.6.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.8.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.8.20 (*)
+--- org.wordpress:fluxc:{strictly 2.26.0} -> 2.26.0
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 -> 1.8.20 (*)
| +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.8.20 (*)
| \--- androidx.room:room-ktx:2.4.2
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.8.20 (*)
+--- org.wordpress:utils:{strictly 3.6.1} -> 3.6.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 -> 1.8.20 (*)
+--- org.wordpress:login:1.3.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
+--- com.automattic:about:1.1.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.8.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.8.20 (*)
| +--- androidx.compose.ui:ui:1.0.5 -> 1.3.3
| | +--- androidx.compose.runtime:runtime:1.3.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | +--- androidx.compose.runtime:runtime-saveable:1.3.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | +--- androidx.compose.ui:ui-geometry:1.3.3
| | | +--- androidx.compose.ui:ui-util:1.3.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | +--- androidx.compose.ui:ui-graphics:1.3.3
| | | +--- androidx.compose.ui:ui-unit:1.3.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| | +--- androidx.compose.ui:ui-text:1.3.3
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| +--- androidx.compose.ui:ui-tooling:1.0.5 -> 1.3.3
| | +--- androidx.activity:activity-compose:1.3.0 -> 1.3.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.8.20 (*)
| | +--- androidx.compose.animation:animation:1.3.3
| | | +--- androidx.compose.animation:animation-core:1.3.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | | +--- androidx.compose.foundation:foundation-layout:1.0.0 -> 1.3.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| | +--- androidx.compose.material:material:1.0.0 -> 1.3.1
| | | +--- androidx.compose.foundation:foundation:1.2.0 -> 1.3.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| | | +--- androidx.compose.material:material-icons-core:1.3.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | | +--- androidx.compose.material:material-ripple:1.3.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| | +--- androidx.compose.ui:ui-tooling-data:1.3.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | +--- androidx.compose.ui:ui-tooling-preview:1.3.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| +--- androidx.navigation:navigation-compose:2.4.0-beta02
| | +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.4.0-rc01 -> 2.5.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.8.20 (*)
| \--- com.google.android.material:compose-theme-adapter:1.1.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
+--- com.automattic:stories:2.1.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.4.20 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.4.20 -> 1.8.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.8.20 (*)
| +--- org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc
| | \--- org.jetbrains.kotlinx:kotlinx-serialization-runtime-jvm:1.0-M1-1.4.0-rc
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.7.20
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.8.20
| +--- org.jetbrains.kotlin:kotlin-reflect:1.4.20
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.8.20 (*)
| +--- com.automattic.stories:photoeditor:2.1.0
-| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.8.20 (*)
| | \--- com.automattic.stories:mp4compose:2.1.0
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.8.20 (*)
| \--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.5.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
+--- com.google.android.flexbox:flexbox:3.0.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.8.20 (*)
+--- androidx.work:work-runtime-ktx:2.7.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.8.20 (*)
+--- com.zendesk:support:5.1.1
| +--- com.zendesk:support-providers:5.1.1
| | +--- com.zendesk:core:4.0.9
| | | +--- com.zendesk:java-common:2.0.0
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.8.20 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| | | \--- com.squareup.okhttp3:logging-interceptor:4.9.2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.8.20 (*)
| | +--- com.zendesk:guide-providers:1.0.9
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| +--- com.zendesk:guide:1.0.9
| | +--- com.zendesk:sdk-configurations:2.0.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| | +--- com.zendesk:messaging-api:5.2.5
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| | +--- com.zendesk:messaging:5.2.5
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| | | \--- com.zendesk:common-ui:4.0.5
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
+--- com.google.dagger:hilt-android:2.45
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.0 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.0 -> 1.8.20 (*)
+--- androidx.compose.runtime:runtime-livedata -> 1.3.3
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
+--- androidx.constraintlayout:constraintlayout-compose:1.0.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.10 -> 1.8.20 (*)
+--- io.coil-kt:coil-compose:2.2.2
| \--- io.coil-kt:coil-compose-base:2.2.2
| \--- io.coil-kt:coil-base:2.2.2
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10 -> 1.8.20 (*)
+--- com.airbnb.android:lottie-compose:5.2.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20 (*)
+\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.8.20 (*)
Please review and act accordingly
|
Contributor
Author
|
Awesome @ovitrif , thanks so much for reviewing, testing and merging this, you rock! 🪨 ❤️ 🚀 |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Parent #17563
Batch Branch: deps/main-batch-androidx-compose-kotlin
This PR update
androidxComposeCompilerVersionandkotlinVersionto 1.4.6 and 1.8.20 respectively.PS: @ovitrif I added you as the main reviewer, but not so randomly (context), since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
Compile Warnings Resolution List:
Lint Warnings Resolution List:
Lint Warnings Suppression List:
To test:
Kotlinupdate, smoke test both, the WordPress and Jetpack apps, and see if they both work as expected.Compose Compilerupdate, thoroughly smoke test any Compose related screens, on both, the WordPress and Jetpack apps, and see if they both work as expected.Kotlin Update:
Comment Editing Screen [UnifiedCommentsEditFragment.kt + UnifiedCommentsEditViewModel.kt + FieldType]
ℹ️ This test applies to both, the
JetpackandWordPressapps.Commentsscreen.Morebutton (bottom right) and then clickEdit.Edit Commentscreen is shown and functioning as expected. More specifically:Nameentry results into aUser name cannot be emptyerror.Web addressentry results into aWeb address not validerror.Email addressentry results into aUser email not validerror.Commententry results into aComment cannot be emptyerror.Compose Compiler Update:
1. Login Screen [LoginPrologueRevampedFragment.kt]
ℹ️ This test applies to both, the
WordPressandJetpackapps.Loginscreen is shown and functioning as expected.2. QR Code Auth Screen [QRCodeAuthFragment.kt]
ℹ️ This test applies to the
Jetpackapp.ℹ️ You don't have to follow all 3 steps, just logging in with a non
A8Cand non2FAenabledaccount, followed by tapping the
Scan Login Codeitem on theMescreen should be enough, whichis effectively just
Step.1and the beginning ofStep.3.Step.1:
Jetpackapp (note that you don't need a release build, a debug build willsuffice).
Jetpackapp with aWP.comaccount (note that you need to use a nonA8Caccountand a non
2FAenabled account).Mescreen (click on avatar at top-right).(STOP)
Step.2:
wordpress.com(note that if you are logged-in, log-out first).Log Inlink (top-right).Login via the mobile applink in the list of options below the main Continue button(bottom-middle).
Login via the mobile appview andUse QR Code to loginis shown, along witha QR code for you to scan.
Step.3:
Scan Login Codeitem on theMescreen you are currently at.verify that you have successfully logged-in and are able to use WordPress as expected.
3a. Jetpack Static Poster Screen [JetpackStaticPosterActivity.kt + JetpackStaticPosterFragment.kt]
ℹ️ This test applies to the
WordPressapp.My Sitetab ->MENUsub-tab.Trafficsection in the middle and click on itsStatsoption.Jetpack Static Posterscreen is shown and functioning as expected, that is,instead of showing the
Statsscreen (like it is done with theJetpackapp).3b. Jetpack Static Poster Screen [JetpackStaticPosterFragment.kt]
ℹ️ This test applies to the
WordPressapp.ReaderorNotificationstab.Jetpack Static Posterscreen is shown and functioning as expected, that is,instead of showing the
ReaderorNotificationsscreen (like it is done with theJetpackapp).4a. Jetpack Migration Screen [JetpackMigrationFragment.kt]
ℹ️ This test applies to the
Jetpackapp.My Sitetab ->HOMEsub-tab.Jetpack Migrationscreen is shown and functioning as expected.4a. Jetpack Migration Flow [JetpackMigrationFragment.kt]
ℹ️ This test applies to the
Jetpackapp.Jetpackapp and restart it.5. Blaze Screen [BlazeOverlayFragment.kt + BlazeWebViewFragment.kt]
ℹ️ This test applies to the
Jetpackapp.My Sitetab ->MENUsub-tab.Trafficsection in the middle and click on itsBlazeoption.Blazescreen is shown and functioning as expected.6. Blogging Prompts Screen [BloggingPromptsListActivity.kt]
ℹ️ This test applies to the
Jetpackapp.My Sitetab ->HOMEsub-tab.Promptscard on top and click on its options (top right).View more prompts.Blogging Promptsscreen is shown and functioning as expected.7. Individual Plugin Screen [WPJetpackIndividualPluginFragment.kt]
ℹ️ This test applies to the
WordPressapp.❗️ Apply the provided individual.patch patch to quickly test this screen.
My Sitetab ->Site Picker(down-arrow).individual.patchpatch do its magic... 🪄Individual Pluginscreen is shown and functioning as expected.8a. Jetpack Full Plugin Install Screen [JetpackFullPluginInstallOnboardingDialogFragment.kt + JetpackFullPluginInstallActivity.kt]
ℹ️ This test applies to the
WordPressapp.❗️ Apply the provided full.patch patch to quickly test this screen.
My Sitetab.full.patchpatch do its magic... 🪄Jetpack Full Plugin Installdialog is shown and functioning as expected.Install the full pluginbutton.Jetpack Full Plugin Installscreen is shown and functioning as expected.8b. Jetpack Install Full Plugin View [JetpackInstallFullPluginCardViewHolder.kt]
ℹ️ This test applies to the
Jetpackapp.❗️ Apply the provided card.patch patch to quickly test this screen.
Debug Settingsand make sure to enable onlyjetpack_removal_onefrom all the Jetpackremoval flags.
My Sitetab ->HOMEsub-tab.full.patchpatch do its magic... 🪄Learn more.Jetpack Full Plugin Installscreen is shown and functioning as expected.9. Jetpack Remove Install Screen [JetpackRemoteInstallActivity.kt]
ℹ️ This test applies to the
Jetpackapp.Jurassic Ninjawith noJetpackplugins at all.https://fieldguide.automattic.com/jurassic-ninja/
Stats.Install Jetpackbutton.Jetpack Remove Installscreen is shown and functioning as expected.10. Site Creation Domain View [SiteCreationDomainViewHolder.kt]
Debug Settingsand enable theSiteCreationDomainPurchasingFeatureConfigfeature flag.Site Picker-> Click the+button -> ChoseCreate WordPress.com site->Click the
SKIPbutton -> And again, click theSKIPbutton.Site Creation Domainview and its list is shown and functioning as expected.11. About App Screen [com.automattic:about]
ℹ️ This test applies to both, the
WordPressandJetpackapps.❗️ This test makes sure that the
About Appscreen, which comes from the com.automattic:aboutlibrary is also working as expected and that any transitive dependency changes aren't affecting
this
Composerelated screen.My Sitetab and navigate to theMescreen (click on avatar at top-right).About Appitem on theMescreen you are currently at.About Appscreen is shown and functioning as expected.Merge instructions
trunk.[PR] Not Ready For Merge]label.Regression Notes
Potential unintended areas of impact
Loginscreen, theJetpack Migrationscreens or theBlazegreen (to name a few).What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: