[Dependency Updates] Update `androidxRecyclerviewVersion` to 1.3.0 by ParaskP7 · Pull Request #18330 · wordpress-mobile/WordPress-Android

ParaskP7 · 2023-04-27T12:00:17Z

Parent #17563
Batch Branch: deps/main-batch-androidx-compose-kotlin

This PR updates androidxRecyclerviewVersion to 1.3.0.

Fix List: Remove manual jetpack compose interop config for recyclerview

FYI: @ovitrif please take a close look at this commit as it reverts the manual Jetpack Compose interop configuration for RecyclerView (52b264e). You can read the commit's description for more details.

For more info see: #17563 (comment)

PS: @ovitrif I added you as the main reviewer, but not so randomly (context), since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

To test:

See the dependency tree diff result and verify correctness.
Thoroughly smoke test any RecyclerView related screens (aka lists), on both, the WordPress and Jetpack apps, and see if everything is working as expected.
In addition to the above smoke test, you can expand the below and follow the inner and more explicitly test steps within, which is mainly related to this fix commit:

Site Creation Domain View [SiteCreationDomainViewHolder.kt]

ℹ️ This test applies to the Jetpack app.

Go to Debug Settings and enable the SiteCreationDomainPurchasingFeatureConfig feature flag.
Go to Site Picker -> Click the + button -> Chose Create WordPress.com site -> Click the SKIP button -> And again, click the SKIP button.
Enter any search query in the input (eg. 'awesome').
Verify the list of domain suggestions is presented (the item UI is compose)
Verify that the Site Creation Domain view and its list is shown and functioning as expected.

Merge instructions

Wait for this other PR to be reviewed, tested and approved.
Update PR's base deps/main-batch-androidx-compose-kotlin branch with latest trunk.
Update this PR with latest deps/main-batch-androidx-compose-kotlin and make sure everything is still working as expected.
Remove [PR] Not Ready For Merge] label.
Merge PR to deps/main-batch-androidx-compose-kotlin.

Regression Notes

Potential unintended areas of impact
- Potential breakage or misbehaviour on any or RecyclerView list related app functionalities (aka lists), like list of posts/pages, reader and reader details, media, site picker and creation, list of plugins, etc.
- Some of the transitive dependencies added might be causing some kind of misbehaviour.
- The Site Creation Domain view and its list might not be performing as expected.
What I did to test those areas of impact (or what existing automated tests I relied on)
- See To test section.
What automated tests I added (or what prevented me from doing so)
- N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

wpmobilebot · 2023-04-27T12:16:52Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18330-bce8e5a
	Commit	`bce8e5a`
	Direct Download	`wordpress-prototype-build-pr18330-bce8e5a.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-04-27T12:17:05Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18330-bce8e5a
	Commit	`bce8e5a`
	Direct Download	`jetpack-prototype-build-pr18330-bce8e5a.apk`

Note: Google Login is not supported on these builds.

Release Notes: https://developer.android.com/jetpack/androidx/releases/ recyclerview#recyclerview-1.3.0

This change effectively reverts the temporary changes introduced in this 236d18f and this ab46b8f commits to ensure optimal performance. Updating to 'Jetpack Compose' version '1.2.0-beta02' and above, which is already done (currently on 1.3.3), provides a better out-of-the-box performing solution. For more info see: https://github.com/wordpress-mobile/ WordPress-Android/issues/17563#issuecomment-1439830915

ParaskP7 · 2023-05-02T12:37:29Z

👋 @ovitrif and FYI that the PR and merge instructions have been just updated (rebase + force push), this PR is ready to be merged upon successful review and testing.

wpmobilebot · 2023-05-02T12:44:03Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:analytics
 |    \--- androidx.preference:preference:1.2.0
-|         \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1
-|              +--- androidx.annotation:annotation:1.1.0 -> 1.5.0 (*)
-|              +--- androidx.core:core:1.3.2 -> 1.8.0 (*)
-|              +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
-|              \--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
+|         \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0
+|              +--- androidx.annotation:annotation:1.1.0 -> 1.5.0 (*)
+|              +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
+|              +--- androidx.core:core:1.7.0 -> 1.8.0 (*)
+|              +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
+|              \--- androidx.customview:customview-poolingcontainer:1.0.0
+|                   +--- androidx.core:core-ktx:1.5.0 -> 1.8.0 (*)
+|                   \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
 +--- project :libs:image-editor
-|    +--- androidx.recyclerview:recyclerview:1.2.1 (*)
+|    +--- androidx.recyclerview:recyclerview:1.3.0 (*)
 |    +--- androidx.viewpager2:viewpager2:1.0.0
-|    |    \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
 |    \--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01
-|         \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+|         \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
 +--- project :libs:editor
 |    \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.94.0
 |         +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
 |         |    \--- com.google.android.exoplayer:exoplayer:2.13.3
 |         |         \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-|         |              \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+|         |              \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
 |         \--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.94.0
-|              \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+|              \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
 +--- org.wordpress:fluxc:{strictly 2.26.0} -> 2.26.0
 |    +--- androidx.paging:paging-runtime:2.1.2
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
-|    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+|    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
 +--- org.wordpress:utils:{strictly 3.6.1} -> 3.6.1
-|    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+|    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
 +--- com.automattic:about:1.1.0
 |    \--- androidx.compose.ui:ui:1.0.5 -> 1.3.3
-|         \--- androidx.customview:customview-poolingcontainer:1.0.0
-|              +--- androidx.core:core-ktx:1.5.0 -> 1.8.0 (*)
-|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+|         \--- androidx.customview:customview-poolingcontainer:1.0.0 (*)
 +--- com.automattic:stories:2.1.0
-|    \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+|    \--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-+--- androidx.recyclerview:recyclerview:1.2.1 (*)
++--- androidx.recyclerview:recyclerview:1.3.0 (*)
 \--- com.zendesk:support:5.1.1
      +--- com.zendesk:guide:1.0.9
-     |    \--- androidx.recyclerview:recyclerview -> 1.2.1 (*)
+     |    \--- androidx.recyclerview:recyclerview -> 1.3.0 (*)
-     \--- androidx.recyclerview:recyclerview -> 1.2.1 (*)
+     \--- androidx.recyclerview:recyclerview -> 1.3.0 (*)

Please review and act accordingly

ovitrif

Thanks a lot for properly handling this update @ParaskP7

Everything works and looks great 🥇

ParaskP7 · 2023-05-03T09:03:24Z

Awesome @ovitrif , thanks so much for reviewing, testing and merging this, you rock! 🪨 ❤️ 🚀

ParaskP7 added Tech Debt [Status] Not Ready for Merge labels Apr 27, 2023

ParaskP7 added this to the Future milestone Apr 27, 2023

ParaskP7 requested review from a team and ovitrif April 27, 2023 12:00

ParaskP7 self-assigned this Apr 27, 2023

ParaskP7 mentioned this pull request Apr 27, 2023

Dependency Updates - Main Batch - AndroidX Compose/Kotlin #17563

Closed

9 tasks

This was referenced Apr 28, 2023

Dependency Updates - Main Batch - AndroidX/Google #17566

Closed

[Dependency Updates] Update daggerVersion to 2.45 #18336

Merged

[Dependency Updates] Update androidxAppcompatVersion to 1.6.1 #18341

Closed

Base automatically changed from deps/update-coil-to-2.2.2 to deps/main-batch-androidx-compose-kotlin May 2, 2023 12:15

ParaskP7 added 2 commits May 2, 2023 15:30

Deps: Update androidx recyclerview to 1.3.0

7904c2f

Release Notes: https://developer.android.com/jetpack/androidx/releases/ recyclerview#recyclerview-1.3.0

ParaskP7 force-pushed the deps/update-androidx-recyclerview-to-1.3.0 branch from 52b264e to bce8e5a Compare May 2, 2023 12:35

ParaskP7 removed the [Status] Not Ready for Merge label May 2, 2023

ovitrif approved these changes May 2, 2023

View reviewed changes

ovitrif merged commit 2ec7fa0 into deps/main-batch-androidx-compose-kotlin May 2, 2023

ovitrif deleted the deps/update-androidx-recyclerview-to-1.3.0 branch May 2, 2023 14:37

ParaskP7 mentioned this pull request May 4, 2023

[Dependency Updates] Main Batch - AndroidX Compose/Kotlin (plus Core) #18364

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency Updates] Update `androidxRecyclerviewVersion` to 1.3.0#18330

[Dependency Updates] Update `androidxRecyclerviewVersion` to 1.3.0#18330
ovitrif merged 2 commits intodeps/main-batch-androidx-compose-kotlinfrom
deps/update-androidx-recyclerview-to-1.3.0

ParaskP7 commented Apr 27, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Apr 27, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Apr 27, 2023 •

edited

Loading

Uh oh!

ParaskP7 commented May 2, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented May 2, 2023

Uh oh!

ovitrif left a comment

Uh oh!

ParaskP7 commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ParaskP7 commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To test:

Merge instructions

Regression Notes

Uh oh!

wpmobilebot commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ParaskP7 commented May 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 2, 2023

The PR caused the following dependency changes:

Uh oh!

ovitrif left a comment

Choose a reason for hiding this comment

Uh oh!

ParaskP7 commented May 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ParaskP7 commented Apr 27, 2023 •

edited

Loading

wpmobilebot commented Apr 27, 2023 •

edited

Loading

wpmobilebot commented Apr 27, 2023 •

edited

Loading

ParaskP7 commented May 2, 2023 •

edited

Loading