Move media permissions from debug to main AndroidManifest#18259
Merged
ravishanker merged 1 commit intoParent-PR-for-updating-targetSdkVersion-to-33-(Android-13)from Apr 12, 2023
Conversation
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18259-b14689a | |
| Commit | b14689a | |
| Direct Download | wordpress-prototype-build-pr18259-b14689a.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18259-b14689a | |
| Commit | b14689a | |
| Direct Download | jetpack-prototype-build-pr18259-b14689a.apk |
1e15f0d
into
Parent-PR-for-updating-targetSdkVersion-to-33-(Android-13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR moves the following permissions from
/debug/AndroidManifest.xmltomain/AndroidManifest.xml.WRITE_EXTERNAL_STORAGE(was also already inmain/AndroidManifest.xml)READ_EXTERNAL_STORAGEREAD_MEDIA_IMAGESREAD_MEDIA_VIDEOREAD_MEDIA_AUDIOThese permissions were required for
WPScreenshotTestandJPScreenshotTest, but they are also required for the main project. So, they are needed in the main AndroidManifest file.To test:
WPScreenshotTest,JPScreenshotTestandJPScreenshotTest` should pass.Media permissions in the app
Regression Notes
Potential unintended areas of impact
WPScreenshotTest,JPScreenshotTestand media permissions in the app.What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually.
What automated tests I added (or what prevented me from doing so)
None because this PR doesn't introduce any change.
PR submission checklist:
RELEASE-NOTES.txtif necessary.