Warning Message: "Use of LayoutInflater.from(getActivity()) detected.
Consider using getLayoutInflater() instead"

Explanation: "Using LayoutInflater.from(Context) can return a
LayoutInflater that does not have the correct theme."

------------------------------------------------------------------------

Using the recommended 'getLayoutInflater()', and on those specific cases
via 'getActivity()', fix these warnings.

Warning Message: "WRITE_EXTERNAL_STORAGE no longer provides write access
when targeting Android 11+, even when using
'requestLegacyExternalStorage'"

Explanation: "Scoped storage is enforced on Android 10+
(or Android 11+ if using requestLegacyExternalStorage). In particular,
WRITE_EXTERNAL_STORAGE will no longer provide write access to all files;
it will provide the equivalent of READ_EXTERNAL_STORAGE instead."

------------------------------------------------------------------------

This warning is already addressed and will be fixed as part of the
ongoing Android 13 media permissions work (see PR below):

PR: #18183

Warning Message: "Calling `setType` after calling `setData` will clear
the data: Call `setDataAndType` instead?"

Explanation: "Intent provides the following APIs: setData(Uri) and
setType(String). Unfortunately, setting one clears the other. If you
want to set both, you should call setDataAndType(Uri, String) instead."

------------------------------------------------------------------------

This 78c2ea7 introduced this
functionality. Testing without the 'calIntent.data = Events.CONTENT_URI'
still works as expected. Thus, indeed it seems that the 'data' got
cleared by setting the 'type' afterwards, thus the code, if kept as is,
although still functioning, becomes misleading and worse, the 'data'
related 'Events.CONTENT_URI' information ends-up being missing from the
intent that starts the external calendar activity.

From the looks of it, it seems that the author's intentions were to
use both, 'data' and 'type'. As such, using the recommended
'setDataAndType(...)' fixes this warning.

------------------------------------------------------------------------

FOr more info see:
- Calendar provider overview (Doc):
https://developer.android.com/guide/topics/providers/calendar-provider
  - Use an intent to insert an event (Doc):
  https://developer.android.com/guide/topics/providers/calendar-provider
  #intent-insert

Warning Messages:
- "The locale folder "'he'" should be called "'iw'" instead; see the
'java.util.Locale' documentation"
- "The locale folder "'id'" should be called "'in'" instead; see the
'java.util.Locale' documentation"

Explanation: "From the java.util.Locale documentation:
"Note that Java uses several deprecated two-letter codes. The Hebrew
("he") language code is rewritten as "iw", Indonesian ("id") as "in",
and Yiddish ("yi") as "ji". This rewriting happens even if you construct
your own Locale object, not just for instances returned by the various
lookup methods.

Because of this, if you add your localized resources in for example
values-he they will not be used, since the system will look for
values-iw instead.

To work around this, place your resources in a values folder using the
deprecated language code instead."

------------------------------------------------------------------------

This Lint warning is moved within lint config and removed from Lint's
baseline because in order to resolve this warning a proper release
management localization solution should be set-up for both, the
WordPress and Jetpack apps. PS: The previous such Jetpack related
c272690 commit description was
misleading (describing this was already properly done on WordPress).

Related: Lint Warnings - Resolve 'LocaleFolder'
- #18226

Warning Message: "Redundant 'field' used for Dagger qualifier
annotation."

Explanation: "It's redundant to use 'field:' site-targets for qualifier
annotations."

------------------------------------------------------------------------

This was probably an oversight while
this efb4b8f commit was developed.
Removing the redundant 'field' site-target fixes these warnings.

Instead of using an arbitrary 'IO_THREAD' string value, it is better to
depend on using the 'IO_THREAD' constant from within the 'ThreadModule'
file, which anyway points to that same 'IO_THREAD' string value.

Warning Message: "Replace the <fragment> tag with
FragmentContainerView."

Explanation: "FragmentContainerView replaces the <fragment> tag as the
preferred way of adding fragments via XML. Unlike the <fragment> tag,
FragmentContainerView uses a normal FragmentTransaction under the hood
to add the initial fragment, allowing further FragmentTransaction
operations on the FragmentContainerView and providing a consistent
timing for lifecycle events."

------------------------------------------------------------------------

These warnings are suppressed on those files because the app crashes
otherwise with a 'ClassCastException' exception (see an example crash on
'AccountSettingsFragment' below):

------------------------------------------------------------------------
Caused by: java.lang.ClassCastException:
org.wordpress.android.ui.prefs.accountsettings.AccountSettingsFragment
cannot be cast to androidx.fragment.app.Fragment
------------------------------------------------------------------------

Warning Message: "Replace the <fragment> tag with
FragmentContainerView."

Explanation: "FragmentContainerView replaces the <fragment> tag as the
preferred way of adding fragments via XML. Unlike the <fragment> tag,
FragmentContainerView uses a normal FragmentTransaction under the hood
to add the initial fragment, allowing further FragmentTransaction
operations on the FragmentContainerView and providing a consistent
timing for lifecycle events."

------------------------------------------------------------------------

These warnings are suppressed on those files because the app crashes
otherwise with a 'UninitializedPropertyAccessException' exception
(see below):

------------------------------------------------------------------------
kotlin.UninitializedPropertyAccessException: lateinit property
widgetType has not been initialized
------------------------------------------------------------------------

Warning Message: "Replace the <fragment> tag with
FragmentContainerView."

Explanation: "FragmentContainerView replaces the <fragment> tag as the
preferred way of adding fragments via XML. Unlike the <fragment> tag,
FragmentContainerView uses a normal FragmentTransaction under the hood
to add the initial fragment, allowing further FragmentTransaction
operations on the FragmentContainerView and providing a consistent
timing for lifecycle events."

------------------------------------------------------------------------

Using the recommended '<androidx.fragment.app.FragmentContainerView>'
fix these warnings.