Warning Message: "'<uses-permission>' tag appears after
'<application>' tag"

Explanation: "The <application> tag should appear after the elements
which declare which version you need, which features you need, which
libraries you need, and so on. In the past there have been subtle bugs
(such as themes not getting applied correctly) when the <application>
tag appears before some of these other elements, so it's best to order
your manifest in the logical dependency order."

------------------------------------------------------------------------

Reordering the '<application>' and moving it after the
'<uses-permission>' tags fixes this warning.

Warning Message: "You should set an icon for the application as whole
because there is no default. This attribute must be set as a reference
to a drawable resource containing the image
(for example @drawable/icon)."

------------------------------------------------------------------------

Suppress this warning for the 'debug' source set should be enough for
the time being.

Warning Message: "Exported content providers can provide access to
potentially sensitive data"

Explanation: "Content providers are exported by default and any
application on the system can potentially use them to read and write
data. If the content provider provides access to sensitive data, it
should be protected by specifying export=false in the manifest or by
protecting it with a permission that can be granted to other
applications."

------------------------------------------------------------------------

This exported content provider was added as part of
dc7ba56 in order to enable content
migration from WordPress to Jetpack. The migration is currently still
in-progress (ish) so suppressing this for the the time being and at
least until the migration is fully complete.

Warning Message: "Very long vector path (X characters), which is bad for
performance. Considering reducing precision, removing minor details or
rasterizing vector."

Explanation: "Using long vector paths is bad for performance. There are
several ways to make the pathData shorter:
* Using less precision
* Removing some minor details
* Using the Android Studio vector conversion tool
* Rasterizing the image (converting to PNG)"

------------------------------------------------------------------------

As per the suggestions above, there are several ways to make the
'pathData' shorter. But, this is either requiring some additional
design help/work and then some extra testing too.

As such, suppressing these warnings, and as closer to source (pathData)
as possible, should be enough for the time being.

Later on, per 'pathData' and specific set of vector designs, an engineer
could closely collaborate with a designer to start updating those with
newer designs, one-by-one, and then test for correctness before merging
that change.

Warning Messages:
- "The locale folder "'he'" should be called "'iw'" instead; see the
'java.util.Locale' documentation"
- "The locale folder "'id'" should be called "'in'" instead; see the
'java.util.Locale' documentation"

Explanation: "From the java.util.Locale documentation:
"Note that Java uses several deprecated two-letter codes. The Hebrew
("he") language code is rewritten as "iw", Indonesian ("id") as "in",
and Yiddish ("yi") as "ji". This rewriting happens even if you construct
your own Locale object, not just for instances returned by the various
lookup methods.

Because of this, if you add your localized resources in for example
values-he they will not be used, since the system will look for
values-iw instead.

To work around this, place your resources in a values folder using the
deprecated language code instead."

------------------------------------------------------------------------

This Lint warning is moved within lint config and removed from Lint's
baseline because in order to resolve this warning a similar release
management localization solution should be set-up for the Jetpack app,
just like it is already done on the WordPress app.

Related: Lint Warnings - Resolve 'LocaleFolder'
- #18226

Warning Message: "Consider splitting data tag into multiple tags with
individual attributes to avoid confusion"

Explanation: "<intent-filter> <data> tags should only declare a single
unique attribute (i.e. scheme OR host, but not both). This better
matches the runtime behavior of intent filters, as they combine all of
the declared data attributes into a single matcher which is allowed to
handle any combination across attribute types.

For example, the following two <intent-filter> declarations are the
same:

<intent-filter>
    <data android:scheme="http" android:host="example.com" />
    <data android:scheme="https" android:host="example.org" />
</intent-filter>

<intent-filter>
    <data android:scheme="http"/>
    <data android:scheme="https"/>
    <data android:host="example.com" />
    <data android:host="example.org" />
</intent-filter>

They both handle all of the following:
* http://example.com
* https://example.com
* http://example.org
* https://example.org

The second one better communicates the combining behavior and is clearer
to an external reader that one should not rely on the scheme/host being
self contained. It is not obvious in the first that http://example.org
is also matched, which can lead to confusion (or incorrect behavior)
with a more complex set of schemes/hosts.

Note that this does not apply to host + port, as those must be declared
in the same <data> tag and are only associated with each other."

------------------------------------------------------------------------

Splitting the data tags into one 'scheme' tag (for 'jetpack') and
multiple 'host' tags (for 'viewpost', 'stats', 'read', 'post',
'notifications' and 'home') with individual attributes fixes these
warnings.

Warning Message: "You should set an icon for the application as whole
because there is no default. This attribute must be set as a reference
to a drawable resource containing the image
(for example @drawable/icon)."

------------------------------------------------------------------------

Suppress this warning for the 'jetpack' source set should be enough for
the time being.

Warning Message: "Modifier parameter should be the first optional
parameter"

Explanation: "The first (or only) Modifier parameter in a Composable
function should follow the following rules:
- Be named modifier
- Have a type of Modifier
- Either have no default value, or have a default value of Modifier
- If optional, be the first optional parameter in the parameter list"

------------------------------------------------------------------------

Reordering the 'modifier' parameter and moving it to become the first
optional parameter on the 'RepeatingColumn' composable function fixes
this warning.

Since there is no longer any other source set related section left
within the 'baseline.xml' configuration file, removing the only one such
remaining 'main' source set section is preferred to make this
Lint baseline file more straightforward and completely auto-generated.

… into analysis/resolve-debug-wordpress-jetpack-lint-warnings