Skip to content

[Dependency Updates] Update androidVolleyVersion to 1.2.1#18125

Merged
zwarm merged 1 commit intotrunkfrom
deps/update-android-volley-to-1.2.1
Mar 30, 2023
Merged

[Dependency Updates] Update androidVolleyVersion to 1.2.1#18125
zwarm merged 1 commit intotrunkfrom
deps/update-android-volley-to-1.2.1

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Mar 16, 2023

Parent #17568

This PR updates androidVolleyVersion to 1.2.1.

PS: @zwarm I added you as the main reviewer, randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

To test:

  1. See the dependency tree diff result and verify correctness.
  2. Thoroughly smoke test any network related functionality, on both, the WordPress and Jetpack apps, and see if they both work as expected.

FYI: I didn't add any explicit test steps to accommodate this update as Volley and the Networking module is being utilized in lots of places (expand classes per module list below). Thus, it is better to just test the app as a whole, by trying to test as many screens and functionalities as possible, and make sure that everything is working as expected.

PS: Having said the above, in that classes per module list below, I did provide most of the main classes that Volley and the Networking module is being used in order to make it easier for you to target specific screen and functionality while testing, like the Post, Reader and Notifications screens and its corresponding functionalities.

1. Networking Module
  • RestClientFactory
  • AuthenticatorRequest
  • RestClientUtils
2. Editor Module
  • AztecEditorFragment
  • GutenbergEditorFragment
  • ImageSettingsDialogFragment
3. WordPress Module
  • AppInitializer + BitmapLruCache
  • WordPress + LegacyModule
  • VolleyUtils + PeopleUtils + ReaderVideoUtils + NotificationsUtils
  • WPComSiteSettings + SiteSettingsTimezoneViewModel + NotificationsSettingsFragment
  • RecommendApiCallsProvider + InviteLinksApiCallsProvider + PostSeenStatusApiCallsProvider + PostSubscribersApiCallsProvider
  • ReaderCommentService + ReaderDiscoverLogic + ReaderPostLogic + ReaderSearchLogic + ReaderUpdateLogic + ReaderBlogActions + ReaderCommentActions + ReaderPostActions + ReaderTagActions
  • NotificationsProcessingService + NotificationsUpdateLogic + NotificationsActions + NotificationEvents
  • SuggestionService + ServerTrackingHandler
  • PublicizeUpdateService + PublicizeActions
  • SitePickerActivity
  • ReactNativeRequestHandler

Regression Notes

  1. Potential unintended areas of impact

    • Potential breakage or misbehaviour on any or all networking related app functionalities.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section above.

  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ParaskP7 ParaskP7 added this to the Future milestone Mar 16, 2023
@ParaskP7 ParaskP7 requested review from a team and zwarm March 16, 2023 16:14
@ParaskP7 ParaskP7 self-assigned this Mar 16, 2023
@ParaskP7 ParaskP7 mentioned this pull request Mar 16, 2023
Closed
5 tasks
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 16, 2023

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:editor
-|    \--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    \--- com.android.volley:volley:1.2.1
 +--- org.wordpress:fluxc:{strictly 2.17.0} -> 2.17.0
-|    \--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    \--- com.android.volley:volley:1.1.1 -> 1.2.1
 +--- org.wordpress:utils:{strictly 3.3.0} -> 3.3.0
-|    \--- com.android.volley:volley:1.2.0
+|    \--- com.android.volley:volley:1.2.0 -> 1.2.1
-\--- com.android.volley:volley:1.1.1 -> 1.2.0
+\--- com.android.volley:volley:1.2.1

Please review and act accordingly

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 16, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18125-6875b92
Commit6875b92
Direct Downloadwordpress-prototype-build-pr18125-6875b92.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 16, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18125-6875b92
Commit6875b92
Direct Downloadjetpack-prototype-build-pr18125-6875b92.apk
 Note: Google Login is not supported on these builds.

zwarm
zwarm approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi @ParaskP7

All is looking good here. I took the builds out for a spin. I created posts/pages with and without media. I did scheduled posts, drafts, deleted, etc. I ventured into the media area and uploaded videos, pictures from device, used pre-stock images, etc. I went through the reader functions, notifications, comments, app settings, site settings, activity log, stats, and a whole bunch more.

I suspect that if things weren't working as expected they would have showed up. Of course, Murphy's law is a you-know-what, so I am keeping 🤞. I am going to merge. The more eyes on this via trunk will provide the extra verification before it goes to Beta.

Thanks for spearheading the effort!!

@zwarm zwarm merged commit 9807036 into trunk Mar 30, 2023
@zwarm zwarm deleted the deps/update-android-volley-to-1.2.1 branch March 30, 2023 19:43
@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Mar 31, 2023

Awesome, thank you so much for reviewing, testing and merging this @zwarm , you rock! 🙇 ❤️ 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarm zwarm zwarm approved these changes

Assignees

@ParaskP7 ParaskP7

Labels

Tech Debt

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

3 participants

@ParaskP7 @wpmobilebot @zwarm