[Dependency Updates] Update `googleGsonVersion` to 2.10.1 by ParaskP7 · Pull Request #18124 · wordpress-mobile/WordPress-Android

ParaskP7 · 2023-03-16T14:21:06Z

This PR updates googleGsonVersion to 2.10.1.

PS: @thomashorta I added you as the main reviewer, randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

To test:

See the dependency tree diff result and verify correctness.
Thoroughly smoke test any Gson related functionality, on both, the WordPress and Jetpack apps, and see if they both work as expected.
In addition to the above smoke test, you can expand the below and follow the inner and more explicit test steps within (although testing just a few should be enough):

1. Me Screen & Share Jetpack with a Friend [RecommendApiCallsProvider.kt]

ℹ️ This test wouldn't work as the getRecommendTemplate() is only being triggered when state.isError() (see MeViewModel#L109). Thus, in order to test this scenario would would need to either figure out how to get an error state or manually update the code to trigger the getRecommendTemplate() anyway, no matter if there is an error state or not.

While on the My Site tab, click on your profile's icon (top right).
From the Me screen you are in, click on the Share Jetpack with a friend option.
Verify that the shared (to be copied) message/url is the expected one (see below for Jetpack).

Jetpack

Hey! Here is a link to download the Jetpack app. I'm really enjoying it and thought you might too.
https://jetpack.com/app?campaign=app_share_link

2. About Screen & Share with Friends [RecommendApiCallsProvider.kt]

While on the My Site tab, click on your profile's icon (top right).
From the Me screen you are in, click on the About WordPress/Jetpack option.
From the About screen you are in, click on the Share with Friends option.
Verify that the shared (to be copied) message/url is the expected one (see below for Jetpack).

Jetpack

Hey! Here is a link to download the Jetpack app. I'm really enjoying it and thought you might too.
https://jetpack.com/app?campaign=app_share_link

3. People Screen & Invite People [InviteLinksApiCallsProvider.kt]

⚠️ This test would only work if isLinksSectionVisible ends up being true (see PeopleInviteViewModel.kt#L246). Thus, in order to test this scenario would would need to either figure out how to get it being true or manually update the code to set this as true and take it from there. However, I couldn't proceed with testing this scenario even after this manual update.

While on the My Site tab and MENU sub-tab, click on the People option.
From the People screen you are in, click on the + icon (top right).
From the Invite People screen you are in, you should be able to see the Invite Link section and do something with it to get the invite links status (see ⚠️ above).
(❓) As such, I am not sure how to test this screen as I can't find a way to test this functionality.

4. Reader Screen & Filter [SubfilterListItemMapper.kt]

Go to Reader screen and FOLLOWING sub-tab, click on the Filter and chose either a SITE or a TOPIC to filter your view.
Verify that on screen configuration change (ie. rotation) everything is working as expected.

5. Site Page Creation & Choose a Layout [SubfilterListItemMapper.kt]

While on the My Site tab, click on the FAB and create a new site page.
Verify that the Choose a layout bottom sheet related screen appears, that all the various layouts are shown and that everything is working as expected.

6. Block Editor [Gutenberg]

Go to Posts screen and create a new post.
Add an Image, Gallery, Video, Audio, File, Media Text and Cover blocks to the post.
Publish this newly created post.
Verify that this newly created Block Editor related post of yours is being displayed as expected, both when previewing it from within the Posts and Reader screens. FYI: On Reader, you will find you post within the FOLLOWING tab.

7. Debug Cookies Screen [DebugCookieManager.kt]

ℹ️ I didn't test this myself as I am not sure how to best use this cookies debug screen.

While on the My Site tab, click on your profile's icon (top right).
From the Me screen you are in, click on the App Settings option.
From the App Settings screen you are in, click on the Debug settings option.
From the Debug settings screen you are in, scroll at the bottom and click on the Debug cookies option.
Verify that the Debug cookies screen is working as expected.

8. Local Migration Content Functionality [QueryResult.kt]

(❓) I am not sure how to best test this local migration content functionality and verify that everything migration related is working as expected.

Regression Notes

Potential unintended areas of impact
- Potential breakage or misbehaviour on any or all Gson related app functionalities, like share the app with friends, using a filter from within the Reader screen and creating posts that include various blocks (like Image, Video, etc).
What I did to test those areas of impact (or what existing automated tests I relied on)
- See To test section above.
What automated tests I added (or what prevented me from doing so)
- N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Release Notes: https://github.com/google/gson/releases/tag/ gson-parent-2.10.1

wpmobilebot · 2023-03-16T14:25:12Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:analytics
 |    \--- com.automattic:Automattic-Tracks-Android:2.2.0
 |         \--- io.sentry:sentry-android -> 5.4.3
 |              \--- io.sentry:sentry-android-core:5.4.3
 |                   \--- io.sentry:sentry:5.4.3
-|                        \--- com.google.code.gson:gson:2.8.5 -> 2.8.9
+|                        \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
 +--- project :libs:editor
-|    \--- com.google.code.gson:gson:2.6.2 -> 2.8.9
+|    \--- com.google.code.gson:gson:2.10.1
 +--- org.wordpress:fluxc:{strictly 2.17.0} -> 2.17.0
-|    \--- com.google.code.gson:gson:2.8.5 -> 2.8.9
+|    \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-+--- com.google.code.gson:gson:2.6.2 -> 2.8.9
++--- com.google.code.gson:gson:2.10.1
 \--- com.zendesk:support:5.1.1
      +--- com.zendesk:support-providers:5.1.1
      |    +--- com.zendesk:core:4.0.9
      |    |    \--- com.squareup.retrofit2:converter-gson:2.9.0
-     |    |         \--- com.google.code.gson:gson:2.8.5 -> 2.8.9
+     |    |         \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
      |    +--- com.zendesk:guide-providers:1.0.9
-     |    |    \--- com.google.code.gson:gson:2.8.9
+     |    |    \--- com.google.code.gson:gson:2.8.9 -> 2.10.1
-     |    \--- com.google.code.gson:gson:2.8.9
+     |    \--- com.google.code.gson:gson:2.8.9 -> 2.10.1
      +--- com.zendesk:guide:1.0.9
-     |    \--- com.google.code.gson:gson:2.8.9
+     |    \--- com.google.code.gson:gson:2.8.9 -> 2.10.1
-     \--- com.google.code.gson:gson:2.8.9
+     \--- com.google.code.gson:gson:2.8.9 -> 2.10.1

Please review and act accordingly

wpmobilebot · 2023-03-16T14:36:42Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18124-4f12a37
	Commit	`4f12a37`
	Direct Download	`jetpack-prototype-build-pr18124-4f12a37.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-03-16T14:38:35Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18124-4f12a37
	Commit	`4f12a37`
	Direct Download	`wordpress-prototype-build-pr18124-4f12a37.apk`

Note: Google Login is not supported on these builds.

thomashorta

Everything LGTM!

Thanks @ParaskP7 for the lib update! I was able to test some of the scenarios you presented, including the WP -> JP migration, and everything is working perfectly.

I will merge the PR!

ParaskP7 · 2023-03-20T08:42:14Z

Awesome, thanks so much for reviewing, testing and merging this @thomashorta ! 🙇 🎉 🚀

Deps: Update google gson to 2.10.1

4f12a37

Release Notes: https://github.com/google/gson/releases/tag/ gson-parent-2.10.1

ParaskP7 added Tech Debt dependency update labels Mar 16, 2023

ParaskP7 added this to the Future milestone Mar 16, 2023

ParaskP7 self-assigned this Mar 16, 2023

ParaskP7 mentioned this pull request Mar 16, 2023

Dependency Updates - Main Batch - Network #17568

Closed

5 tasks

ParaskP7 requested review from a team and thomashorta March 16, 2023 15:12

ParaskP7 marked this pull request as ready for review March 16, 2023 15:12

thomashorta approved these changes Mar 17, 2023

View reviewed changes

thomashorta merged commit 0d2eac3 into trunk Mar 17, 2023

thomashorta deleted the deps/update-google-gson-to-2.10.1 branch March 17, 2023 19:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency Updates] Update `googleGsonVersion` to 2.10.1#18124

[Dependency Updates] Update `googleGsonVersion` to 2.10.1#18124
thomashorta merged 1 commit intotrunkfrom
deps/update-google-gson-to-2.10.1

ParaskP7 commented Mar 16, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Mar 16, 2023

Uh oh!

wpmobilebot commented Mar 16, 2023

Uh oh!

wpmobilebot commented Mar 16, 2023

Uh oh!

thomashorta left a comment

Uh oh!

ParaskP7 commented Mar 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ParaskP7 commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To test:

Regression Notes

Uh oh!

wpmobilebot commented Mar 16, 2023

The PR caused the following dependency changes:

Uh oh!

wpmobilebot commented Mar 16, 2023

Uh oh!

wpmobilebot commented Mar 16, 2023

Uh oh!

thomashorta left a comment

Choose a reason for hiding this comment

Uh oh!

ParaskP7 commented Mar 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ParaskP7 commented Mar 16, 2023 •

edited

Loading