Skip to content

[Dependency Updates] Update googleAutoServiceVersion to 1.0.1#18076

Merged
ParaskP7 merged 1 commit intotrunkfrom
deps/update-google-autoservice-to-1.0.1
Mar 31, 2023
Merged

[Dependency Updates] Update googleAutoServiceVersion to 1.0.1#18076
ParaskP7 merged 1 commit intotrunkfrom
deps/update-google-autoservice-to-1.0.1

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Mar 9, 2023 •
edited
Loading

Parent #17570

This PR updates googleAutoServiceVersion to 1.0.1

PS: @zwarm I added you as the main reviewer, not so randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

To test:

  1. See the dependency tree diff result and verify correctness.
  2. Thoroughly smoke test any feature flag related functionality, remote features (@Feature), features in development (@FeatureInDevelopment) and remote field configs (@RemoteFieldDefaultGenerater) included, on both, the WordPress and Jetpack apps, and see if they both work as expected.
  3. In addition to the above smoke test, you can expand the below and follow the inner and more explicit test steps within (although testing the BlazeFeatureConfig should be enough):
1. BlazeFeatureConfig (@feature -> Remote Features)

Jetpack

  • Open app and notice the Blaze menu item shown below the Activity Log menu item (MENU sub-tap on My Site main tab). 🔥
  • Now go to Me screen -> App Settings -> Debug settings.
  • At the top, find the blaze remote feature and disable it.
  • Go back to the My Site main tab and MENU sub-tap and verify the Blaze menu item is no longer shown.
  • Do the same again, but this time enable the blaze remote feature and verify the Blaze menu item is shown again.
2. SiteCreationDomainPurchasingFeatureConfig (@FeatureInDevelopment -> Features in Development)
  • (❓) This is the most recent such feature flag configuration, and can be test through SiteCreationDomainsFragment, unfortunately, I am not sure how and would appreciate your help here.
3. BlazeFeatureConfig (@RemoteFieldDefaultGenerater -> Remote Field Configs)
  • (❓) This is the most recent such feature flag configuration, and can be test through BlazeWebViewFragment, unfortunately, I am not sure how and would appreciate your help here.
4. ExampleExperimentConfig (@experiment)
  • (❗) This ExampleExperimentConfig experiment related feature flag is unused and as such can't be tested atm.
  • (❗) There are no other @Experiment related feature flags, as such, this feature can't be tested atm.

Regression Notes

  1. Potential unintended areas of impact

    • Potential breakage or misbehaviour on any or all feature flag related app functionalities, like enabling/disabling a remote feature, a feature in development and/or a remote field configuration.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section above.

  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ParaskP7 ParaskP7 added this to the Future milestone Mar 9, 2023
@ParaskP7 ParaskP7 requested review from a team and zwarm March 9, 2023 15:07
@ParaskP7 ParaskP7 self-assigned this Mar 9, 2023
@ParaskP7 ParaskP7 mentioned this pull request Mar 9, 2023
Closed
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 9, 2023

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18076-d3b5463.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitd3b5463
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 9, 2023

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18076-d3b5463.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitd3b5463
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@ParaskP7 ParaskP7 mentioned this pull request Mar 9, 2023
Closed
5 tasks
zwarm
zwarm approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParaskP7 - 👋 It took a while to find the space of uninterrupted time to review this one, but I finally made it through.

I smoke tested the feature flag related functionality, remote features (@feature), features in development (@FeatureInDevelopment) and remote field configs (@RemoteFieldDefaultGenerater) included, on both, the WordPress and Jetpack apps. - All works as expected. I did not notice anything out of the ordinary.

I tested with the CI build + locally. I used my sandbox to proxy the api and set up my device to run traffic through charles. This was the only way to change the remote values to make sure the app worked as expected. You know what this process is like if you haven't done it in a while. 🤣 Certificates, ip address changes, SSL handshakes 🙉

✅ 1. BlazeFeatureConfig (@feature -> Remote Features)
✅ 2. SiteCreationDomainPurchasingFeatureConfig (@FeatureInDevelopment -> Features in Development)
✅ 3. BlazeFeatureConfig (@RemoteFieldDefaultGenerater -> Remote Field Configs)
4. ExampleExperimentConfig (https://github.com/experiment) - I was unable to test this one as thoroughly as I wanted since I don't think we've used it before.

I am going to approve, but let you make the decision to merge based on my ability to not test 4 as diligently as the rest.
🙏

@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Mar 31, 2023

👋 @zwarm and thank you so much for reviewing and testing this, you are awesome! 🙇 ❤️ 🚀

I smoke tested the feature flag related functionality, remote features (@feature), features in development (@FeatureInDevelopment) and remote field configs (@RemoteFieldDefaultGenerater) included, on both, the WordPress and Jetpack apps. - All works as expected. I did not notice anything out of the ordinary.

🎉

I tested with the CI build + locally. I used my sandbox to proxy the api and set up my device to run traffic through charles. This was the only way to change the remote values to make sure the app worked as expected. You know what this process is like if you haven't done it in a while. 🤣 Certificates, ip address changes, SSL handshakes 🙉

Yeaaa, I know how much fun all that is! 🤣 🙈 🙉 🙊

✅ 1. BlazeFeatureConfig (@feature -> Remote Features)
✅ 2. SiteCreationDomainPurchasingFeatureConfig (@FeatureInDevelopment -> Features in Development)
✅ 3. BlazeFeatureConfig (@RemoteFieldDefaultGenerater -> Remote Field Configs)

🎉

  1. ExampleExperimentConfig (https://github.com/experiment) - I was unable to test this one as thoroughly as I wanted since I don't think we've used it before.

Yea, as per the PR description this config is unused, and I too I am not sure about it (never used it). As such, I think it is safe to ignore it for now. When and if we'll get to use that again, if that doesn't work (for some unknown reason), we'll try and fix that then and there. 👍

I am going to approve, but let you make the decision to merge based on my ability to not test 4 as diligently as the rest.

Merging it is, thank YOU! 🚀 ❤️ 🙇

@ParaskP7 ParaskP7 merged commit 7c8de99 into trunk Mar 31, 2023
@ParaskP7 ParaskP7 deleted the deps/update-google-autoservice-to-1.0.1 branch March 31, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarm zwarm zwarm approved these changes

Assignees

@ParaskP7 ParaskP7

Labels

Tech Debt

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

3 participants

@ParaskP7 @wpmobilebot @zwarm