Update deprecated Intent and Bundle functions by irfano · Pull Request #18061 · wordpress-mobile/WordPress-Android

irfano · 2023-03-07T22:42:07Z

This PR is part of a parent PR to update compileSdk to 33.

The functions below were deprecated on Android 13.
Intent.getParcelableExtra()
Intent.getSerializableExtra()
Bundle.getParcelable()
Bundle.getParcelableArrayList()
Bundle.getSerializable()
To update these functions for Android 13, there are ready-to-use functions in IntentCompat and BundleCompat, but they're available on the androidx.core:1.10.0-beta01 version, which is not stable yet. I used CompatExtensions that I created to update deprecated functions.

To test:
Being able to build and basic smoke test should be enough.

Regression Notes

Potential unintended areas of impact
Navigation between screens may result in unintended behaviors.
What I did to test those areas of impact (or what existing automated tests I relied on)
I debugged suspicious changes manually.
What automated tests I added (or what prevented me from doing so)
Updated existing tests.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

CompatExtensions contains extension functions for deprecated functions of Bundle and Intent.

irfano · 2023-03-07T22:58:01Z

@ParaskP7, I have made changes based on your suggestions and applied your patches from your comment on the draft PR. There may be slight differences from your patch due to changes in some codes after syncing with the trunk.

Question (❓): This PR has not yet updated deprecated functions on Java files, and there are currently 154 usages of deprecated functions on Java files. I can't use the current extension functions in CopatExtensions as they are inline functions and hence inaccessible from Java files.
While I do not wish to modify CompatExtensions since it is better suited for Kotlin files, I have two options to resolve this issue:

I can create separate functions specifically for Java files.
I can postpone upgrading these functions until we have migrated Java files to Kotlin.

Personally, I prefer option 2 and prioritize Kotlin migration in our process. Wdyt?

wpmobilebot · 2023-03-07T22:59:24Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18061-4c32fd4.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`4c32fd4`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2023-03-07T23:00:23Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18061-4c32fd4.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`4c32fd4`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

ParaskP7

👋 @irfano !

I have reviewed and tested this PR as per the instructions, everything works as expected, great work on this!!! 🌟 🌟 🌟

I have left a couple of question/info comments for you (❓/ℹ️ ), one suggestions (💡) and some minor (🔍) comments for you to consider, plus praises (❤️).

I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.

About you question (❓) here, I agree with you, let's take option (2.) and update these functions at a later time, when/if we migrate those Java files to Kotlin, or else otherwise, when we are forced to update at that point when an SDK update will remove those deprecated APIs for good. 👍

PS: Maybe you would like to create an issue on that so that we are aware of this and could potentially pick this work up at some point in the future. Wdyt? 🤔

WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/ActivityLogListFragment.kt

...g/wordpress/android/ui/bloggingprompts/onboarding/BloggingPromptsOnboardingDialogFragment.kt

...Press/src/main/java/org/wordpress/android/ui/comments/unified/UnifiedCommentsEditActivity.kt

...Press/src/main/java/org/wordpress/android/ui/comments/unified/UnifiedCommentsEditFragment.kt

WordPress/src/main/java/org/wordpress/android/ui/domains/DomainRegistrationDetailsFragment.kt

WordPress/src/main/java/org/wordpress/android/ui/stories/StoryComposerActivity.kt

WordPress/src/main/java/org/wordpress/android/ui/JetpackRemoteInstallActivity.kt

WordPress/src/main/java/org/wordpress/android/util/extensions/CompatExtensions.kt

...s/src/test/java/org/wordpress/android/ui/accounts/login/jetpack/LoginNoSitesViewModelTest.kt

irfano · 2023-03-08T20:07:53Z

Thank you so much for your through review, @ParaskP7. ❤️

PS: Maybe you would like to create an issue on that so that we are aware of this and could potentially pick this work up at some point in the future. Wdyt? 🤔

Good idea. I created the issue.

peril-wordpress-mobile · 2023-03-08T20:41:26Z

	Warnings
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

ParaskP7 · 2023-03-09T10:05:37Z

Thank you so much for your through review, @ParaskP7. ❤️

No, thank you for applying all my suggestions, you are a beautiful human being @irfano ! 🙇 ❤️ 🚀

PS: Just for next time, feel free to skip any minor (🔍) comments, especially when those are subjective. I am just leaving those there for us to discuss and together become better engineers! 🤗

Good idea. I created the #18066.

Thank you so much for doing that! 🙇 ❤️

ParaskP7 · 2023-03-09T10:08:03Z

FYI @irfano that I only have 2 comments of mine left unresolved. However, please feel free to merge this PR when you are ready, it is still a ✅ from my side!

irfano · 2023-03-09T13:56:33Z

PS: Just for next time, feel free to skip any minor (🔍) comments, especially when those are subjective. I am just leaving those there for us to discuss and together become better engineers! 🤗

I really appreciate those comments. Let's keep up the good work! 💪🏻

FYI @irfano that I only have 2 comments of mine left unresolved. However, please feel free to merge this PR when you are ready, it is still a ✅ from my side!

I have resolved them and am currently merging.

irfano added 5 commits March 8, 2023 01:23

Add CompatExtensions

3489019

CompatExtensions contains extension functions for deprecated functions of Bundle and Intent.

Update deprecated functions of Intent and Bundle

851a448

Use type-safe functions for Bundle

f34517c

Replace get calls with indexing operator

dcb6e30

Move lambda arguments out of parentheses

b6a4373

irfano added the Android 13 label Mar 7, 2023

irfano added this to the 22.1 milestone Mar 7, 2023

irfano self-assigned this Mar 7, 2023

ParaskP7 self-assigned this Mar 8, 2023

ParaskP7 self-requested a review March 8, 2023 10:59

irfano mentioned this pull request Mar 8, 2023

Parent PR for updating compileSdk 33 #17947

Merged

8 tasks

ParaskP7 approved these changes Mar 8, 2023

View reviewed changes

This was referenced Mar 8, 2023

Update deprecated functions of Intent and Bundle on Java files #18066

Open

Make the QuickStartTask interface serializable wordpress-mobile/WordPress-FluxC-Android#2672

Open

irfano added 5 commits March 8, 2023 22:27

Add types to CompatExtensions functions

8d8edac

Reformat lines of commentIdentifier

ae617dc

Reformat lines for ViewModelProviders

0f4d567

Add null check for tracking source key

3b9109d

Fix a comment in CompatExtensions

d16d34d

irfano added the [Type] Task label Mar 8, 2023

ParaskP7 mentioned this pull request Mar 9, 2023

Update deprecated Parcel functions #18068

Merged

3 tasks

irfano added 2 commits March 9, 2023 14:30

Optimize type references on CompatExtensions functions

62375b2

Reformat lines for ViewModelProviders

de3e505

irfano removed their assignment Mar 9, 2023

Add comments to functions in CompatExtensions

4c32fd4

irfano merged commit 36ed7ac into feature/update-compile-sdk-33 Mar 9, 2023

irfano deleted the update-intent-bundle-functions branch March 9, 2023 13:56

Conversation

irfano commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

irfano commented Mar 7, 2023

Uh oh!

wpmobilebot commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ParaskP7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

irfano commented Mar 8, 2023

Uh oh!

peril-wordpress-mobile bot commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ParaskP7 commented Mar 9, 2023

Uh oh!

ParaskP7 commented Mar 9, 2023

Uh oh!

irfano commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

irfano commented Mar 7, 2023 •

edited

Loading

wpmobilebot commented Mar 7, 2023 •

edited

Loading

wpmobilebot commented Mar 7, 2023 •

edited

Loading

peril-wordpress-mobile bot commented Mar 8, 2023 •

edited

Loading