Skip to content

[Dependency Updates] Update uCropVersion to 2.2.8#18060

Merged
ParaskP7 merged 1 commit intotrunkfrom
deps/update-ucrop-to-2.2.8
Mar 14, 2023
Merged

[Dependency Updates] Update uCropVersion to 2.2.8#18060
ParaskP7 merged 1 commit intotrunkfrom
deps/update-ucrop-to-2.2.8

Conversation

@ParaskP7
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 commented Mar 7, 2023

Parent #17571

This PR updates uCropVersion to 2.2.8.

You could also check the changelog on the repo's main README.md file:

PS: @AjeshRPai I added you as the main reviewer, randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

To test:

  1. See the dependency tree diff result and verify correctness.
  2. Thoroughly smoke test any image cropping related functionality on both, the WordPress and Jetpack apps, and see if they both work as expected.
  3. In addition to the above smoke test, you can expand the below and follow the inner and more explicit test steps within:
1. Image Edit Screen [PreviewImageFragment.kt + CropFragment.kt]
  • Add a new blog post.
  • Add a new image block.
  • Choose an image and wait for it to be uploaded within the image block.
  • Click on the media options of this image (top right) and then click edit.
  • Crop the image and click the done menu option (top right).
  • Verify the image is updated accordingly.
2. My Site Tab [MySiteTabFragment.kt]
  • While on the My Site tab, click on your site's icon (top left).
  • A Site Icon dialog will appear. Click on CHANGE.
  • Choose an image and wait for the Edit Photo screen to appear.
  • Crop the image and click the done menu option (top right).
  • Verify the image is updated accordingly.
3. Me Screen [MeFragment.kt]
  • While on the My Site tab, click on your profile's icon (top right).
  • From the Me screen you are in, click on your profile's icon (CHANGE PHOTO).
  • Choose an image and wait for the Edit Photo screen to appear.
  • Crop the image and click the done menu option (top right).
  • Verify the image is updated accordingly.
4. Signup Epilogue Screen [SignupEpilogueFragment.kt]

ℹ️ This test only works when testing with the WordPress app.
⚠️ When I tried testing with the Jetpack app, the Signup Epilogue screen, although shown for a couple of seconds, it is then is being switched over by another screen, thus clicking on the profile's icon is not possible afterwards.

  • While logged-out, click on Log in or sign up with WordPress.com.
  • Enter an email address that hasn't been registered with WordPress.com and click Continue.
  • You will be navigated to a screen that will ask you to check your email for a verification link.
  • Click on the Sign up to WordPress.com verification link button.
  • You will be navigated to the Signup Epilogue screen.
  • Click on your profile's icon (top left).
  • Choose an image and wait for the Edit Photo screen to appear.
  • Crop the image and click the done menu option (top right).
  • Verify the image is updated accordingly.

Regression Notes

  1. Potential unintended areas of impact

    • Potential breakage or misbehaviour on any or all image cropping related app functionalities, like editing an image from within a post, or changing a site/profile image.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section above.

  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ParaskP7 ParaskP7 added this to the Future milestone Mar 7, 2023
@ParaskP7 ParaskP7 requested review from a team and AjeshRPai March 7, 2023 16:05
@ParaskP7 ParaskP7 self-assigned this Mar 7, 2023
@ParaskP7 ParaskP7 mentioned this pull request Mar 7, 2023
Closed
5 tasks
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 7, 2023

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:image-editor
-|    \--- com.github.yalantis:ucrop:2.2.4
-|         +--- androidx.exifinterface:exifinterface:1.1.0-beta01 -> 1.3.3
-|         |    \--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|         +--- androidx.transition:transition:1.2.0-rc01 -> 1.4.1 (*)
-|         \--- com.squareup.okhttp3:okhttp:3.12.1 -> 4.9.2 (*)
+|    \--- com.github.yalantis:ucrop:2.2.8
+|         +--- androidx.exifinterface:exifinterface:1.3.2 -> 1.3.3
+|         |    \--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         +--- androidx.transition:transition:1.4.1 (*)
+|         \--- com.squareup.okhttp3:okhttp:3.12.13 -> 4.9.2 (*)
-\--- com.github.yalantis:ucrop:2.2.4 (*)
+\--- com.github.yalantis:ucrop:2.2.8 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 7, 2023

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18060-ff6bc47.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitff6bc47
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Mar 7, 2023

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18060-ff6bc47.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitff6bc47
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

AjeshRPai
AjeshRPai approved these changes Mar 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ParaskP7

I have smoke tested the app with image cropping-related functionality on both the WordPress and Jetpack apps, and it works as expected. 🎉 🟢 👍🏼

I have tested the scenarios you had described in the PR description

  1. Image Edit Screen [PreviewImageFragment.kt + CropFragment.kt] 🟢
  2. My Site Tab [MySiteTabFragment.kt] 🟢
  3. Me Screen [MeFragment.kt] 🟢
  4. Signup Epilogue Screen [SignupEpilogueFragment.kt] 🟢

I am approving but not merging this PR so that if any one from @wordpress-mobile/apps-infrastructure wants to have a look. Please go ahead and merge at your convenience

@ParaskP7
Copy link
Copy Markdown
Contributor Author

ParaskP7 commented Mar 14, 2023

Awesome, thanks so much for the review and testing @AjeshRPai ! 🙇 🚀 ❤️

...but not merging this PR so that if any one from https://github.com/orgs/wordpress-mobile/teams/apps-infrastructure wants to have a look.

Just as FYI and as per the PR description (see below), next time, please feel free to merge this directly. There is no real need to wait in case someone from Apps Infra might want to have a look, I am adding Apps Infra mainly for monitoring purposes:

I also added the https://github.com/orgs/wordpress-mobile/teams/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

@ParaskP7 ParaskP7 merged commit 1bcc205 into trunk Mar 14, 2023
@ParaskP7 ParaskP7 deleted the deps/update-ucrop-to-2.2.8 branch March 14, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AjeshRPai AjeshRPai AjeshRPai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ParaskP7 ParaskP7

Labels

Tech Debt

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

3 participants

@ParaskP7 @wpmobilebot @AjeshRPai