Update deprecated back pressed event by irfano · Pull Request #18019 · wordpress-mobile/WordPress-Android

irfano · 2023-02-28T00:37:24Z

This PR is part of a parent PR to update compileSdk to 33.

onBackPressed() was deprecated on Android 13. This updates deprecated usages of onBackPressed.

Use onBackPressedDispatcher to trigger onBackPressed(): Activity's onBackPressed() calls are removed and updated with OnBackPressedDispatchers onBackPressed().
Migrate activities to OnBackPressedCallback: Overridings Activity's onBackPressed are removed. Instead, a callback is added to onBackPressedDispatcher. When I want to trigger super.onBackPressed(), I disabled the callback and triggered OnBackPressedDispatcher's onBackPressed() gain.

onBackPressedDispatcher.addCallback(this) {
     ...
     // The code below disables this callback and lets the system handle the back pressed (e.g., by finishing the activity)
     isEnabled = false
     onBackPressedDispatcher.onBackPressed()
}

Migrate dialogs to OnBackPressedCallback: We need to cast dialogs to ComponentDialog to be able to use OnBackPressedDispatcher. For this purpose, Dialog(requireContext(), theme) is converted to super.onCreateDialog(savedInstanceState)

To test:
Make sure the project is buildable and test back navigation on screens. It's very time-consuming to test all screens. But please test at least some screens from different cases, like a screen from an activity and a DialogFragment.

Regression Notes

Potential unintended areas of impact
The back navigation function could be broken on some screens.
What I did to test those areas of impact (or what existing automated tests I relied on)
I haven't tested all screens, but I tested some activities and all DialogFragments.
What automated tests I added (or what prevented me from doing so)
No new feature was added, and the existing tests were relied upon.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Activity's onBackPressed was deprecated on Android 13.

This just makes the code shorter by using an extension function.

wpmobilebot · 2023-02-28T00:55:50Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18019-bfcf01d.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`bfcf01d`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2023-02-28T00:57:22Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18019-bfcf01d.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`bfcf01d`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

ParaskP7

👋 @irfano !

Thank you so much for opening this PR, the work you did here really take us to the next level. This work will (hopefully) help us avoid redoing any such onBackPressed work in the future, and, no more dealing with deprecation such as that, win-win! 🎉

I reviewed and quickly tested your changes, I did identify some problems (I think, see ⚠️) and also posted few questions that I would like to discuss with you (see ❓), that is, before us merging this to its parent branch.

Thus, at this point I am going to request changes, but don't be alarmed too much. After we resolve/discuss on them, I am going to do another round of testing to verify that everything works as expected and we'll then merge this to its parent branch asap. 👍

WordPress/src/main/java/org/wordpress/android/ui/history/HistoryDetailActivity.kt

WordPress/src/main/java/org/wordpress/android/ui/sitecreation/SiteCreationActivity.kt

...ndroid/ui/jpfullplugininstall/onboarding/JetpackFullPluginInstallOnboardingDialogFragment.kt

WordPress/src/main/java/org/wordpress/android/ui/CollapseFullScreenDialogFragment.java

WordPress/src/main/java/org/wordpress/android/ui/comments/CommentsDetailActivity.java

...ress/src/main/java/org/wordpress/android/ui/deeplinks/DeepLinkingIntentReceiverActivity.java

OnBackPressedCallback was temporarily disabled to allow the system to handle the back button event.

peril-wordpress-mobile · 2023-03-02T21:54:30Z

	Warnings
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

ParaskP7

👋 @irfano and once more, thank you so much for all the work you did with this PR, research and coding included! 🥇

After reviewing the update, I now feel much more comfortable hitting the ✅ button! 🎉

Thus, at this point I am going to request changes, but don't be alarmed too much. After we resolve/discuss on them, I am going to do another round of testing to verify that everything works as expected and we'll then merge this to its parent branch asap. 👍

I did another round of testing and can verify that everything worked as expected, I didn't at least notice a crash... 💯

But, be mindful that I didn't go through all the screens/functionality to verify every back pressed logic. As such, and as discussed/planned already, I recommend that when the parent feature/update-compile-sdk-33 gets ready we take it for another spin of testing, this time thoroughly, while asking from QE to help us on that too.

Let's merge this! 🚀

irfano · 2023-03-06T15:53:23Z

But, be mindful that I didn't go through all the screens/functionality to verify every back pressed logic. As such, and as discussed/planned already, I recommend that when the parent feature/update-compile-sdk-33 gets ready we take it for another spin of testing, this time thoroughly, while asking from QE to help us on that too.

I am about to submit a request for a QE. I'll mention that back navigation is an important change that needs to be tested.
Thank you for your thorough review! You can merge it as the reviewer. 🚀

irfano added 6 commits February 28, 2023 00:46

Use onBackPressedDispatcher to trigger onBackPressed()

8648d0b

Activity's onBackPressed was deprecated on Android 13.

Migrate activities to OnBackPressedCallback

3bca5a7

Activity's onBackPressed was deprecated on Android 13.

Migrate dialogs to OnBackPressedCallback

bf693ec

Use extension function for OnBackPressedCallback

b1607f0

This just makes the code shorter by using an extension function.

Move lambda argument out pf parentheses

864b7db

Remove redundant null checks

0afe737

irfano added [Type] Task Android 13 labels Feb 28, 2023

irfano added this to the 22.1 milestone Feb 28, 2023

irfano requested a review from ParaskP7 February 28, 2023 00:37

irfano self-assigned this Feb 28, 2023

irfano mentioned this pull request Feb 28, 2023

Parent PR for updating compileSdk 33 #17947

Merged

8 tasks

ParaskP7 self-assigned this Feb 28, 2023

ParaskP7 requested changes Feb 28, 2023

View reviewed changes

irfano added 4 commits March 1, 2023 18:13

Add missing super.onBackPressed() behaviors

cc9f2e9

Fix loop issue of OnBackPressedCallback in SiteCreationActivity

3a3110e

OnBackPressedCallback was temporarily disabled to allow the system to handle the back button event.

Fix the crash on JetpackFullPluginInstallOnboardingDialogFragment

1808fd4

Refactor ComponentDialog casting

1749865

irfano requested a review from ParaskP7 March 2, 2023 22:06

irfano mentioned this pull request Mar 5, 2023

Add support for the predictive back gesture #18053

Open

irfano added 2 commits March 6, 2023 00:49

Refactor onBackPressed function in CollapseFullScreenDialogFragment

fb7a69c

Use CompatExtensions functions for migrating super.onBackPressed

bfcf01d

ParaskP7 approved these changes Mar 6, 2023

View reviewed changes

ParaskP7 merged commit 5364166 into feature/update-compile-sdk-33 Mar 6, 2023

ParaskP7 deleted the update-deprecated-onbackpressed branch March 6, 2023 16:45

SiobhyB mentioned this pull request Jun 29, 2023

StringIndexOutOfBoundsException: PhotonUtils.getPhotonImageUrl #18626

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update deprecated back pressed event#18019

Update deprecated back pressed event#18019
ParaskP7 merged 12 commits intofeature/update-compile-sdk-33from
update-deprecated-onbackpressed

irfano commented Feb 28, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 28, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 28, 2023 •

edited

Loading

Uh oh!

ParaskP7 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Mar 2, 2023

Uh oh!

ParaskP7 left a comment

Uh oh!

irfano commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

irfano commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

wpmobilebot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ParaskP7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Mar 2, 2023

Uh oh!

ParaskP7 left a comment

Choose a reason for hiding this comment

Uh oh!

irfano commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

irfano commented Feb 28, 2023 •

edited

Loading

wpmobilebot commented Feb 28, 2023 •

edited

Loading

wpmobilebot commented Feb 28, 2023 •

edited

Loading