[Dependency Updates] Update `googlePlayServicesCodeScannerVersion` to `16.0.0-beta3` by ParaskP7 · Pull Request #17996 · wordpress-mobile/WordPress-Android

ParaskP7 · 2023-02-21T15:42:53Z

This PR update googlePlayServicesCodeScannerVersion to 16.0.0-beta3.

Also, as part of this update the below transitive dependencies were added:

On the WordPress module (66a6ba4):
- com.google.mlkit:barcode-scanning-common

PS: @zwarm I added you as the main reviewer, not so randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

See the dependency tree diff result and verify correctness.
Thoroughly smoke test any code scanner related functionality on both, the WordPress and Jetpack apps, and see if they both work as expected.
In addition to the above smoke test, you can expand the below and follow the inner and more explicit test steps within:

Jetpack Scan Login Code

Step.1:

Build and install the Jetpack app (note that you don't need a release build, a debug build will suffice).
Login to the Jetpack app with a WP.com account (note that you need to use a non A8C account and a non 2FA enabled account).
Navigate to the Me screen (click on avatar at top-right).
(STOP)

Step.2:

Head over to your desktop and open a web browser (note that using an incognito tab works best).
Browse to wordpress.com (note that if you are logged-in, log-out first).
Tap the Log In link (top-right).
Tap the Login via the mobile app link in the list of options below the main Continue button (bottom-middle).
Verify you are on the Login via the mobile app view and Use QR Code to login is shown, along with a QR code for you to scan.
(STOP)

Step.3:

Head back to your mobile.
Tap the Scan Login Code item on the Me screen you are currently at.
Scan the QR code on the web browser.
Follow the remaining prompts on your mobile to login to WordPress on your web browser (desktop), verify that you have successfully logged-in and are able to use WordPress as expected.

Regression Notes

Potential unintended areas of impact
- Potential breakage or misbehaviour on any or all code scanning related app functionalities, like using QR code to login on your web browser (desktop) via the mobile app (Jetpack).
What I did to test those areas of impact (or what existing automated tests I relied on)
- See To test section above.
What automated tests I added (or what prevented me from doing so)
- N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

It is generally recommended that transitively used dependencies should be declared directly.

Release Notes: https://developers.google.com/android/guides/releases# august_16_2022

wpmobilebot · 2023-02-21T15:51:40Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- org.wordpress:login:1.0.0
 |    \--- com.google.android.gms:play-services-auth:18.1.0 -> 20.3.0
 |         +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
-|         |    +--- com.google.android.gms:play-services-base:18.0.1
-|         |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-|         |    |    +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
-|         |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
-|         |    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0
-|         |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-|         |    |    |    +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
-|         |    |    |    \--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
-|         |    |    \--- com.google.android.gms:play-services-tasks:18.0.1
-|         |    |         \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+|         |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0
+|         |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+|         |    |    +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
+|         |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+|         |    |    +--- com.google.android.gms:play-services-basement:18.1.0
+|         |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+|         |    |    |    +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
+|         |    |    |    \--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+|         |    |    \--- com.google.android.gms:play-services-tasks:18.0.2
+|         |    |         \--- com.google.android.gms:play-services-basement:18.1.0 (*)
-|         |    \--- com.google.android.gms:play-services-tasks:18.0.1 (*)
+|         |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
 |         +--- com.google.android.gms:play-services-auth-base:18.0.4
-|         |    +--- com.google.android.gms:play-services-base:18.0.1 (*)
+|         |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|         |    \--- com.google.android.gms:play-services-tasks:18.0.1 (*)
+|         |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|         +--- com.google.android.gms:play-services-base:18.0.1 (*)
+|         +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|         \--- com.google.android.gms:play-services-tasks:18.0.1 (*)
+|         \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
 +--- com.google.firebase:firebase-messaging:21.1.0
 |    +--- com.google.android.gms:play-services-cloud-messaging:16.0.0
-|    |    \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.1 (*)
+|    |    \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-|    +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.1 (*)
+|    +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
 |    +--- com.google.firebase:firebase-common:19.5.0
-|    |    \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.1 (*)
+|    |    \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
 |    \--- com.google.firebase:firebase-iid:21.1.0
-|         +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.1 (*)
+|         +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
 |         +--- com.google.firebase:firebase-iid-interop:17.1.0
-|         |    \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.1 (*)
+|         |    \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
 |         \--- com.google.firebase:firebase-installations:16.3.5
-|              +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.1 (*)
+|              +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
 |              \--- com.google.firebase:firebase-installations-interop:16.0.1
-|                   \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.1 (*)
+|                   \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-\--- com.google.android.gms:play-services-code-scanner:16.0.0-beta1
-     +--- androidx.activity:activity:1.3.1 -> 1.5.1 (*)
-     +--- com.google.android.datatransport:transport-api:2.2.1 (*)
-     +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
-     +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
-     +--- com.google.android.gms:play-services-base:18.0.1 (*)
-     +--- com.google.android.gms:play-services-basement:18.0.1 -> 18.1.0 (*)
-     +--- com.google.android.gms:play-services-tasks:18.0.1 (*)
-     +--- com.google.firebase:firebase-components:16.1.0 (*)
-     +--- com.google.firebase:firebase-encoders:16.1.0 (*)
-     +--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
-     +--- com.google.mlkit:barcode-scanning-common:17.0.0
-     |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
-     |    \--- com.google.mlkit:vision-common:17.0.0
-     |         +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.3 (*)
-     |         +--- com.google.android.datatransport:transport-api:2.2.1 (*)
-     |         +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
-     |         +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
-     |         +--- com.google.android.gms:play-services-base:18.0.1 (*)
-     |         +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
-     |         +--- com.google.android.gms:play-services-tasks:18.0.1 (*)
-     |         +--- com.google.android.odml:image:1.0.0-beta1
-     |         +--- com.google.firebase:firebase-components:16.1.0 (*)
-     |         +--- com.google.firebase:firebase-encoders:16.1.0 (*)
-     |         +--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
-     |         \--- com.google.mlkit:common:18.0.0 -> 18.3.0
-     |              +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
-     |              +--- com.google.android.datatransport:transport-api:2.2.1 (*)
-     |              +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
-     |              +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
-     |              +--- com.google.android.gms:play-services-base:18.0.1 (*)
-     |              +--- com.google.android.gms:play-services-basement:18.0.1 -> 18.1.0 (*)
-     |              +--- com.google.android.gms:play-services-tasks:18.0.1 (*)
-     |              +--- com.google.firebase:firebase-components:16.1.0 (*)
-     |              +--- com.google.firebase:firebase-encoders:16.1.0 (*)
-     |              \--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
-     \--- com.google.mlkit:common:18.3.0 (*)
++--- com.google.android.gms:play-services-code-scanner:16.0.0-beta3
+     +--- androidx.activity:activity:1.3.1 -> 1.5.1 (*)
+     +--- com.google.android.datatransport:transport-api:2.2.1 (*)
+     +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
+     +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
+     +--- com.google.android.gms:play-services-base:18.1.0 (*)
+     +--- com.google.android.gms:play-services-basement:18.1.0 (*)
+     +--- com.google.android.gms:play-services-tasks:18.0.2 (*)
+     +--- com.google.firebase:firebase-components:16.1.0 (*)
+     +--- com.google.firebase:firebase-encoders:16.1.0 (*)
+     +--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
+     +--- com.google.mlkit:barcode-scanning-common:17.0.0
+     |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+     |    \--- com.google.mlkit:vision-common:17.0.0
+     |         +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.3 (*)
+     |         +--- com.google.android.datatransport:transport-api:2.2.1 (*)
+     |         +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
+     |         +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
+     |         +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+     |         +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+     |         +--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+     |         +--- com.google.android.odml:image:1.0.0-beta1
+     |         +--- com.google.firebase:firebase-components:16.1.0 (*)
+     |         +--- com.google.firebase:firebase-encoders:16.1.0 (*)
+     |         +--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
+     |         \--- com.google.mlkit:common:18.0.0 -> 18.5.0
+     |              +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+     |              +--- com.google.android.datatransport:transport-api:2.2.1 (*)
+     |              +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
+     |              +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
+     |              +--- com.google.android.gms:play-services-base:18.1.0 (*)
+     |              +--- com.google.android.gms:play-services-basement:18.1.0 (*)
+     |              +--- com.google.android.gms:play-services-tasks:18.0.2 (*)
+     |              +--- com.google.firebase:firebase-components:16.1.0 (*)
+     |              +--- com.google.firebase:firebase-encoders:16.1.0 (*)
+     |              \--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
+     \--- com.google.mlkit:common:18.5.0 (*)
+\--- com.google.mlkit:barcode-scanning-common:17.0.0 (*)

Please review and act accordingly

wpmobilebot · 2023-02-21T16:04:31Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17996-c0ac56b.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`c0ac56b`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2023-02-21T16:05:08Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17996-c0ac56b.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`c0ac56b`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

zwarm

@ParaskP7 - All is working as expected. I don't see any missed dependencies. Additionally, the WP.com login with Jetpack app via qr code is working as normal. Thanks for wrangling this!

ParaskP7 · 2023-02-22T10:25:11Z

This is awesome, thanks for reviewing, testing and merging this PR @zwarm ! ❤️ 🚀 🙇

ParaskP7 added 2 commits February 21, 2023 16:42

Deps: Add play services code scanner transitively used dependencies

66a6ba4

It is generally recommended that transitively used dependencies should be declared directly.

Deps: Update google play services code scanner to 16.0.0-beta3

c0ac56b

Release Notes: https://developers.google.com/android/guides/releases# august_16_2022

ParaskP7 added Tech Debt dependency update labels Feb 21, 2023

ParaskP7 added this to the Future milestone Feb 21, 2023

ParaskP7 requested review from a team and zwarm February 21, 2023 15:42

ParaskP7 self-assigned this Feb 21, 2023

ParaskP7 mentioned this pull request Feb 21, 2023

Dependency Updates - Main Batch - Firebase/Google #17567

Closed

5 tasks

zwarm approved these changes Feb 21, 2023

View reviewed changes

zwarm merged commit d8fd3be into trunk Feb 21, 2023

zwarm deleted the deps/update-google-play-services-code-scanner-to-16.0.0-beta3 branch February 21, 2023 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency Updates] Update `googlePlayServicesCodeScannerVersion` to `16.0.0-beta3`#17996

[Dependency Updates] Update `googlePlayServicesCodeScannerVersion` to `16.0.0-beta3`#17996
zwarm merged 2 commits intotrunkfrom
deps/update-google-play-services-code-scanner-to-16.0.0-beta3

ParaskP7 commented Feb 21, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 21, 2023

Uh oh!

wpmobilebot commented Feb 21, 2023

Uh oh!

wpmobilebot commented Feb 21, 2023

Uh oh!

zwarm left a comment

Uh oh!

ParaskP7 commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ParaskP7 commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

wpmobilebot commented Feb 21, 2023

The PR caused the following dependency changes:

Uh oh!

wpmobilebot commented Feb 21, 2023

Uh oh!

wpmobilebot commented Feb 21, 2023

Uh oh!

zwarm left a comment

Choose a reason for hiding this comment

Uh oh!

ParaskP7 commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ParaskP7 commented Feb 21, 2023 •

edited

Loading