[Dependency Updates] Update googlePlayServicesAuthVersion to 20.4.1#17994
Merged
[Dependency Updates] Update googlePlayServicesAuthVersion to 20.4.1#17994
googlePlayServicesAuthVersion to 20.4.1#17994Conversation
Release Notes: https://developers.google.com/android/guides/releases# january_19_2023
5 tasks
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | cc1c56d | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | cc1c56d | |
zwarm
approved these changes
Feb 21, 2023
Contributor
There was a problem hiding this comment.
@ParaskP7
Thanks for the great test instructions. How would you feel about adding a line about deleting the bundle after testing is complete?
I was able to test the google sign in flow and all works as expected. 👏
Looks like there is a merge conflict, so I won't merge until you have a chance to look at it. :)
Contributor
Author
|
This is awesome, thanks for reviewing, testing and merging this PR @zwarm ! ❤️ 🚀 🙇
Oh, you are totally right, thanks for noticing, an important step indeed, I'll go ahead and update the testing instructions to add that line! 🌟 💯 🥇
Done! 👍 |
Contributor
|
Found 1 violations: The PR caused the following dependency changes: +--- org.wordpress:login:1.0.0
-| \--- com.google.android.gms:play-services-auth:18.1.0 -> 20.3.0
-| +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
-| +--- androidx.loader:loader:1.0.0 (*)
-| +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
-| | +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0
-| | | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-| | | +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
-| | | +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
-| | | +--- com.google.android.gms:play-services-basement:18.1.0
-| | | | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-| | | | +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
-| | | | \--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
-| | | \--- com.google.android.gms:play-services-tasks:18.0.2
-| | | \--- com.google.android.gms:play-services-basement:18.1.0 (*)
-| | +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
-| | \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-| +--- com.google.android.gms:play-services-auth-base:18.0.4
-| | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-| | +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-| | +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
-| | \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-| +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-| +--- com.google.android.gms:play-services-basement:18.1.0 (*)
-| \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+| \--- com.google.android.gms:play-services-auth:18.1.0 -> 20.4.1
+| +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+| +--- androidx.loader:loader:1.0.0 (*)
+| +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
+| | +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0
+| | | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+| | | +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
+| | | +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+| | | +--- com.google.android.gms:play-services-basement:18.1.0
+| | | | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+| | | | +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
+| | | | \--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+| | | \--- com.google.android.gms:play-services-tasks:18.0.2
+| | | \--- com.google.android.gms:play-services-basement:18.1.0 (*)
+| | +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+| | \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+| +--- com.google.android.gms:play-services-auth-base:18.0.4
+| | +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+| | +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+| | +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+| | \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+| +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+| +--- com.google.android.gms:play-services-basement:18.1.0 (*)
+| +--- com.google.android.gms:play-services-fido:19.0.1
+| | +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+| | +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+| | \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+| \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-\--- com.google.android.gms:play-services-auth:20.3.0 (*)
+\--- com.google.android.gms:play-services-auth:20.4.1 (*)
Please review and act accordingly
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent #17567
This PR update
googlePlayServicesAuthVersionto 20.4.1.PS: @zwarm I added you as the main reviewer, not so randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
To test:
WordPress Google Sign-inshould be enough):WordPress Google Sign-in
Prerequisite: If you don't have access to upload an
.aabto Google Play Store forWordPress - Website Builder, post a request to+systemsrequests.version.propertiesfile to pick a dummyversionNameandversionCode, preferable using a higherversionCodeto the existing one.versionCodeof1000000001and above.versionNamelikedeps-update-google-play-services-20-4-1(similar to the name of this branch itself).aablocally using this command:./gradlew bundleWordPressVanillaRelease.aab, found within theWordPress/build/outputs/bundle/wordpressVanillaRelease/build folder, and into Google Play Console (WordPress - Website Builder) via:App Bundle Explorer>Upload new version(top-right)Downloads, on theAssetssection, find theSigned, universal APKand click theDownloadicon (middle-right) to download the signed.apklocally..apkdownloaded locally, go ahead and click on theDelete app bundleto delete the this app bundle from the list of available app bundles..apkusing this command:adb install -r Downloads/wpandroid-deps-update-google-play-services-20-4-1-Signed.apk(note that you can use./tools/rename_apk_aab.shto rename the download signed.apk)Continue with Googlebutton (note that you need to use a nonA8Caccount to be able to complete this flow).Jetpack Google Sign-in
Prerequisite: If you don't have access to upload an
.aabto Google Play Store forJetpack - Website Builder, post a request to+systemsrequests.version.propertiesfile to pick a dummyversionNameandversionCode, preferable using a higherversionCodeto the existing one.versionCodeof1000000001and above.versionNamelikedeps-update-google-play-services-20-4-1(similar to the name of this branch itself).aablocally using this command:./gradlew bundleJetpackVanillaRelease.aab, found within theWordPress/build/outputs/bundle/jetpackVanillaRelease/build folder, and into Google Play Console (Jetpack - Website Builder) via:App Bundle Explorer>Upload new version(top-right)Downloads, on theAssetssection, find theSigned, universal APKand click theDownloadicon (middle-right) to download the signed.apklocally..apkdownloaded locally, go ahead and click on theDelete app bundleto delete the this app bundle from the list of available app bundles..apkusing this command:adb install -r Downloads/jpandroid-deps-update-google-play-services-20-4-1-Signed.apk(note that you can use./tools/rename_apk_aab.shto rename the download signed.apk)Continue with Googlebutton (note that you need to use a nonA8Caccount to be able to complete this flow).Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.