[Dependency Updates] Update `androidxPreferenceVersion` to 1.2.0 by ParaskP7 · Pull Request #17960 · wordpress-mobile/WordPress-Android

ParaskP7 · 2023-02-15T13:11:38Z

This PR update androidxPreferenceVersion to 1.2.0.

Note the fact that this update is solely related to PreferenceManager and its import androidx.preference.PreferenceManager import.

Everything else Preference related is not AndroidX Preference related, but rather related to the legacy Android Preference. You can quickly check that by searching for androidx.preference versus doing the same for android.preference.

As such, and because migrating from android.preference to androidx.preference is not trivial, not at all, anything android.preference related can be ignored (for now).

FYI: I will create a Preference related GitHub issue to share my finding on the android.preference to androidx.preference migration, suggest a way going forward and in general start the discussion on this topic.

PS: @thomashorta I added you as the main reviewer, but randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

To test:

See the dependency tree diff result and verify correctness.
Thoroughly smoke test any reference related functionality on both, the WordPress and Jetpack apps, and see if they both work as expected.
In addition to the above smoke test, you can expand the below and follow the inner and more explicit test steps within (although verifying on AppSettingsFragment.java should be enough):

1. AccountSettingsFragment.kt

Go to Me screen.
Click on the Account Settings button.
Verify that the Account Settings screen is displayed.
Click on each of the settings within the Account Settings screen and verify that every setting works as expected.

2. AppSettingsFragment.java

Go to Me screen.
Click on the App Settings button.
Verify that the App Settings screen is displayed.
Click on each of the settings within the App Settings screen and verify that every setting works as expected, including the inner settings like the Privacy Settings and Debug Settings screens.

3. SiteSettingsFragment.java

While on the My Site/MENU tab.
Click on the Site Settings button.
Verify that the Site Settings screen is displayed.
Click on each of the settings within the Site Settings screen and verify that every setting works as expected.

4. JetpackSecuritySettingsFragment.java

Prerequisite: You must have a Jetpack connected site, which displays this setting.
While on the My Site/MENU tab.
Click on the Jetpack Settings button.
Verify that the Security setting screen is displayed.
Click on each of the settings within the Security settings screen and verify that every setting works as expected.

5. NotificationsSettingsFragment.java

While on the Notifications tab.
Click on the Gear setting button (top-right).
Verify that the Notification Settings screen is displayed.
Click on each of the settings within the Notification Settings settings screen and verify that every setting works as expected.

6. EditPostActivity.java

Go to Post screen.
Edit a new post, which uses PreferenceManager to setDefaultValues(...) for Account Settings, add a few of the main blocks and verify that everything is workings as expected.

7. MySitesPage.java

Run the StatsTests UI test suite, which uses the MySitesPage.java class, and verify that all tests pass.

Regression Notes

Potential unintended areas of impact
- Potential breakage or misbehaviour on any or all settings related app functionalities, like post/page offline-to-online upload, blogging reminders, weekly roundup and local notifications.
What I did to test those areas of impact (or what existing automated tests I relied on)
- See To test section above.
What automated tests I added (or what prevented me from doing so)
- N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Release Notes: https://developer.android.com/jetpack/androidx/releases/ preference#1.2.0 ------------------------------------------------------------------------ This update is solely related to 'PreferenceManager' and its 'import androidx.preference.PreferenceManager' import. Everything else 'Preference' related is not 'AndroidX Preference' related, but rather related to the legacy 'Android Preference'. You can quickly check that by searching for 'androidx.preference' versus doing the same for 'android.preference'. ------------------------------------------------------------------------ As such, and because migrating from 'android.preference' to 'androidx.preference' is not trivial, not at all, anything 'android.preference' related can be ignored (for now).

wpmobilebot · 2023-02-15T13:18:38Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:analytics
-|    \--- androidx.preference:preference:1.1.0
-|         +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2
-|         |    +--- androidx.annotation:annotation:1.3.0
-|         |    +--- androidx.core:core:1.7.0 -> 1.8.0 (*)
-|         |    +--- androidx.cursoradapter:cursoradapter:1.0.0
-|         |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|         |    +--- androidx.activity:activity:1.2.4 -> 1.5.1
-|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-|         |    |    +--- androidx.core:core:1.8.0 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-runtime:2.5.1 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (c)
-|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1
-|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|         |    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0
-|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |    |    +--- androidx.core:core:1.8.0 (*)
-|         |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1
-|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
-|         |    |    |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
-|         |    |    |    |    \--- androidx.lifecycle:lifecycle-common:2.5.1 (*)
-|         |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
-|         |    |    |    +--- androidx.savedstate:savedstate:1.2.0
-|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
-|         |    |    |    |    +--- androidx.lifecycle:lifecycle-common:2.4.0 -> 2.5.1 (*)
-|         |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
-|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4
-|         |    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4
-|         |    |    |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4
-|         |    |    |         |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4
-|         |    |    |         |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 (c)
-|         |    |    |         |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (c)
-|         |    |    |         |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 (c)
-|         |    |    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
-|         |    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21
-|         |    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4 (*)
-|         |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
-|         |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
-|         |    |    +--- androidx.tracing:tracing:1.0.0 (*)
-|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    +--- androidx.fragment:fragment:1.3.6 -> 1.5.5
-|         |    |    +--- androidx.activity:activity:1.5.1 (*)
-|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.1.0
-|         |    |    +--- androidx.collection:collection:1.1.0 (*)
-|         |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (*)
-|         |    |    +--- androidx.loader:loader:1.0.0
-|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|         |    |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
-|         |    |    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.5.1
-|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
-|         |    |    |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
-|         |    |    |    |    \--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
-|         |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.5.1 (*)
-|         |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
-|         |    |    +--- androidx.viewpager:viewpager:1.0.0
-|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|         |    |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
-|         |    |    |    \--- androidx.customview:customview:1.0.0 -> 1.1.0
-|         |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |         +--- androidx.core:core:1.3.0 -> 1.8.0 (*)
-|         |    |    |         \--- androidx.collection:collection:1.1.0 (*)
-|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    +--- androidx.appcompat:appcompat-resources:1.4.2
-|         |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-|         |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|         |    |    +--- androidx.core:core:1.0.1 -> 1.8.0 (*)
-|         |    |    +--- androidx.vectordrawable:vectordrawable:1.1.0
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-|         |    |    |    \--- androidx.collection:collection:1.1.0 (*)
-|         |    |    \--- androidx.vectordrawable:vectordrawable-animated:1.1.0
-|         |    |         +--- androidx.vectordrawable:vectordrawable:1.1.0 (*)
-|         |    |         +--- androidx.interpolator:interpolator:1.0.0
-|         |    |         |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|         |    |         \--- androidx.collection:collection:1.1.0 (*)
-|         |    +--- androidx.drawerlayout:drawerlayout:1.0.0 -> 1.1.1
-|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
-|         |    |    \--- androidx.customview:customview:1.1.0 (*)
-|         |    +--- androidx.savedstate:savedstate:1.1.0 -> 1.2.0 (*)
-|         |    +--- androidx.emoji2:emoji2:1.0.0
-|         |    |    +--- androidx.collection:collection:1.1.0 (*)
-|         |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|         |    |    +--- androidx.lifecycle:lifecycle-process:2.4.0 -> 2.5.1 (*)
-|         |    |    +--- androidx.core:core:1.3.0 -> 1.8.0 (*)
-|         |    |    \--- androidx.startup:startup-runtime:1.0.0 -> 1.1.1 (*)
-|         |    +--- androidx.emoji2:emoji2-views-helper:1.0.0
-|         |    |    +--- androidx.emoji2:emoji2:1.0.0 (*)
-|         |    |    +--- androidx.collection:collection:1.1.0 (*)
-|         |    |    \--- androidx.core:core:1.3.0 -> 1.8.0 (*)
-|         |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-|         |    +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.5.1 (*)
-|         |    +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.5.1 (*)
-|         |    \--- androidx.resourceinspection:resourceinspection-annotation:1.0.0
-|         |         \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-|         +--- androidx.fragment:fragment:1.1.0 -> 1.5.5 (*)
-|         +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1
-|         |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    +--- androidx.core:core:1.3.2 -> 1.8.0 (*)
-|         |    +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
-|         |    \--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-|         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         \--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+|    \--- androidx.preference:preference:1.2.0
+|         +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2
+|         |    +--- androidx.annotation:annotation:1.3.0
+|         |    +--- androidx.core:core:1.7.0 -> 1.8.0 (*)
+|         |    +--- androidx.cursoradapter:cursoradapter:1.0.0
+|         |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|         |    +--- androidx.activity:activity:1.2.4 -> 1.5.1
+|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+|         |    |    +--- androidx.core:core:1.8.0 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-runtime:2.5.1 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (c)
+|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1
+|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|         |    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0
+|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |    |    +--- androidx.core:core:1.8.0 (*)
+|         |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1
+|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
+|         |    |    |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
+|         |    |    |    |    \--- androidx.lifecycle:lifecycle-common:2.5.1 (*)
+|         |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
+|         |    |    |    +--- androidx.savedstate:savedstate:1.2.0
+|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
+|         |    |    |    |    +--- androidx.lifecycle:lifecycle-common:2.4.0 -> 2.5.1 (*)
+|         |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
+|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4
+|         |    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4
+|         |    |    |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4
+|         |    |    |         |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4
+|         |    |    |         |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 (c)
+|         |    |    |         |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (c)
+|         |    |    |         |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 (c)
+|         |    |    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
+|         |    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21
+|         |    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4 (*)
+|         |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
+|         |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
+|         |    |    +--- androidx.tracing:tracing:1.0.0 (*)
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    +--- androidx.fragment:fragment:1.3.6 -> 1.5.5
+|         |    |    +--- androidx.activity:activity:1.5.1 (*)
+|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.1.0
+|         |    |    +--- androidx.collection:collection:1.1.0 (*)
+|         |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (*)
+|         |    |    +--- androidx.loader:loader:1.0.0
+|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|         |    |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+|         |    |    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.5.1
+|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
+|         |    |    |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
+|         |    |    |    |    \--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
+|         |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.5.1 (*)
+|         |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
+|         |    |    +--- androidx.viewpager:viewpager:1.0.0
+|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|         |    |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+|         |    |    |    \--- androidx.customview:customview:1.0.0 -> 1.1.0
+|         |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |         +--- androidx.core:core:1.3.0 -> 1.8.0 (*)
+|         |    |    |         \--- androidx.collection:collection:1.1.0 (*)
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    +--- androidx.appcompat:appcompat-resources:1.4.2
+|         |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+|         |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         |    |    +--- androidx.core:core:1.0.1 -> 1.8.0 (*)
+|         |    |    +--- androidx.vectordrawable:vectordrawable:1.1.0
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
+|         |    |    |    \--- androidx.collection:collection:1.1.0 (*)
+|         |    |    \--- androidx.vectordrawable:vectordrawable-animated:1.1.0
+|         |    |         +--- androidx.vectordrawable:vectordrawable:1.1.0 (*)
+|         |    |         +--- androidx.interpolator:interpolator:1.0.0
+|         |    |         |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|         |    |         \--- androidx.collection:collection:1.1.0 (*)
+|         |    +--- androidx.drawerlayout:drawerlayout:1.0.0 -> 1.1.1
+|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
+|         |    |    \--- androidx.customview:customview:1.1.0 (*)
+|         |    +--- androidx.savedstate:savedstate:1.1.0 -> 1.2.0 (*)
+|         |    +--- androidx.emoji2:emoji2:1.0.0
+|         |    |    +--- androidx.collection:collection:1.1.0 (*)
+|         |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         |    |    +--- androidx.lifecycle:lifecycle-process:2.4.0 -> 2.5.1 (*)
+|         |    |    +--- androidx.core:core:1.3.0 -> 1.8.0 (*)
+|         |    |    \--- androidx.startup:startup-runtime:1.0.0 -> 1.1.1 (*)
+|         |    +--- androidx.emoji2:emoji2-views-helper:1.0.0
+|         |    |    +--- androidx.emoji2:emoji2:1.0.0 (*)
+|         |    |    +--- androidx.collection:collection:1.1.0 (*)
+|         |    |    \--- androidx.core:core:1.3.0 -> 1.8.0 (*)
+|         |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+|         |    +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.5.1 (*)
+|         |    +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.5.1 (*)
+|         |    \--- androidx.resourceinspection:resourceinspection-annotation:1.0.0
+|         |         \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         +--- androidx.core:core:1.6.0 -> 1.8.0 (*)
+|         +--- androidx.fragment:fragment-ktx:1.3.6 -> 1.5.5
+|         |    +--- androidx.activity:activity-ktx:1.5.1
+|         |    |    +--- androidx.activity:activity:1.5.1 (*)
+|         |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.8.0 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1
+|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|         |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.5.1 (*)
+|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1
+|         |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
+|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4 (*)
+|         |    |    +--- androidx.savedstate:savedstate-ktx:1.2.0
+|         |    |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
+|         |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    +--- androidx.collection:collection-ktx:1.1.0
+|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.21 (*)
+|         |    |    \--- androidx.collection:collection:1.1.0 (*)
+|         |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
+|         |    +--- androidx.fragment:fragment:1.5.5 (*)
+|         |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.5.1
+|         |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 (*)
+|         |    +--- androidx.savedstate:savedstate-ktx:1.2.0 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1
+|         |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    +--- androidx.core:core:1.3.2 -> 1.8.0 (*)
+|         |    +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
+|         |    \--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+|         +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
+|         |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    +--- androidx.customview:customview:1.1.0 (*)
+|         |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
+|         |    +--- androidx.window:window:1.0.0
+|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.21 (*)
+|         |    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
+|         |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         |    |    +--- androidx.collection:collection:1.1.0 (*)
+|         |    |    \--- androidx.core:core:1.3.2 -> 1.8.0 (*)
+|         |    \--- androidx.transition:transition:1.4.1
+|         |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |         +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
+|         |         \--- androidx.collection:collection:1.1.0 (*)
+|         \--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
 +--- project :libs:image-editor
-|    +--- androidx.activity:activity-ktx:1.5.1
-|    |    +--- androidx.activity:activity:1.5.1 (*)
-|    |    +--- androidx.core:core-ktx:1.1.0 -> 1.8.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.5.1 (*)
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4 (*)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1
-|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4 (*)
-|    |    +--- androidx.savedstate:savedstate-ktx:1.2.0
-|    |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|    +--- androidx.activity:activity-ktx:1.5.1 (*)
 |    +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01
-|    |    \--- androidx.transition:transition:1.2.0 -> 1.4.1
-|    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|    |         +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-|    |         \--- androidx.collection:collection:1.1.0 (*)
+|    |    \--- androidx.transition:transition:1.2.0 -> 1.4.1 (*)
 |    \--- androidx.navigation:navigation-fragment:2.4.2
-|         +--- androidx.fragment:fragment-ktx:1.4.1 -> 1.5.5
-|         |    +--- androidx.activity:activity-ktx:1.5.1 (*)
-|         |    +--- androidx.collection:collection-ktx:1.1.0
-|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.21 (*)
-|         |    |    \--- androidx.collection:collection:1.1.0 (*)
-|         |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
-|         |    +--- androidx.fragment:fragment:1.5.5 (*)
-|         |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.5.1
-|         |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
-|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 (*)
-|         |    +--- androidx.savedstate:savedstate-ktx:1.2.0 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         +--- androidx.fragment:fragment-ktx:1.4.1 -> 1.5.5 (*)
-|         \--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
-|              +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|              +--- androidx.customview:customview:1.1.0 (*)
-|              +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-|              +--- androidx.window:window:1.0.0
-|              |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.21 (*)
-|              |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
-|              |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|              |    +--- androidx.collection:collection:1.1.0 (*)
-|              |    \--- androidx.core:core:1.3.2 -> 1.8.0 (*)
-|              \--- androidx.transition:transition:1.4.1 (*)
+|         \--- androidx.slidingpanelayout:slidingpanelayout:1.2.0 (*)
 +--- project :libs:editor
-|    \--- androidx.preference:preference:1.1.0 (*)
+|    \--- androidx.preference:preference:1.2.0 (*)
-\--- androidx.preference:preference:1.1.0 (*)
+\--- androidx.preference:preference:1.2.0 (*)

Please review and act accordingly

wpmobilebot · 2023-02-15T13:29:16Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17960-67615f7.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`67615f7`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2023-02-15T13:29:31Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17960-67615f7.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`67615f7`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

ParaskP7 · 2023-02-15T16:00:46Z

FYI: I will create a Preference related GitHub issue to share my finding on the android.preference to androidx.preference migration, suggest a way going forward and in general start the discussion on this topic.

The GitHub issue is now ready: [Preference Migration] Migrate Legacy Android Preference to AndroidX Preference #17962

thomashorta

Everything LGTM!

ParaskP7 · 2023-02-23T08:40:14Z

Awesome, thank you so much for reviewing, testing and merging this @thomashorta ! 🎉 ❤️ 🙇

ParaskP7 added Tech Debt dependency update labels Feb 15, 2023

ParaskP7 added this to the Future milestone Feb 15, 2023

ParaskP7 requested review from a team and thomashorta February 15, 2023 13:11

ParaskP7 self-assigned this Feb 15, 2023

This was referenced Feb 15, 2023

Dependency Updates - Main Batch - AndroidX/Google #17566

Closed

[Preference Migration] Migrate Legacy Android Preference to AndroidX Preference #17962

Closed

thomashorta approved these changes Feb 22, 2023

View reviewed changes

thomashorta merged commit 40cd984 into trunk Feb 22, 2023

thomashorta deleted the deps/update-androidx-preference-to-1.2.0 branch February 22, 2023 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency Updates] Update `androidxPreferenceVersion` to 1.2.0#17960

[Dependency Updates] Update `androidxPreferenceVersion` to 1.2.0#17960
thomashorta merged 1 commit intotrunkfrom
deps/update-androidx-preference-to-1.2.0

ParaskP7 commented Feb 15, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 15, 2023

Uh oh!

wpmobilebot commented Feb 15, 2023

Uh oh!

wpmobilebot commented Feb 15, 2023

Uh oh!

ParaskP7 commented Feb 15, 2023

Uh oh!

thomashorta left a comment

Uh oh!

ParaskP7 commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ParaskP7 commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

wpmobilebot commented Feb 15, 2023

The PR caused the following dependency changes:

Uh oh!

wpmobilebot commented Feb 15, 2023

Uh oh!

wpmobilebot commented Feb 15, 2023

Uh oh!

ParaskP7 commented Feb 15, 2023

Uh oh!

thomashorta left a comment

Choose a reason for hiding this comment

Uh oh!

ParaskP7 commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ParaskP7 commented Feb 15, 2023 •

edited

Loading