[Dependency Updates] Update `androidxFragmentVersion` to 1.5.5 by ParaskP7 · Pull Request #17696 · wordpress-mobile/WordPress-Android

ParaskP7 · 2022-12-23T17:06:28Z

Parent #17561
Batch Branch: deps/main-batch-androidx-core

This PR updates androidxFragmentVersion to 1.5.5.

Also, this PR adds the androidxActivityVersion of 1.5.1 (9aa97e3). This is NOT the latest version of androidx.activity.

Also, as part of this update the below transitive dependencies were added:

On the Image Editor module (0cf7c0b):
- androidx.fragment:fragment
On the Editor module (0914722):
- androidx.fragment:fragment

Note that the latest 1.6.1 update of androidxActivityVersion requires libraries and applications that depend on it to compile against version 33 (Android 13) or later of the Android APIs. However, this project is currently compiled against android-31 (Android 12).

Thus, until the compileSdkVersion of this project gets updated to 33, updating to 1.6.1 isn't possible.

More details

* What went wrong:
Execution failed for task ':WordPress:checkWordpressWasabiDebugAarMetadata'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
 > 2 issues were found when checking AAR metadata:
   
     1.  Dependency 'androidx.activity:activity:1.6.1' requires libraries and applications that
         depend on it to compile against version 33 or later of the
         Android APIs.
   
         :WordPress is currently compiled against android-31.
   
         Also, the maximum recommended compile SDK version for Android Gradle
         plugin 7.2.1 is 32.
   
         Recommended action: Update this project's version of the Android Gradle
         plugin to one that supports 33, then update this project to use
         compileSdkVerion of at least 33.
   
         Note that updating a library or application's compileSdkVersion (which
         allows newer APIs to be used) can be done separately from updating
         targetSdkVersion (which opts the app in to new runtime behavior) and
         minSdkVersion (which determines which devices the app can be installed
         on).
   
     2.  Dependency 'androidx.activity:activity-ktx:1.6.1' requires libraries and applications that
         depend on it to compile against version 33 or later of the
         Android APIs.
   
         :WordPress is currently compiled against android-31.
   
         Also, the maximum recommended compile SDK version for Android Gradle
         plugin 7.2.1 is 32.
   
         Recommended action: Update this project's version of the Android Gradle
         plugin to one that supports 33, then update this project to use
         compileSdkVerion of at least 33.
   
         Note that updating a library or application's compileSdkVersion (which
         allows newer APIs to be used) can be done separately from updating
         targetSdkVersion (which opts the app in to new runtime behavior) and
         minSdkVersion (which determines which devices the app can be installed
         on).

In addition to the dependency update commits, a couple of additional analysis related commits were added to migrate the Options Menu API update on the androidx.fragment library itself, expand per screen and see commit breakdown below:

Code Review Instructions:

I recommend doing a commit-by-commit review.
Please focus more on the 🌟 commits and skimming through the 🔍 ones.
Check out the ❗ commit but timebox your investigation, that is, if you'll do any. Don't invest to much time on it is not a hard requirement for this update.

[Image Editor]

1. CropFragment.kt

2. PreviewImageFramgnet.kt

[WordPress]

1. UnifiedCommentsEditFragment.kt

2. ScanHistoryFragment.kt

3. MediaPickerFragment.kt

4. PageParentFragment.kt

5. ReaderFragment.kt

6. ReaderPostDetailFragment.kt

7. SiteCreationBaseFormFragment.kt

8. StatsFragment.kt

9. StatsListFragment.kt

❗ Suppress options menu deprecated warnings on stats list.

PS: Maybe you as a reviewer can think of how to migrate the Options Menu on this screen. I tried a couple of things for a few minutes but couldn't figure it out. 🤔

10. InsightsManagementFragment.kt

11. InsightsDetailFragment.kt

🌟 Resolve options menu deprecated warnings on insights details.

12. StatsDetailFragment.kt

PS: @AjeshRPai I added you as the main reviewer, that is, in addition to the @wordpress-mobile/apps-infrastructure team itself, but randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid.

To test:

See the dependency tree diff result and verify correctness.
Thoroughly smoke test both, the WordPress and Jetpack apps, and see if they both work as expected.
In addition to the above smoke test, per the migration above, please expand below and follow the inner and more explicit test steps within:

[Image Editor]

1. CropFragment.kt

Add a new blog post.
Add a new image block.
Choose an image and wait for it to be uploaded within the image block.
Click on the media options of this image (top right) and then click edit.
Make sure the done menu option is shown (top right).
Crop the image and click the done menu option (top right).
Make sure the image is updated accordingly.

2. PreviewImageFragment.kt

Add a new blog post.
Add a new image block.
Choose an image and wait for it to be uploaded within the image block.
Click on the media options of this image (top right) and then click edit.
Make sure the crop menu option is shown (top right), but just for a moment. Afterwards, the
done menu option will show.
(❓) Figure out how to click the crop menu option (top right).
(❗️) Actually, this crop menu option seems to be dead code that could never trigger.

[WordPress]

1. UnifiedCommentsEditFragment.kt

Go to comments screen.
Click on a comment.
Click on more and then edit.
Make sure the done menu option is shown (top right).
Update the comment and click the done menu option (top right).
Make sure the comment is updated accordingly.

2. ScanHistoryFragment.kt

Go to scan screen.
Click on history menu option (top right).
Make sure the back navigation arrow is shown (top left).
Clink on back navigation arrow (top left).
Make sure you are navigated back to the scan screen.

3. MediaPickerFragment.kt

Go to me screen.
Click on your avatar to change photo (top middle).
Make sure the system picker menu option is shown (top right).
Click on system picker to select an image from system and navigate back.
Make sure you are navigated back to the choose photo screen.

4. PageParentFragment.kt

Go to pages screen.
Find a page, click on its menu options and select set parent.
Make sure the search menu option is shown (top right).
Click on search, search for pages, select a page and click save menu option (top right).
Make sure you are navigated back to the pages screen and a parent has been set for that page.

5. ReaderFragment.kt

Go to reader screen (middle tab).
Make sure the search menu option is shown (to right).
Click on search, search by keyword and click `search (bottom right).
Make sure you get some search results and you can navigate back to the reader screen.

6. ReaderPostDetailFragment.kt

Go to reader screen (middle tab).
Tab on a post to get to its post details screen.
Make sure the more menu option is shown (top right).
Click on more (bottom right), then click on visit site from the available options.
Make sure you get navigated to the site and you can navigate back to the post details screen.

7. SiteCreationBaseFormFragment.kt

Go to choose site screen (down arrow).
Click on + navigation option (top right).
Select create .com site.
Choose your site's topic (ie. food).
Choose your site's theme (ie. best for food).
Preview your site and click on the choose button (bottom) to navigate to the choose domain screen.
Make sure the help menu option is shown (top right).
Click on help (top right) and make sure you get navigated to the help and support screen.
Make sure that you get navigated back to the choose domain screen.

8. UnifiedCommentsEditFragment.kt + 9. StatsListFragment.kt + 10. InsightsManagementFragment.kt

Go to stats screen.
Make sure the stats screen is shown and working as expected.
Make sure there is add new stats card menu options is only shown on the insights tab (to right).
Click on add new stats card (top right) and make sure you get navigated to the add new card settings screen.
Enabled/Disable few cards and click the save menu option (top right).
Make sure that you get navigated back to the stats screen and the enabled/disabled cards are shown accordingly.

11. InsightsDetailFragment.kt (Jetpack App)

Go to stats screen.
Click view more on the views & visitors card.
Make sure the views & visitors screen is shown and working as expected.
Make sure there is no menu option on the views & visitors screen.

12. StatsDetailFragment.kt

(❓) I am not sure how to test this screen as I can't find the entry point to it.

Merge instructions

Wait for this PR to be reviewed, tested and approved.
Update PR's base deps/main-batch-androidx-core branch with latest trunk.
Update PR with latest deps/main-batch-androidx-core.
Remove [PR] Not Ready For Merge] label.
Update the PR and make sure everything is still working as expected (check for new warnings, especially Options Menu related).
Merge PR to deps/main-batch-androidx-core.

Regression Notes

Potential unintended areas of impact
- Potential breakage of screens and core functionality as androidx.fragment is a library that is being added as a transitive dependency across lots of androidx and com.google and other libraries.
- Some of the transitive dependencies added might be causing some kind of misbehaviour.
What I did to test those areas of impact (or what existing automated tests I relied on)
- See To test section above.
What automated tests I added (or what prevented me from doing so)
- N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

It is generally recommended that transitively used dependencies should be declared directly.

Release Notes: https://developer.android.com/jetpack/androidx/releases/ fragment#1.5.5 ------------------------------------------------------------------------ Note that this update adds the following 'Options Menu' specific warnings that need to be resolved in order for this project to compile again due to the 'allWarningsAsErrors' flag. Per module, the number of warnings and their corresponding classes are: - 'image-editor' module (7): - CropFragment (4) - PreviewImageFragment (3) - 'WordPress' module (24): - UnifiedCommentsEditFragment (2) - ScanHistoryFragment (2) - MediaPickerFragment (2) - PageParentFragment (3) - ReaderFragment (2) - ReaderPostDetailFragment (4) - SiteCreationBaseFormFragment (1) - StatsFragment (1) - StatsListFragment (3) - InsightsDetailFragment (1) - StatsDetailFragment (1) - InsightsManagementFragment (2) As such, all the above listed modules, classes and their warnings need to be migrated to the new 'Options Menu' APIs. All that is going to be done in subsequent commits. ------------------------------------------------------------------------ PS: In the meanwhile, the 'allWarningsAsErrors' flag is going to be disabled in order to make it possible for the project to compile so that each screen migration could be tested in isolation.

This is done in order to make it possible for the project to compile so that each screen 'Options Menu' migration could be tested in isolation.

This dependency is added in order to access the activity related 'addMenuProvider(...)' API, which is not available prior to the AndroidX Activity 1.4.0 release, see below: https://developer.android.com/jetpack/androidx/releases/activity #1.4.0-alpha01 Currently, and although the project is indeed using AndroidX Activity as a transitive dependency, those point to older versions of it. Below is a breakdown per module, and in parenthesis, the version it uses: - image-editor (1.2.4) - editor (1.1.0) - WordPress (1.3.1) FYI: The activity related 'addMenuProvider(...)' API is needed because otherwise the 'Options Menu' migration can't commence. ------------------------------------------------------------------------ Release Notes: https://developer.android.com/jetpack/androidx/releases/ activity#1.5.1 ------------------------------------------------------------------------ Note that the '1.6.1' update requires libraries and applications that depend on it to compile against version 33 (Android 13) or later of the Android APIs. However, this project is currently compiled against android-31 (Android 12). Thus, until the 'compileSdkVersion' of this project gets updated to '33' updating to '1.9.0' isn't possible. ------------------------------------------------------------------------

Warning Messages: - "'setHasOptionsMenu(Boolean): Unit' is deprecated. Deprecated in Java" - "'onCreateOptionsMenu(Menu, MenuInflater): Unit' is deprecated. Deprecated in Java" - "'onOptionsItemSelected(MenuItem): Boolean' is deprecated. Deprecated in Java" ------------------------------------------------------------------------ Adding 'requireActivity().addMenuProvider(this, viewLifecycleOwner)' and replacing the 'onCreateOptionsMenu' and 'onOptionsItemSelected' with the 'onCreateMenu' and 'onMenuItemSelected' equivalent 'MenuProvider' related interface signatures is now the recommended way forward. ------------------------------------------------------------------------ For more info see: - androidx.fragment.setHasOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #setHasOptionsMenu(boolean) - androidx.fragment.onCreateOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #onCreateOptionsMenu(android.view.Menu,android.view.MenuInflater) - androidx.fragment.onOptionsItemSelected (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #onOptionsItemSelected(android.view.MenuItem)

Warning Messages: - "'setHasOptionsMenu(Boolean): Unit' is deprecated. Deprecated in Java" - "'onOptionsItemSelected(MenuItem): Boolean' is deprecated. Deprecated in Java" ------------------------------------------------------------------------ Adding 'requireActivity().addMenuProvider(this, viewLifecycleOwner)' and replacing the 'onOptionsItemSelected' with the 'onMenuItemSelected' equivalent 'MenuProvider' related interface signatures is now the recommended way forward. Also, the empty 'MenuProvider.onCreateMenu(...)' interface implementation was added since this isn't optional. There is no default implementation for this interface function. As such, one would need to implement this interface when 'MenuProvider' is utilized. ------------------------------------------------------------------------ For more info see: - androidx.fragment.setHasOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #setHasOptionsMenu(boolean) - androidx.fragment.onOptionsItemSelected (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #onOptionsItemSelected(android.view.MenuItem)

Warning Messages: - "'setHasOptionsMenu(Boolean): Unit' is deprecated. Deprecated in Java" - "'onCreateOptionsMenu(Menu, MenuInflater): Unit' is deprecated. Deprecated in Java" ------------------------------------------------------------------------ Adding 'requireActivity().addMenuProvider(this, viewLifecycleOwner)' and replacing the 'onCreateOptionsMenu' and 'onOptionsItemSelected' with the 'onCreateMenu' and 'onMenuItemSelected' equivalent 'MenuProvider' related interface signatures is now the recommended way forward. ------------------------------------------------------------------------ For more info see: - androidx.fragment.setHasOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #setHasOptionsMenu(boolean) - androidx.fragment.onCreateOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #onCreateOptionsMenu(android.view.Menu,android.view.MenuInflater)

Warning Messages: - "'setHasOptionsMenu(Boolean): Unit' is deprecated. Deprecated in Java" - "'onCreateOptionsMenu(Menu, MenuInflater): Unit' is deprecated. Deprecated in Java" - "'onOptionsItemSelected(MenuItem): Boolean' is deprecated. Deprecated in Java" ------------------------------------------------------------------------ Adding 'requireActivity().addMenuProvider(this, viewLifecycleOwner)' and replacing the 'onCreateOptionsMenu' and 'onOptionsItemSelected' with the 'onCreateMenu' and 'onMenuItemSelected' equivalent 'MenuProvider' related interface signatures is now the recommended way forward. ------------------------------------------------------------------------ For more info see: - androidx.fragment.setHasOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #setHasOptionsMenu(boolean) - androidx.fragment.onCreateOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #onCreateOptionsMenu(android.view.Menu,android.view.MenuInflater) - androidx.fragment.onOptionsItemSelected (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #onOptionsItemSelected(android.view.MenuItem)

Warning Messages: - "'setHasOptionsMenu(Boolean): Unit' is deprecated. Deprecated in Java" - "'onCreateOptionsMenu(Menu, MenuInflater): Unit' is deprecated. Deprecated in Java" ------------------------------------------------------------------------ Adding 'requireActivity().addMenuProvider(this, viewLifecycleOwner)' and replacing the 'onCreateOptionsMenu' and 'onOptionsItemSelected' with the 'onCreateMenu' and 'onMenuItemSelected' equivalent 'MenuProvider' related interface signatures is now the recommended way forward. ------------------------------------------------------------------------ For more info see: - androidx.fragment.setHasOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #setHasOptionsMenu(boolean) - androidx.fragment.onCreateOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #onCreateOptionsMenu(android.view.Menu,android.view.MenuInflater)

Warning Messages: - "'setHasOptionsMenu(Boolean): Unit' is deprecated. ------------------------------------------------------------------------ The 'Option Menu' configuration on 'InsightsDetailFragment' is unnecessary and as such 'setHasOptionsMenu(...)' is completely removed without being migrated to the new 'Options Menu' APIs. ------------------------------------------------------------------------ For more info see: - androidx.fragment.setHasOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #setHasOptionsMenu(boolean)

Warning Messages: - "'setHasOptionsMenu(Boolean): Unit' is deprecated. ------------------------------------------------------------------------ The 'Option Menu' configuration on 'StatsDetailFragment' is unnecessary and as such 'setHasOptionsMenu(...)' is completely removed without being migrated to the new 'Options Menu' APIs. ------------------------------------------------------------------------ For more info see: - androidx.fragment.setHasOptionsMenu (Documentation): https://developer.android.com/reference/androidx/fragment/app/Fragment #setHasOptionsMenu(boolean)

Now that the 'Option Menu' migration is done and all new warnings are resolved/suppressed this flag can be re-enabled.

wpmobilebot · 2022-12-23T17:24:30Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17696-190301a.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`190301a`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2022-12-23T17:25:10Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17696-190301a.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`190301a`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

…mobile/WordPress-Android into deps/update-androidx-fragment-to-1.5.5 � Conflicts: � WordPress/src/main/java/org/wordpress/android/ui/comments/unified/UnifiedCommentsEditFragment.kt � WordPress/src/main/java/org/wordpress/android/ui/jetpack/scan/history/ScanHistoryFragment.kt � WordPress/src/main/java/org/wordpress/android/ui/mediapicker/MediaPickerFragment.kt � WordPress/src/main/java/org/wordpress/android/ui/pages/PageParentFragment.kt � WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderFragment.kt � WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostDetailFragment.kt � WordPress/src/main/java/org/wordpress/android/ui/sitecreation/SiteCreationBaseFormFragment.kt � WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/management/InsightsManagementFragment.kt

wpmobilebot · 2023-01-11T13:50:31Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:analytics
 |    \--- androidx.preference:preference:1.1.0
 |         +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1
-|         |    +--- androidx.activity:activity:1.2.4 -> 1.3.1
-|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.5.1 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.5.1
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (c)
-|         |    |    +--- androidx.savedstate:savedstate:1.1.0 -> 1.2.0
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
-|         |    |    |    +--- androidx.lifecycle:lifecycle-common:2.4.0 -> 2.5.1 (*)
-|         |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
-|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.5.1
-|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|         |    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0
-|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |    |    |    +--- androidx.core:core:1.8.0 (*)
-|         |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1
-|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
-|         |    |    |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
-|         |    |    |    |    \--- androidx.lifecycle:lifecycle-common:2.5.1 (*)
-|         |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
-|         |    |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
-|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4
-|         |    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4
-|         |    |    |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4
-|         |    |    |         |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4
-|         |    |    |         |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 (c)
-|         |    |    |         |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (c)
-|         |    |    |         |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 (c)
-|         |    |    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
-|         |    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21
-|         |    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4 (*)
-|         |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
-|         |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-|         |    |    \--- androidx.tracing:tracing:1.0.0 (*)
+|         |    +--- androidx.activity:activity:1.2.4 -> 1.5.1
+|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
+|         |    |    +--- androidx.core:core:1.8.0 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-runtime:2.5.1 (*)
+|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    |    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (c)
+|         |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1
+|         |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|         |    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0
+|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    |    |    +--- androidx.core:core:1.8.0 (*)
+|         |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1
+|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
+|         |    |    |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
+|         |    |    |    |    \--- androidx.lifecycle:lifecycle-common:2.5.1 (*)
+|         |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
+|         |    |    |    +--- androidx.savedstate:savedstate:1.2.0
+|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |    |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
+|         |    |    |    |    +--- androidx.lifecycle:lifecycle-common:2.4.0 -> 2.5.1 (*)
+|         |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
+|         |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|         |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4
+|         |    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4
+|         |    |    |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4
+|         |    |    |         |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4
+|         |    |    |         |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 (c)
+|         |    |    |         |         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (c)
+|         |    |    |         |         |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 (c)
+|         |    |    |         |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
+|         |    |    |         |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21
+|         |    |    |         +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4 (*)
+|         |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
+|         |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
+|         |    |    +--- androidx.tracing:tracing:1.0.0 (*)
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         |    \--- androidx.fragment:fragment:1.3.6 -> 1.4.1
-|         |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |         +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
-|         |         +--- androidx.collection:collection:1.1.0 (*)
-|         |         +--- androidx.viewpager:viewpager:1.0.0
-|         |         |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|         |         |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
-|         |         |    \--- androidx.customview:customview:1.0.0 -> 1.1.0
-|         |         |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |         |         +--- androidx.core:core:1.3.0 -> 1.8.0 (*)
-|         |         |         \--- androidx.collection:collection:1.1.0 (*)
-|         |         +--- androidx.loader:loader:1.0.0
-|         |         |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|         |         |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
-|         |         |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.5.1
-|         |         |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
-|         |         |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
-|         |         |    |    \--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
-|         |         |    \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.5.1 (*)
-|         |         +--- androidx.activity:activity:1.2.4 -> 1.3.1 (*)
-|         |         +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1 -> 2.5.1 (*)
-|         |         +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.5.1 (*)
-|         |         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.5.1 (*)
-|         |         +--- androidx.savedstate:savedstate:1.1.0 -> 1.2.0 (*)
-|         |         +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.1.0
-|         |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.21 (*)
+|         |    \--- androidx.fragment:fragment:1.3.6 -> 1.5.5
+|         |         +--- androidx.activity:activity:1.5.1 (*)
+|         |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |         +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.1.0
+|         |         +--- androidx.collection:collection:1.1.0 (*)
+|         |         +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
+|         |         +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
+|         |         +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
+|         |         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (*)
+|         |         +--- androidx.loader:loader:1.0.0
+|         |         |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|         |         |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+|         |         |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.5.1
+|         |         |    |    +--- androidx.arch.core:core-common:2.1.0 (*)
+|         |         |    |    +--- androidx.arch.core:core-runtime:2.1.0 (*)
+|         |         |    |    \--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
+|         |         |    \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.5.1 (*)
+|         |         +--- androidx.savedstate:savedstate:1.2.0 (*)
+|         |         +--- androidx.viewpager:viewpager:1.0.0
+|         |         |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|         |         |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+|         |         |    \--- androidx.customview:customview:1.0.0 -> 1.1.0
+|         |         |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |         |         +--- androidx.core:core:1.3.0 -> 1.8.0 (*)
+|         |         |         \--- androidx.collection:collection:1.1.0 (*)
+|         |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|         \--- androidx.fragment:fragment:1.1.0 -> 1.4.1 (*)
+|         \--- androidx.fragment:fragment:1.1.0 -> 1.5.5 (*)
 +--- project :libs:image-editor
+|    +--- androidx.activity:activity:1.5.1 (*)
+|    +--- androidx.activity:activity-ktx:1.5.1
+|    |    +--- androidx.activity:activity:1.5.1 (*)
+|    |    +--- androidx.core:core-ktx:1.1.0 -> 1.8.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+|    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.5.1 (*)
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4 (*)
+|    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4 (*)
+|    |    +--- androidx.savedstate:savedstate-ktx:1.2.0
+|    |    |    +--- androidx.savedstate:savedstate:1.2.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|    +--- androidx.fragment:fragment:1.5.5 (*)
 |    +--- androidx.viewpager2:viewpager2:1.0.0
-|    |    \--- androidx.fragment:fragment:1.1.0 -> 1.4.1 (*)
+|    |    \--- androidx.fragment:fragment:1.1.0 -> 1.5.5 (*)
 |    +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01
-|    |    \--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+|    |    \--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
 |    +--- androidx.navigation:navigation-fragment:2.4.2
-|    |    +--- androidx.fragment:fragment-ktx:1.4.1
-|    |    |    +--- androidx.fragment:fragment:1.4.1 (*)
-|    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1
-|    |    |    |    +--- androidx.activity:activity:1.3.1 (*)
-|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.8.0 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.5.1
-|    |    |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.5.1 (*)
-|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|    |    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.5.1
-|    |    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
-|    |    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|    |    |    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4 (*)
-|    |    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0
-|    |    |    |    |    +--- androidx.savedstate:savedstate:1.1.0 -> 1.2.0 (*)
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.21 (*)
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.6.21 (*)
-|    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
-|    |    |    +--- androidx.collection:collection-ktx:1.1.0
-|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.21 (*)
-|    |    |    |    \--- androidx.collection:collection:1.1.0 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.3.1 -> 2.5.1
-|    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.5.1 (*)
-|    |    |    +--- androidx.savedstate:savedstate-ktx:1.1.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.21 (*)
+|    |    +--- androidx.fragment:fragment-ktx:1.4.1 -> 1.5.5
+|    |    |    +--- androidx.activity:activity-ktx:1.5.1 (*)
+|    |    |    +--- androidx.collection:collection-ktx:1.1.0
+|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.21 (*)
+|    |    |    |    \--- androidx.collection:collection:1.1.0 (*)
+|    |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
+|    |    |    +--- androidx.fragment:fragment:1.5.5 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.5.1
+|    |    |    |    +--- androidx.lifecycle:lifecycle-livedata-core:2.5.1 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 (*)
+|    |    |    +--- androidx.savedstate:savedstate-ktx:1.2.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
 |    |    \--- androidx.navigation:navigation-runtime:2.4.2
-|    |         \--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1 (*)
+|    |         \--- androidx.activity:activity-ktx:1.2.3 -> 1.5.1 (*)
 +--- project :libs:editor
 |    +--- org.wordpress:aztec:{strictly v1.6.2} -> v1.6.2
 |    |    \--- androidx.legacy:legacy-support-v4:1.0.0
-|    |         \--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+|    |         \--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
 |    \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.87.0
 |         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
-|         |    \--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
+|         |    \--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
 |         \--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
 |              \--- com.github.bumptech.glide:glide:4.12.0
-|                   \--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+|                   \--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+|    \--- androidx.fragment:fragment:1.5.5 (*)
 +--- org.wordpress:login:1.0.0
 |    +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.3.0
-|    |    +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+|    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
 |    |    \--- com.google.android.gms:play-services-auth-api-phone:18.0.1
 |    |         \--- com.google.android.gms:play-services-base:18.0.1
-|    |              +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+|    |              +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
 |    |              \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0
-|    |                   \--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+|    |                   \--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
 |    \--- com.google.dagger:dagger-android-support:2.42
-|         +--- androidx.activity:activity:1.3.1 (*)
+|         +--- androidx.activity:activity:1.3.1 -> 1.5.1 (*)
-|         \--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
+|         \--- androidx.fragment:fragment:1.3.6 -> 1.5.5 (*)
 +--- com.automattic:about:1.0.0
 |    \--- androidx.compose.ui:ui-tooling:1.0.5
 |         \--- androidx.activity:activity-compose:1.3.1
-|              \--- androidx.activity:activity-ktx:1.3.1 (*)
+|              \--- androidx.activity:activity-ktx:1.3.1 -> 1.5.1 (*)
++--- androidx.activity:activity:1.5.1 (*)
++--- androidx.activity:activity-ktx:1.5.1 (*)
-+--- androidx.fragment:fragment:1.4.1 (*)
++--- androidx.fragment:fragment:1.5.5 (*)
-+--- androidx.fragment:fragment-ktx:1.4.1 (*)
++--- androidx.fragment:fragment-ktx:1.5.5 (*)
 +--- com.google.android.gms:play-services-code-scanner:16.0.0-beta1
-|    \--- androidx.activity:activity:1.3.1 (*)
+|    \--- androidx.activity:activity:1.3.1 -> 1.5.1 (*)
 +--- com.zendesk:support:5.0.2
 |    \--- com.zendesk:guide:1.0.1
 |         \--- com.zendesk:messaging:5.1.0
 |              \--- com.zendesk:common-ui:4.0.1
 |                   \--- com.zendesk.belvedere2:belvedere:3.0.0-RC
 |                        +--- com.zendesk.belvedere2:belvedere-core:3.0.0-RC
-|                        |    \--- androidx.fragment:fragment:1.2.5 -> 1.4.1 (*)
+|                        |    \--- androidx.fragment:fragment:1.2.5 -> 1.5.5 (*)
-|                        \--- androidx.fragment:fragment:1.2.5 -> 1.4.1 (*)
+|                        \--- androidx.fragment:fragment:1.2.5 -> 1.5.5 (*)
 +--- com.google.dagger:hilt-android:2.42
-|    +--- androidx.activity:activity:1.3.1 (*)
+|    +--- androidx.activity:activity:1.3.1 -> 1.5.1 (*)
-|    \--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
+|    \--- androidx.fragment:fragment:1.3.6 -> 1.5.5 (*)

Please review and act accordingly

AjeshRPai

Hey @petros, Everything works as expected. Thanks for working on this PR. You are awesome.

I am approving but not merging the PR so you can look at my comments. To make it convenient, I am sharing it in a nutshell.

I couldnt find a way to test the PreviewImageFragment
StatsDetailFragment is launched when you want to look at the stats of a Post

[Image Editor]

1. CropFragment.kt 🟢
1. PreviewImageFragment.kt - I couldnt figure out a way to click at the crop menu, it seems to be displayed for a few seconds and then its replaced with the done tick. I tried to make the crop menu item visible by hardcoding, but it seems like the PreviewImageFragment redirects to Crop fragment as soon as the file is loaded. As you said, the crop menu option seems to be dead code that could never trigger.

[WordPress]

1. UnifiedCommentsEditFragment.kt 🟢
1. ScanHistoryFragment.kt 🟢
1. MediaPickerFragment.kt Works as Described 🟢
1. PageParentFragment.kt 🟢
1. ReaderFragment.kt 🟢
1. ReaderPostDetailFragment.kt 🟢
1. SiteCreationBaseFormFragment.kt
1. UnifiedCommentsEditFragment.kt + 9. StatsListFragment.kt + 10. InsightsManagementFragment.kt :🟢
1. InsightsDetailFragment.kt (Jetpack App) 🟢
1. StatsDetailFragment.kt 🟢
- Go to posts
- Click on more button(three dot button)
- Click at stats
- Make sure that the stats are shown correctly
- Click on back button

ParaskP7 · 2023-01-12T11:46:22Z

You are the best of the best of the best @AjeshRPai , truly! 💯

Thank you so much for testing, for all your notes and for helping me figure out how to test both PreviewImageFragment and StatsDetailFragment, you rock! 🙇 ❤️ 🚀

I couldnt find a way to test the PreviewImageFragment
...
PreviewImageFragment.kt - I couldnt figure out a way to click at the crop menu, it seems to be displayed for a few seconds and then its replaced with the done tick. I tried to make the crop menu item visible by hardcoding, but it seems like the PreviewImageFragment redirects to Crop fragment as soon as the file is loaded. As you said, the crop menu option seems to be dead code that could never trigger.

Yeap, at least we are on the same page, that's enough for now, thank you! 🥇

StatsDetailFragment is launched when you want to look at the stats of a Post
...
StatsDetailFragment.kt 🟢

Go to posts

Click on more button(three dot button)

Click at stats

Make sure that the stats are shown correctly

Click on back button

Thank you so much for this tip, I testing it myself as well and everything is indeed working as expected! 🥇

peril-wordpress-mobile · 2023-01-12T13:42:42Z

	Warnings
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

ParaskP7 added 30 commits December 23, 2022 13:26

Deps: Add fragment transitively used dependencies on image editor

0cf7c0b

It is generally recommended that transitively used dependencies should be declared directly.

Deps: Add fragment transitively used dependencies on editor

0914722

It is generally recommended that transitively used dependencies should be declared directly.

Build: Disable all warnings as errors kotlin compile options flag

ed27a93

This is done in order to make it possible for the project to compile so that each screen 'Options Menu' migration could be tested in isolation.

Refactor: Remove redundant sam constructor from crop fragment

9fcfe74

Analysis: Match menu provider implementation signatures on crop fragment

ad30662

Refactor: Replace if with when on menu time selected for crop fragment

67c6f0e

Refactor: Optimize view pager 2 imports on preview image

c2cde23

Refactor: Move lambda argument out of parenthesis on preview image

c5e7129

Analysis: Match menu provider implementation signatures on preview image

3d06435

Refactor: Replace if with when on menu time selected for preview image

cf36d82

Refactor: Move lambda argument out of parenthesis on unified comments

f5cfc9d

Analysis: Match menu provider implementation signatures on uni. comments

818f5a0

Refactor: Refactor when on menu time selected for unified comments

24e2c82

Analysis: Resolve empty function block warnings for scan history

adf875c

Refactor: Move lambda argument out of parenthesis on scan history

ec6621e

Analysis: Match menu provider implementation signatures on scan history

c6e864f

Refactor: Replace if with when on menu time selected for scan history

e2fe148

Refactor: Remove redundant sam constructor from media picker

5d6d893

Analysis: Match menu provider implementation signatures on media picker

a770cf3

Refactor: Refactor when on menu time selected for media picker

cd769fd

Analysis: Resolve magic number warnings for page parent

6da9e62

Refactor: Remove redundant sam constructor from page parent

1efeb01

ParaskP7 added 9 commits December 23, 2022 18:15

Refactor: Remove redundant sam constructor from insights mgmt

fa98dc6

Analysis: Match menu provider implementation signatures on insights mgmt

44c0cb6

Refactor: Move create menu close to menu item selected on insights mgmt

a99b1b5

Refactor: Refactor when on menu time selected for insights mgmt

adbbf39

Refactor: Remove redundant sam constructor from stats detail

42ea804

Build: Enable all warnings as errors kotlin compile options flag

d8994c3

Now that the 'Option Menu' migration is done and all new warnings are resolved/suppressed this flag can be re-enabled.

ParaskP7 added Tech Debt dependency update labels Dec 23, 2022

ParaskP7 added this to the Future milestone Dec 23, 2022

ParaskP7 requested review from a team and AjeshRPai December 23, 2022 17:06

ParaskP7 self-assigned this Dec 23, 2022

ParaskP7 mentioned this pull request Dec 23, 2022

Dependency Updates - Main Batch - AndroidX Core #17561

Closed

6 tasks

ParaskP7 added the [Status] Not Ready for Merge label Dec 23, 2022

ParaskP7 mentioned this pull request Jan 11, 2023

[Dependency Updates] Main Batch - AndroidX Core #17741

Merged

14 tasks

ParaskP7 mentioned this pull request Jan 11, 2023

[Dependency Updates] Update androidxAppcompatVersion to 1.4.2 #17743

Merged

11 tasks

AjeshRPai approved these changes Jan 12, 2023

View reviewed changes

ParaskP7 merged commit 35c0edd into deps/main-batch-androidx-core Jan 12, 2023

ParaskP7 deleted the deps/update-androidx-fragment-to-1.5.5 branch January 12, 2023 11:47

ParaskP7 removed the [Status] Not Ready for Merge label Jan 12, 2023

ParaskP7 mentioned this pull request Feb 7, 2023

Bump androidxActivityVersion from 1.5.1 to 1.6.1 #17895

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency Updates] Update `androidxFragmentVersion` to 1.5.5#17696

[Dependency Updates] Update `androidxFragmentVersion` to 1.5.5#17696
ParaskP7 merged 68 commits intodeps/main-batch-androidx-corefrom
deps/update-androidx-fragment-to-1.5.5

ParaskP7 commented Dec 23, 2022 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 23, 2022 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 23, 2022 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 11, 2023

Uh oh!

AjeshRPai left a comment

Uh oh!

ParaskP7 commented Jan 12, 2023

Uh oh!

peril-wordpress-mobile bot commented Jan 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ParaskP7 commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge instructions

Regression Notes

Uh oh!

wpmobilebot commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jan 11, 2023

The PR caused the following dependency changes:

Uh oh!

AjeshRPai left a comment

Choose a reason for hiding this comment

Uh oh!

ParaskP7 commented Jan 12, 2023

Uh oh!

peril-wordpress-mobile bot commented Jan 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ParaskP7 commented Dec 23, 2022 •

edited

Loading

wpmobilebot commented Dec 23, 2022 •

edited

Loading

wpmobilebot commented Dec 23, 2022 •

edited

Loading