[Dependency Updates] Update `androidxCoreVersion` to 1.8.0 by ParaskP7 · Pull Request #17691 · wordpress-mobile/WordPress-Android

ParaskP7 · 2022-12-21T15:35:00Z

Parent #17561
Batch Branch: deps/main-batch-androidx-core

This PR updates androidxCoreVersion to 1.8.0. FYI: This is NOT the latest version of androidx.core.

Also, as part of this update the below transitive dependencies were added:

On the Editor module (37c5275):
- androidx.core:core

Note that the latest 1.9.0 update requires libraries and applications that depend on it to compile against version 33 (Android 13) or later of the Android APIs. However, this project is currently compiled against android-31 (Android 12).

Thus, until the compileSdkVersion of this project gets updated to 33, updating to 1.9.0 isn't possible.

More details

* What went wrong:
Execution failed for task ':WordPress:checkWordpressWasabiDebugAarMetadata'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
 > 3 issues were found when checking AAR metadata:

     1.  Dependency 'androidx.core:core-ktx:1.9.0' requires libraries and applications that
         depend on it to compile against version 33 or later of the
         Android APIs.

         :WordPress is currently compiled against android-31.

         Also, the maximum recommended compile SDK version for Android Gradle
         plugin 7.2.1 is 32.

         Recommended action: Update this project's version of the Android Gradle
         plugin to one that supports 33, then update this project to use
         compileSdkVerion of at least 33.

         Note that updating a library or application's compileSdkVersion (which
         allows newer APIs to be used) can be done separately from updating
         targetSdkVersion (which opts the app in to new runtime behavior) and
         minSdkVersion (which determines which devices the app can be installed
         on).

     2.  Dependency 'androidx.core:core:1.9.0' requires libraries and applications that
         depend on it to compile against version 33 or later of the
         Android APIs.

         :WordPress is currently compiled against android-31.

         Also, the maximum recommended compile SDK version for Android Gradle
         plugin 7.2.1 is 32.

         Recommended action: Update this project's version of the Android Gradle
         plugin to one that supports 33, then update this project to use
         compileSdkVerion of at least 33.

         Note that updating a library or application's compileSdkVersion (which
         allows newer APIs to be used) can be done separately from updating
         targetSdkVersion (which opts the app in to new runtime behavior) and
         minSdkVersion (which determines which devices the app can be installed
         on).

     3.  Dependency 'androidx.annotation:annotation-experimental:1.3.0' requires libraries and applications that
         depend on it to compile against version 33 or later of the
         Android APIs.

         :WordPress is currently compiled against android-31.

         Also, the maximum recommended compile SDK version for Android Gradle
         plugin 7.2.1 is 32.

         Recommended action: Update this project's version of the Android Gradle
         plugin to one that supports 33, then update this project to use
         compileSdkVerion of at least 33.

         Note that updating a library or application's compileSdkVersion (which
         allows newer APIs to be used) can be done separately from updating
         targetSdkVersion (which opts the app in to new runtime behavior) and
         minSdkVersion (which determines which devices the app can be installed
         on).

In addition to the dependency update commits, a couple of additional fix related commits were added to fix a couple of API update on the androidx.core library itself, see below:

PS: @irfano I added you as the main reviewer, that is, in addition to the @wordpress-mobile/apps-infrastructure team itself, but randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid.

To test:

See the dependency tree diff result and verify correctness.
Thoroughly smoke test both, the WordPress and Jetpack apps, and see if they both work as expected.

Merge instructions

Wait for [Dependency Updates] Update androidxLifecycleVersion to 2.5.1 #17643 PR to be approved and merged to deps/main-batch-androidx-core.
Make sure this PR's base is automatically updated to deps/main-batch-androidx-core.
Update PR's base deps/main-batch-androidx-core branch with latest trunk.
Update PR with latest deps/main-batch-androidx-core.
Remove [PR] Not Ready For Merge] label.
Prepare and update PR to a Ready for review state.
Assign a reviewer.
Merge PR to deps/main-batch-androidx-core.

Regression Notes

Potential unintended areas of impact
- Potential breakage of screens and core functionality as androidx.core is a library that is being added as a transitive dependency across lots of androidx and com.google and other libraries.
- Some of the transitive dependencies added might be causing some kind of misbehaviour.
What I did to test those areas of impact (or what existing automated tests I relied on)
- See To test section above.
What automated tests I added (or what prevented me from doing so)
- N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

It is generally recommended that transitively used dependencies should be declared directly.

Release Notes: https://developer.android.com/jetpack/androidx/releases/ core#1.8.0 ------------------------------------------------------------------------ Note that the '1.9.0' update requires libraries and applications that depend on it to compile against version 33 (Android 13) or later of the Android APIs. However, this project is currently compiled against android-31 (Android 12). Thus, until the 'compileSdkVersion' of this project gets updated to '33' updating to '1.9.0' isn't possible. ------------------------------------------------------------------------

The 'get(...)' method on 'LocaleListCompat' now returns a nullable locale and such the 'Context.currentLocale' extension function needs to be adjusted accordingly.

Both, the 'onPopulateAccessibilityEvent(...)' and 'onInitializeAccessibilityNodeInfo(...)' functions on 'AccessibilityDelegateCompat' are no longer having nullable 'host', 'event' or 'info' parameters, instead there are now all non-null. As such, the 'ContentDescriptionListAnnouncer.setupAnnouncer(...)' function needs to be updated accordingly.

wpmobilebot · 2022-12-21T15:42:35Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:analytics
 |    +--- com.automattic:Automattic-Tracks-Android:2.2.0
 |    |    \--- io.sentry:sentry-android -> 5.4.3
 |    |         \--- io.sentry:sentry-android-core:5.4.3
-|    |              \--- androidx.core:core:1.3.2 -> 1.7.0
-|    |                   +--- androidx.annotation:annotation:1.2.0
-|    |                   +--- androidx.annotation:annotation-experimental:1.1.0
-|    |                   +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.5.1 (*)
-|    |                   +--- androidx.versionedparcelable:versionedparcelable:1.1.1
-|    |                   |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|    |                   |    \--- androidx.collection:collection:1.0.0 -> 1.1.0
-|    |                   |         \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|    |                   +--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
-|    |                   \--- androidx.concurrent:concurrent-futures:1.0.0
-|    |                        +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
-|    |                        \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|    |              \--- androidx.core:core:1.3.2 -> 1.8.0
+|    |                   +--- androidx.annotation:annotation:1.2.0
+|    |                   +--- androidx.annotation:annotation-experimental:1.1.0
+|    |                   +--- androidx.collection:collection:1.0.0 -> 1.1.0
+|    |                   |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|    |                   +--- androidx.concurrent:concurrent-futures:1.0.0
+|    |                   |    +--- com.google.guava:listenablefuture:1.0 -> 9999.0-empty-to-avoid-conflict-with-guava
+|    |                   |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|    |                   +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.5.1 (*)
+|    |                   \--- androidx.versionedparcelable:versionedparcelable:1.1.1
+|    |                        +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|    |                        \--- androidx.collection:collection:1.0.0 -> 1.1.0 (*)
 |    \--- androidx.preference:preference:1.1.0
 |         +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1
-|         |    +--- androidx.core:core:1.5.0 -> 1.7.0 (*)
+|         |    +--- androidx.core:core:1.5.0 -> 1.8.0 (*)
 |         |    +--- androidx.activity:activity:1.2.4 -> 1.3.1
-|         |    |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|         |    |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |         |    |    \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.5.1
-|         |    |         \--- androidx.core:core-ktx:1.2.0 -> 1.7.0
-|         |    |              +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.21 (*)
-|         |    |              +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-|         |    |              \--- androidx.core:core:1.7.0 (*)
+|         |    |         \--- androidx.core:core-ktx:1.2.0 -> 1.8.0
+|         |    |              +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+|         |    |              +--- androidx.core:core:1.8.0 (*)
+|         |    |              \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
 |         |    +--- androidx.fragment:fragment:1.3.6 -> 1.4.1
-|         |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
+|         |    |    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
 |         |    |    +--- androidx.viewpager:viewpager:1.0.0
-|         |    |    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|         |    |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |         |    |    |    \--- androidx.customview:customview:1.0.0 -> 1.1.0
-|         |    |    |         \--- androidx.core:core:1.3.0 -> 1.7.0 (*)
+|         |    |    |         \--- androidx.core:core:1.3.0 -> 1.8.0 (*)
 |         |    |    \--- androidx.loader:loader:1.0.0
-|         |    |         \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|         |    |         \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |         |    +--- androidx.appcompat:appcompat-resources:1.3.1
-|         |    |    +--- androidx.core:core:1.0.1 -> 1.7.0 (*)
+|         |    |    +--- androidx.core:core:1.0.1 -> 1.8.0 (*)
 |         |    |    \--- androidx.vectordrawable:vectordrawable:1.1.0
-|         |    |         \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|         |    |         \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |         |    \--- androidx.drawerlayout:drawerlayout:1.0.0 -> 1.1.1
-|         |         \--- androidx.core:core:1.2.0 -> 1.7.0 (*)
+|         |         \--- androidx.core:core:1.2.0 -> 1.8.0 (*)
-|         +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|         +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |         \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.1.0
-|              \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|              \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 +--- project :libs:image-editor
 |    +--- androidx.constraintlayout:constraintlayout:1.1.3 -> 2.0.4
-|    |    \--- androidx.core:core:1.3.1 -> 1.7.0 (*)
+|    |    \--- androidx.core:core:1.3.1 -> 1.8.0 (*)
 |    +--- androidx.viewpager2:viewpager2:1.0.0
-|    |    \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|    |    \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |    +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01
 |    |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0
-|    |    |    \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|    |    |    \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-|    |    +--- androidx.core:core:1.5.0 -> 1.7.0 (*)
+|    |    +--- androidx.core:core:1.5.0 -> 1.8.0 (*)
 |    |    +--- androidx.dynamicanimation:dynamicanimation:1.0.0
-|    |    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |    |    |    \--- androidx.legacy:legacy-support-core-utils:1.0.0
-|    |    |         \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    |    |         \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |    |    \--- androidx.transition:transition:1.2.0 -> 1.4.1
-|    |         \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|    |         \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |    \--- androidx.navigation:navigation-fragment:2.4.2
 |         +--- androidx.fragment:fragment-ktx:1.4.1
 |         |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1
-|         |    |    \--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
+|         |    |    \--- androidx.core:core-ktx:1.1.0 -> 1.8.0 (*)
-|         |    \--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
+|         |    \--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
 |         +--- androidx.navigation:navigation-runtime:2.4.2
 |         |    \--- androidx.navigation:navigation-common:2.4.2
-|         |         \--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
+|         |         \--- androidx.core:core-ktx:1.1.0 -> 1.8.0 (*)
 |         \--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
-|              +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|              +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |              \--- androidx.window:window:1.0.0
-|                   \--- androidx.core:core:1.3.2 -> 1.7.0 (*)
+|                   \--- androidx.core:core:1.3.2 -> 1.8.0 (*)
 +--- project :libs:editor
 |    +--- org.wordpress:aztec:{strictly v1.6.2} -> v1.6.2
 |    |    \--- androidx.legacy:legacy-support-v4:1.0.0
-|    |         +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    |         +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |    |         +--- androidx.media:media:1.0.0 -> 1.2.1
-|    |         |    \--- androidx.core:core:1.3.0 -> 1.7.0 (*)
+|    |         |    \--- androidx.core:core:1.3.0 -> 1.8.0 (*)
 |    |         \--- androidx.legacy:legacy-support-core-ui:1.0.0
-|    |              +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    |              +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |    |              +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0
-|    |              |    \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|    |              |    \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |    |              \--- androidx.asynclayoutinflater:asynclayoutinflater:1.0.0
-|    |                   \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    |                   \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |    \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.86.0
 |         +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
-|         |    \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|         |    \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |         +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-|         |    \--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
+|         |    \--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
 |         \--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.86.0
 |              \--- androidx.gridlayout:gridlayout:1.0.0
-|                   \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|                   \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+|    \--- androidx.core:core:1.8.0 (*)
 +--- org.wordpress:utils:{strictly 3.1.0} -> 3.1.0
-|    \--- androidx.core:core-ktx:1.5.0 -> 1.7.0 (*)
+|    \--- androidx.core:core-ktx:1.5.0 -> 1.8.0 (*)
 +--- org.wordpress:login:1.0.0
 |    +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.3.0
 |    |    \--- com.google.android.gms:play-services-auth-api-phone:18.0.1
 |    |         \--- com.google.android.gms:play-services-base:18.0.1
-|    |              +--- androidx.core:core:1.2.0 -> 1.7.0 (*)
+|    |              +--- androidx.core:core:1.2.0 -> 1.8.0 (*)
 |    |              \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0
-|    |                   \--- androidx.core:core:1.2.0 -> 1.7.0 (*)
+|    |                   \--- androidx.core:core:1.2.0 -> 1.8.0 (*)
-|    \--- androidx.core:core-ktx:1.3.2 -> 1.7.0 (*)
+|    \--- androidx.core:core-ktx:1.3.2 -> 1.8.0 (*)
 +--- com.automattic:about:1.0.0
-|    +--- androidx.core:core-ktx:1.7.0 (*)
+|    +--- androidx.core:core-ktx:1.7.0 -> 1.8.0 (*)
 |    +--- androidx.compose.ui:ui:1.0.5 -> 1.1.1
 |    |    +--- androidx.compose.ui:ui-text:1.1.1
-|    |    |    \--- androidx.core:core:1.5.0 -> 1.7.0 (*)
+|    |    |    \--- androidx.core:core:1.5.0 -> 1.8.0 (*)
 |    |    \--- androidx.autofill:autofill:1.0.0
-|    |         \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|    |         \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |    \--- com.google.android.material:compose-theme-adapter:1.1.1
-|         \--- androidx.core:core-ktx:1.3.1 -> 1.7.0 (*)
+|         \--- androidx.core:core-ktx:1.3.1 -> 1.8.0 (*)
 +--- com.automattic:stories:2.0.0
-|    +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
+|    +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
 |    +--- androidx.emoji:emoji:1.0.0
-|    |    \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    |    \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |    \--- com.automattic.stories:photoeditor:2.0.0
-|         +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
+|         +--- androidx.core:core-ktx:1.2.0 -> 1.8.0 (*)
 |         +--- androidx.camera:camera-core:1.0.0-alpha06
-|         |    \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|         |    \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 |         \--- androidx.camera:camera-camera2:1.0.0-alpha06
-|              \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|              \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-+--- androidx.core:core:1.3.2 -> 1.7.0 (*)
++--- androidx.core:core:1.8.0 (*)
-+--- androidx.core:core-ktx:1.3.2 -> 1.7.0 (*)
++--- androidx.core:core-ktx:1.8.0 (*)
 +--- androidx.percentlayout:percentlayout:1.0.0
-|    \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 +--- androidx.work:work-runtime:2.7.0
-|    +--- androidx.core:core:1.6.0 -> 1.7.0 (*)
+|    +--- androidx.core:core:1.6.0 -> 1.8.0 (*)
-|    \--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+|    \--- androidx.core:core:1.1.0 -> 1.8.0 (*)
 +--- androidx.work:work-gcm:2.7.0
 |    \--- com.google.android.gms:play-services-gcm:17.0.0
-|         +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|         +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |         \--- com.google.android.gms:play-services-iid:17.0.0
-|              \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|              \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 +--- com.google.firebase:firebase-messaging:21.1.0
-|    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 |    \--- com.google.firebase:firebase-iid:21.1.0
-|         \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|         \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 +--- com.google.android.gms:play-services-code-scanner:16.0.0-beta1
 |    \--- com.google.mlkit:barcode-scanning-common:17.0.0
 |         \--- com.google.mlkit:vision-common:17.0.0
 |              \--- com.google.mlkit:common:18.0.0 -> 18.3.0
-|                   \--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|                   \--- androidx.core:core:1.0.0 -> 1.8.0 (*)
 +--- io.coil-kt:coil-compose:1.4.0
 |    +--- io.coil-kt:coil:1.4.0
 |    |    \--- io.coil-kt:coil-base:1.4.0
-|    |         \--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
+|    |         \--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
 |    +--- io.coil-kt:coil-compose-base:1.4.0
-|    |    \--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
+|    |    \--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
-|    \--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
+|    \--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
 \--- com.zendesk:support:5.0.2
      \--- com.zendesk:guide:1.0.1
           \--- com.zendesk:messaging:5.1.0
                \--- com.zendesk:common-ui:4.0.1
                     \--- com.zendesk.belvedere2:belvedere:3.0.0-RC
                          +--- com.zendesk.belvedere2:belvedere-core:3.0.0-RC
-                         |    \--- androidx.core:core:1.3.1 -> 1.7.0 (*)
+                         |    \--- androidx.core:core:1.3.1 -> 1.8.0 (*)
-                         \--- androidx.core:core:1.3.1 -> 1.7.0 (*)
+                         \--- androidx.core:core:1.3.1 -> 1.8.0 (*)

Please review and act accordingly

wpmobilebot · 2022-12-21T15:52:42Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17691-10bb29e.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`10bb29e`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2022-12-21T15:53:56Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17691-10bb29e.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`10bb29e`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

…mobile/WordPress-Android into deps/update-androidx-core-to-1.8.0

irfano

Both apps passed my smoke tests for basic features. This library was really old. Thank you for updating it. 👍🏻

ParaskP7 · 2022-12-23T12:56:41Z

Thank you for reviewing, testing and merging this PR @irfano , you are a rockstar! 🪨 🌟 💯

ParaskP7 · 2023-03-09T10:30:25Z

Note that the latest 1.9.0 update requires libraries and applications that depend on it to compile against version 33 (Android 13) or later of the Android APIs. However, this project is currently compiled against android-31 (Android 12).

FYI: 1.9.0 is going to be update when the below will be merge to trunk:

Parent PR: Parent PR for updating compileSdk 33 #17947
Parcel Update: Update deprecated Parcel functions #18068
Specific Commit: ff3699a

Thanks @irfano ! 🙇 ❤️ 🚀

UPDATE: We decided to revert the 1.9.0 update after all and add tmp compatibility functions for Parcel instead. This was due to this were it was noticed that this update 1.9.0 were causing unwanted Kotlin related transitive updates (from 1.6.21 to 1.7.10).

ParaskP7 added 4 commits December 21, 2022 15:33

Deps: Add androidx core transitively used dependencies on editor

37c5275

It is generally recommended that transitively used dependencies should be declared directly.

Fix: Fall back to default locale context extensions current locale

e4f6589

The 'get(...)' method on 'LocaleListCompat' now returns a nullable locale and such the 'Context.currentLocale' extension function needs to be adjusted accordingly.

ParaskP7 added Tech Debt dependency update labels Dec 21, 2022

ParaskP7 added this to the Future milestone Dec 21, 2022

ParaskP7 self-assigned this Dec 21, 2022

ParaskP7 mentioned this pull request Dec 22, 2022

Dependency Updates - Main Batch - AndroidX Core #17561

Closed

6 tasks

Base automatically changed from deps/update-androidx-lifecycle-to-2.5.1 to deps/main-batch-androidx-core December 23, 2022 09:35

ParaskP7 added 2 commits December 23, 2022 13:10

Merge branch 'deps/main-batch-androidx-core' of github.com:wordpress-…

5c425d6

…mobile/WordPress-Android into deps/update-androidx-core-to-1.8.0

Merge branch 'deps/main-batch-androidx-core' of github.com:wordpress-…

10bb29e

…mobile/WordPress-Android into deps/update-androidx-core-to-1.8.0

ParaskP7 requested review from a team and irfano December 23, 2022 11:37

ParaskP7 marked this pull request as ready for review December 23, 2022 11:38

irfano approved these changes Dec 23, 2022

View reviewed changes

irfano merged commit ca54cd5 into deps/main-batch-androidx-core Dec 23, 2022

irfano deleted the deps/update-androidx-core-to-1.8.0 branch December 23, 2022 12:55

ParaskP7 mentioned this pull request Dec 23, 2022

[Dependency Updates] Update androidxFragmentVersion to 1.5.5 #17696

Merged

9 tasks

This was referenced Jan 11, 2023

[Dependency Updates] Main Batch - AndroidX Core #17741

Merged

[Dependency Updates] Update androidxAppcompatVersion to 1.4.2 #17743

Merged

Bump androidxCoreVersion from 1.3.2 to 1.9.0 #17753

Closed

ParaskP7 mentioned this pull request Mar 9, 2023

Update deprecated Parcel functions #18068

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dependency Updates] Update `androidxCoreVersion` to 1.8.0#17691

[Dependency Updates] Update `androidxCoreVersion` to 1.8.0#17691
irfano merged 6 commits intodeps/main-batch-androidx-corefrom
deps/update-androidx-core-to-1.8.0

ParaskP7 commented Dec 21, 2022 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 21, 2022

Uh oh!

wpmobilebot commented Dec 21, 2022 •

edited

Loading

Uh oh!

wpmobilebot commented Dec 21, 2022 •

edited

Loading

Uh oh!

irfano left a comment

Uh oh!

ParaskP7 commented Dec 23, 2022

Uh oh!

ParaskP7 commented Mar 9, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ParaskP7 commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge instructions

Regression Notes

Uh oh!

wpmobilebot commented Dec 21, 2022

The PR caused the following dependency changes:

Uh oh!

wpmobilebot commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

irfano left a comment

Choose a reason for hiding this comment

Uh oh!

ParaskP7 commented Dec 23, 2022

Uh oh!

ParaskP7 commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ParaskP7 commented Dec 21, 2022 •

edited

Loading

wpmobilebot commented Dec 21, 2022 •

edited

Loading

wpmobilebot commented Dec 21, 2022 •

edited

Loading

ParaskP7 commented Mar 9, 2023 •

edited

Loading