Skip to content

Update squareupMockWebServerVersion to 4.9.3#17663

Merged
oguzkocer merged 1 commit intotrunkfrom
dep-updates/squareupMockWebServerVersion
Dec 13, 2022
Merged

Update squareupMockWebServerVersion to 4.9.3#17663
oguzkocer merged 1 commit intotrunkfrom
dep-updates/squareupMockWebServerVersion

Conversation

@oguzkocer
Copy link
Copy Markdown
Contributor

@oguzkocer oguzkocer commented Dec 12, 2022 •
edited
Loading

Partially closes #17558.

Updates squareupMockWebServerVersion to 4.9.3.

Note that the dependency path has changed from com.squareup.okhttp:mockwebserver to com.squareup.okhttp3:mockwebserver.

To test:

Since this dependency change is only related to testing, CI checks should be enough.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@oguzkocer oguzkocer added this to the 21.4 milestone Dec 12, 2022
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Dec 12, 2022 •
edited
Loading

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17663-9cd8f14.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commit9cd8f14
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Dec 12, 2022 •
edited
Loading

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17663-9cd8f14.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commit9cd8f14
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@oguzkocer oguzkocer changed the title Update squareupMockWebServerVersion to 4.10.0 Update squareupMockWebServerVersion to 4.9.3 Dec 12, 2022
@oguzkocer oguzkocer force-pushed the dep-updates/squareupMockWebServerVersion branch from bbfef26 to 9cd8f14 Compare December 12, 2022 18:19
@oguzkocer oguzkocer marked this pull request as ready for review December 12, 2022 18:54
@oguzkocer oguzkocer enabled auto-merge December 12, 2022 18:54
@oguzkocer oguzkocer requested a review from ParaskP7 December 12, 2022 18:54
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Dec 12, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@ParaskP7 ParaskP7 self-assigned this Dec 13, 2022
ParaskP7
ParaskP7 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

Thanks for handling this update @oguzkocer ! 🥇

PS: It is weird that the 4.10.0 artifact is not ready for the MockWebServer dependency, just like it is for the rest Square OkHttp such dependencies, and only the 4.10.0-RC1 is. 🤔 Oh well... 🤷

@oguzkocer oguzkocer merged commit da71a43 into trunk Dec 13, 2022
@oguzkocer oguzkocer deleted the dep-updates/squareupMockWebServerVersion branch December 13, 2022 12:31
@ParaskP7 ParaskP7 mentioned this pull request Dec 13, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ParaskP7 ParaskP7 ParaskP7 approved these changes

Assignees

@ParaskP7 ParaskP7

Labels

None yet

Projects

None yet

Milestone

21.4

Development

Successfully merging this pull request may close these issues.

Dependency Updates - Android Test Batch

3 participants

@oguzkocer @wpmobilebot @ParaskP7