Merged
Conversation
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | f4348ec | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | f4348ec | |
5 tasks
ParaskP7
reviewed
Dec 6, 2022
| package org.wordpress.android.ui.mysite.dynamiccards | ||
|
|
||
| import kotlinx.coroutines.InternalCoroutinesApi | ||
| import org.assertj.core.api.Java6Assertions.assertThat |
Contributor
There was a problem hiding this comment.
This Java6Assertions was a very interesting import! 🤣
ParaskP7
reviewed
Dec 6, 2022
WordPress/src/test/java/org/wordpress/android/ui/uploads/UploadActionUseCaseTest.kt
Outdated
Show resolved
Hide resolved
ParaskP7
approved these changes
Dec 6, 2022
Contributor
There was a problem hiding this comment.
LGTM! 💯
Thanks for handling this update @oguzkocer ! 🥇
- After 6539c76, we had Overload resolution ambiguity between Consumer & ThrowingConsumer in FetchScanStateUseCaseTest & UploadActionUseCaseTest. This is a assertj/assertj#2357. For now, it requires syntax change made in 0d28dfc.
👍
- 8a8d1d4 updates the deprecated org.assertj.core.api.Java6Assertions.assertThat import with org.assertj.core.api.Assertions.assertThat which is what we use in all our other tests.
👍 + 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
assertjVersionto3.23.1.Overload resolution ambiguitybetweenConsumer&ThrowingConsumerinFetchScanStateUseCaseTest&UploadActionUseCaseTest. This is a documented issue. For now, it requires syntax change made in 0d28dfc.org.assertj.core.api.Java6Assertions.assertThatimport withorg.assertj.core.api.Assertions.assertThatwhich is what we use in all our other tests.To test:
Since this dependency change is only related to testing, CI checks should be enough.
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.