Jetpack Focus: Open links in Jetpack refactoring#17547
Merged
Conversation
…ith specific enableDeepLinks or disableDeepLinks
… and use specific enable and disable deep links methods
… returned if the process can not complete
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 10fe75a | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 10fe75a | |
develric
approved these changes
Nov 27, 2022
Contributor
develric
left a comment
There was a problem hiding this comment.
LGTM and works as per test steps 👍
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17494
This PR includes:
DeepLinkOpenWebLinksWithJetpackHelper- rename methods so that they are more concise and easily recognizable.To test:
Ensure the overlay view is shown and the secondary action reads "
Reader Post
- ✅ Verify the overlay is shown and the secondary action reads "Open links in WordPress"Regression Notes
Potential unintended areas of impact
The overlay secondary text is not updated
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.