Skip to content

Jetpack Focus: Jetpack app uninstall receiver#17526

Merged
develric merged 5 commits intotrunkfrom
issue/17494-add-uninstall-broadcast-receiver
Nov 24, 2022
Merged

Jetpack Focus: Jetpack app uninstall receiver#17526
develric merged 5 commits intotrunkfrom
issue/17494-add-uninstall-broadcast-receiver

Conversation

@zwarm
Copy link
Copy Markdown
Contributor

@zwarm zwarm commented Nov 23, 2022

Parent #17494

This PR adds the JetpackAppUninstallReceiver.
This broadcast receiver will listen for Jetpack App uninstalls and perform the following actions:

  1. Turns off the "Open web links with JetpacK" app setting.
  2. Renables the web link deep link handlers

Merge Instructions

  1. Ensure that Jetpack Focus: Prepare DeepLinkIntent Receiver to launch open web links flow #17523 has been merged
  2. Remove the "Not ready for merge" label
  3. Merge as normal

To test:

  • Ensure either Jetpack app or Jetpack beta app is installed (from play store)
  • Remove any WordPress app instances
  • Install WP APK from this PR
  • Login to the app
  • Navigate to Me → App Settings → Privacy and enable collect information
  • Navigate to Me → App Settings → Debug Settings
  • Enable the open_web_lnks_with_jetpack_flow feature and restart the app
  • Navigate to Me → App Settings
  • Flip the switch to enable Open web links with Jetpack setting
  • Navigate out of App Settings
  • Navigate to back into Me → App Settings
  • ✅ Verify that the Open web links with Jetpack setting is still enabled
  • Navigate out of App Settings
  • Uninstall the Jetpack app (wait for it to finish)
  • Open WP app
  • Navigate to Me → App Settings
  • ✅ Verify that the Open web links with Jetpack setting is not enabled

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 21.3 milestone Nov 23, 2022
@zwarm zwarm requested a review from develric November 23, 2022 19:51
@zwarm zwarm self-assigned this Nov 23, 2022
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Nov 23, 2022

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17526-2ae9c81.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commit2ae9c81
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Nov 23, 2022

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17526-2ae9c81.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commit2ae9c81
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@zwarm zwarm changed the base branch from trunk to issue/17494-deeplinkreceiver-alias November 23, 2022 23:11
Base automatically changed from issue/17494-deeplinkreceiver-alias to trunk November 24, 2022 01:25
Copy link
Copy Markdown
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM, also works as described 👍 !

@develric develric merged commit f73f5be into trunk Nov 24, 2022
@develric develric deleted the issue/17494-add-uninstall-broadcast-receiver branch November 24, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants