Add analytics event for tracking Jetpack full screen overlay events #17512
Merged
Add analytics event for tracking Jetpack full screen overlay events #17512
Conversation
Removes: Site creation overlay tracking logic for time being
3 tasks
Contributor
|
|||||||||||
| 💡 Scan this QR code with your Android phone to download and install the APK directly on it. | ||
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | aa5220c | |
Contributor
|
|||||||||||
| 💡 Scan this QR code with your Android phone to download and install the APK directly on it. | ||
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | aa5220c | |
# Conflicts: # WordPress/src/main/res/values/dimens.xml # libs/analytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java # libs/analytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java
…mode' into issue/17333-add-analytics-events
…mode' into issue/17333-add-analytics-events
Base automatically changed from
issue/17333-jetpack-focus-fullscreen-overlay-landscape-mode
to
trunk
November 23, 2022 13:49
Contributor
|
In my testing things mostly worked as expected.
If you think that 1 and 2 worked as expected than I think we can merge this PR |
enejb
approved these changes
Nov 23, 2022
Contributor
enejb
left a comment
There was a problem hiding this comment.
If you think that 1 & 2 in my feedback is working as expected then I think we should ship this PR.
Contributor
Author
|
Hey @enejb , Thanks for the review. For making the testing easier, I disabled overlay frequency logic. Because of this, the overlay is shown every time you try to access the Stats/Reader/Notifications. The overlay is shown when the view loads, the life cycle of the views in Reader/Notifications is different from that in Stats, hence the overlay is shown every time in Reader and Notifications. I have reverted - Overlay shown without frequency logic with this commit - aa5220c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Part of #17333
Changes
This PR adds the logic for tracking the events related to the FullScreen overlay shown on Stats/Reader and Notifications.
Review instructions
Approval from one reviewer is sufficient for merging this PR.
To test:
Pre- Requisites
Test 1 - Stats - Close overlay with Continue to feature button
Test 2 - Stats - Close overlay with X button
Test 3 - Stats - Try jetpack app flow
Test 4 - Notifications - Close overlay with Continue to feature button
Test 5 - Notifications - Close overlay with X button
Test 6 - Notifications - Try jetpack app flow
Test 7 - Reader - Close overlay with Continue to feature button
Test 8 - Reader - Close overlay with X button
Test 9 - Reader - Try jetpack app flow
Regression Notes
Potential unintended areas of impact
Analytics events are not tracked properly
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.