[UI Tests] - Update click element on image library#17323
Merged
Conversation
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | e148fd1 | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | e148fd1 | |
jostnes
commented
Oct 13, 2022
| } | ||
|
|
||
| public void openPostSetting() { | ||
| waitForElementToBeDisplayed(R.id.toolbar_main); |
Contributor
Author
There was a problem hiding this comment.
Added this wait because, during testing, this step failed once when the test wasn't able to click on the menu item (see: failing test video).
Contributor
|
I'm going to take a liberty of merging this one, because I think it's better to have the fix as soon as possible. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
e2ePublishFullPosttest is flaky, most recently, it failed twice on this build before passing without any change on the third try. This PR is an attempt to fix that flakiness.Why is the test failing
Looks like the test is failing because the supposed click sometimes acted like a long press, changing the flow of the test and making it fail (failing test video) From the video, it looks like the screen jumps from the image media gallery to a full-screen photo view:
From this:
To this:
The only way to get to that view is by long-pressing the image from the gallery.
How can this (potentially) be fixed
There are two elements that we can choose to click from that view to select the image, the element used currently is
image_thumbnail, and there is another elementtext_selection_count. The difference between the two isimage_thumbnailhas the attributelongClickableset totrue. The same attribute fortext_selection_countisfalse, by updating the element, the long-press should no longer happen on this test.Testing
The test should work locally and in CI