[UI Tests] - Re-enable e2eSendButtonEnabledWhenTextIsEntered test#17312
Merged
[UI Tests] - Re-enable e2eSendButtonEnabledWhenTextIsEntered test#17312
Conversation
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | a4186d6 | |
Contributor
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | a4186d6 | |
9 tasks
pachlava
reviewed
Oct 13, 2022
|
|
||
| // Assertions: | ||
| public ContactSupportScreen assertContactSupportScreenLoaded() { | ||
| waitForElementToBeDisplayed(inputTextField); |
Contributor
There was a problem hiding this comment.
I wonder if this will work on FTL? (it does locally)
Suggested change
| waitForElementToBeDisplayed(inputTextField); | |
| waitForElementToBeDisplayed(textInput); |
Then we won't need the inputTextField added above.
Contributor
Author
There was a problem hiding this comment.
Good catch, it does work! (FTL test run).
Change made here: a4186d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #17281
What
Re-enable "e2eSendButtonEnabledWhenTextIsEntered" tests, this needed a new wait on the support screen to make this work in FTL. The test worked in the local emulator but was failing in FTL because of a loading issue, looks like the fix was to wait for an element on the support screen before continuing the test
Testing
e2eSendButtonEnabledWhenTextIsEnteredtest should pass locally and in CI/FTL