Skip to content

[UI Tests] - Re-enable all disabled login tests#17297

Merged
jostnes merged 2 commits intotrunkfrom
uitii-reenable-disabled-login-tests
Oct 12, 2022
Merged

[UI Tests] - Re-enable all disabled login tests#17297
jostnes merged 2 commits intotrunkfrom
uitii-reenable-disabled-login-tests

Conversation

@jostnes
Copy link
Copy Markdown
Contributor

@jostnes jostnes commented Oct 11, 2022

Part of: #17281

What

Re-enable all disabled login tests

Why

Tests were previously disabled because of flakiness. After some testing in FTL and local, looks like we can re-enable these back without any code change. There was a recent update to the FTL emulator version so that change might have helped with the flakiness.

Testing

Login tests should pass locally and in CI

Note: There was one failing test case during the CI runs, it was the e2ePublishFullPost test case that was not related to the ones enabled in this PR.

@jostnes jostnes added [Type] Task UI Tests Anything related to automated UI Tests. labels Oct 11, 2022
@jostnes jostnes added this to the 21.0 milestone Oct 11, 2022
@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Oct 11, 2022

WordPress📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17297-fba26f2.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppWordPress
Build FlavorJalapeno
Build TypeDebug
Commitfba26f2
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Oct 11, 2022

Jetpack📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17297-fba26f2.apk
💡 Scan this QR code with your Android phone to download and install the APK directly on it.
AppJetpack
Build FlavorJalapeno
Build TypeDebug
Commitfba26f2
Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

@jostnes jostnes marked this pull request as ready for review October 12, 2022 02:12
@jostnes jostnes requested a review from a team as a code owner October 12, 2022 02:12
Copy link
Copy Markdown
Contributor

@pachlava pachlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have them running in the wild, @jostnes, and see the impact! Thanks :shipit:

@jostnes jostnes merged commit 6beec0d into trunk Oct 12, 2022
@jostnes jostnes deleted the uitii-reenable-disabled-login-tests branch October 12, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Task UI Tests Anything related to automated UI Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants