Conversation
Warning Message: "Unnecessary safe call on a non-null receiver of type CharSequence. This expression will have nullable type in future releases" The 'mPositiveButtonLabel' is being reverted back to being a nullable field, that is, instead of it being a 'lateinit' non-null field. PS: This field was nullable in the past, but this 24a0532 commit made it into 'lateinit' non-null.
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17204-ffc097d.apk), or scanning this QR code:
|
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17204-ffc097d.apk), or scanning this QR code:
|
SiobhyB
left a comment
There was a problem hiding this comment.
PS.2 @SiobhyB I actually didn't add you here too randomly as I want you to verify this e053210 change I did, which reverts your such 24a0532 change (as part of #14503 PR). I am actually not sure why you did this change, thus please do let me know if my change isn't breaking anything that you tried to fix with your change.
Thank you for the ping, @ParaskP7! I looked over the original commit and PR, but can't recall a specific reason for the change. It was from the very early days of my apprenticeship, so it's likely to have been an amateur response to something not working as expected. 🤔 A good reminder to myself to actually write useful commit messages, too!
I downloaded the installable build and confirm the dialog still displays as expected, with no visual errors, when changing between featured images within the editor. Thank you for cleaning this up!
Parent: #17173
Closes: #17180
This PR resolves/suppresses a couple of warnings for the
editormodule and then enables all warnings as errors on it as well.Warnings Resolution List:
The
allWarningsAsErrorsconfiguration is currently applied on the module level in order to make sure that, as the overall Compiler Warnings as Errors work is progressing, no new warnings are added to this module, which is already free of warnings.When the overall Compiler Warnings as Errors work is complete on all modules, then this module level
allWarningsAsErrorsconfiguration will be replaced by a root level such configuration that will be applied by default to all modules (see here).PS.1: @SiobhyB I added you as the main reviewer, that is, in addition to @wordpress-mobile/apps-infrastructure team itself, but randomly, since I want someone from the
WordPress Androidteam to primarily sign-off on that change. 🥇PS.2 @SiobhyB I actually didn't add you here too randomly as I want you to verify this e053210 change I did, which reverts your such 24a0532 change (as part of this PR). I am actually not sure why you did this change, thus please do let me know if my change isn't breaking anything that you tried to fix with your change.
FYI: I am going to randomly add more of you in those PRs that will follow, just so you become more aware of this change and how close we are on enabling
allWarningsAsErrorsby default everywhere. 🎉To test:
editormodule is responsible for that. For example, you could try replacing the featured image on a post, from a post image (not the settings page), and see if that works as expected.Regression Notes
The editor functionality is not working as expected.
See
To testsection above.N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.