Update Dagger to 2.42#16883
Merged
oguzkocer merged 1 commit intoupdate-dependencies-to-agp-7.2.1-versionsfrom Jul 7, 2022
Merged
Update Dagger to 2.42#16883oguzkocer merged 1 commit intoupdate-dependencies-to-agp-7.2.1-versionsfrom
oguzkocer merged 1 commit intoupdate-dependencies-to-agp-7.2.1-versionsfrom
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Contributor
|
Found 1 violations: The PR caused the following dependency changes:-+--- com.google.dagger:dagger-android-support:2.41 -> 2.42
++--- com.google.dagger:dagger-android-support:2.42
-\--- com.google.dagger:hilt-android:2.41
- +--- com.google.dagger:dagger:2.41 -> 2.42 (*)
- +--- com.google.dagger:dagger-lint-aar:2.41 -> 2.42
- +--- com.google.dagger:hilt-core:2.41
- | +--- com.google.dagger:dagger:2.41 -> 2.42 (*)
- | +--- com.google.code.findbugs:jsr305:3.0.2
- | \--- javax.inject:javax.inject:1
- +--- com.google.code.findbugs:jsr305:3.0.2
- +--- androidx.activity:activity:1.3.1 (*)
- +--- androidx.annotation:annotation:1.2.0
- +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
- +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
- +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
- +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
- +--- androidx.savedstate:savedstate:1.1.0 (*)
- +--- javax.inject:javax.inject:1
- \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.32 -> 1.6.10 (*)
+\--- com.google.dagger:hilt-android:2.42
+ +--- com.google.dagger:dagger:2.42 (*)
+ +--- com.google.dagger:dagger-lint-aar:2.42
+ +--- com.google.dagger:hilt-core:2.42
+ | +--- com.google.dagger:dagger:2.42 (*)
+ | +--- com.google.code.findbugs:jsr305:3.0.2
+ | \--- javax.inject:javax.inject:1
+ +--- com.google.code.findbugs:jsr305:3.0.2
+ +--- androidx.activity:activity:1.3.1 (*)
+ +--- androidx.annotation:annotation:1.2.0
+ +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
+ +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
+ +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+ +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
+ +--- androidx.savedstate:savedstate:1.1.0 (*)
+ +--- javax.inject:javax.inject:1
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
Please review and act accordingly
|
Contributor
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16883-1c9dc4d.apk), or scanning this QR code:
|
Contributor
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16883-1c9dc4d.apk), or scanning this QR code:
|
ParaskP7
approved these changes
Jul 7, 2022
Contributor
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @oguzkocer !
I reviewed and smoked tested the app again, everything LGTM, it is again a 👍 from my side and thank you so much for doing this update! 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We updated some of our libraries Dagger version to
2.42as part of AGP7.2.1update in #16878. We'd like to avoid Gradle resolving our dependency versions to a different version from the declared one, so we are also updating WPAndroid's Dagger version.Here are the release notes for Dagger
2.42: https://github.com/google/dagger/releases/tag/dagger-2.42The only breaking change listed would result in a compile time error and technically this update was smoke tested by me and @ParaskP7 in #16878 because as listed by @wpmobilebot's comment, Dagger was updated to
2.42due to our libraries already being updated.To test:
Smoke test the app
Regression Notes
Potential unintended areas of impact
Dagger updates should be limited to compile time, but sometimes transitive dependency updates happen as part of it, so hard to limit its scope.
What I did to test those areas of impact (or what existing automated tests I relied on)
Our CI stack and smoke testing
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.