Addresses lint issues in AGP 7.2.1 update#16839
Merged
ParaskP7 merged 4 commits intoupgrade-gradle-to-7.4.2-agp-to-7.2.1from Jul 6, 2022
Merged
Addresses lint issues in AGP 7.2.1 update#16839ParaskP7 merged 4 commits intoupgrade-gradle-to-7.4.2-agp-to-7.2.1from
ParaskP7 merged 4 commits intoupgrade-gradle-to-7.4.2-agp-to-7.2.1from
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Contributor
|
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16839-0e12fd6.apk), or scanning this QR code: |
Contributor
|
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16839-0e12fd6.apk), or scanning this QR code: |
7519752 to
9988ff8
Compare
ParaskP7
approved these changes
Jul 5, 2022
Contributor
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @oguzkocer !
I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟
I have left one suggestion (💡) for you to consider. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.
WordPress/src/main/java/org/wordpress/android/ui/people/PeopleListFragment.java
Outdated
Show resolved
Hide resolved
Contributor
|
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the lint issues due to AGP
7.2.1update in #16834.TextDrawablewidget, so we don't even need to fix the lint issue 🙈DividerItemDecorationinstead. Funnily enough I worked on the people list 6+ years ago andDividerItemDecorationwas not available back then (was added a few months after) so we had to build it ourselves. The difference between the regular divider and the custom divider is that the regular divider covers the whole width whereas the custom divider had some space before and after the line. See the screenshots below for comparison. Since we are using the regular divider in a lot of newer screens, this change should bring the design of people list closer to the rest of the app so it's a win-win situation.Obsolete SDK_INT version checkslint error.Before:
(Full name and display name are removed and the screenshot was cut in half to make it easier to see)
After:
(Full name and display name are removed and the screenshot was cut in half to make it easier to see)
To test:
Peoplepage from "My Site" -> "People" and verify that the divider looks OKRegression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.