Merged
Conversation
WellSqlInitializer is added for debug and release variants. It'll be used in AppInitializer.
AppInitializer is created, and all initializing stuff is moved to AppInitializer from WordPress.
# Conflicts: # WordPress/src/main/java/org/wordpress/android/WordPress.java
Hilt migration: Add AppInitializer
…ress Add common parent class for application classes
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
# Conflicts: # WordPress/src/main/java/org/wordpress/android/WordPress.java
Generated by 🚫 dangerJS |
# Conflicts: # build.gradle
Contributor
|
Found 1 violations: The PR caused the following dependency changes:-+--- com.google.dagger:dagger:2.41
-| \--- javax.inject:javax.inject:1
+--- com.google.dagger:dagger-android-support:2.41
-| \--- com.google.dagger:dagger:2.41 (*)
+| \--- com.google.dagger:dagger:2.41
+| \--- javax.inject:javax.inject:1
+\--- com.google.dagger:hilt-android:2.41
+ +--- com.google.dagger:dagger:2.41 (*)
+ +--- com.google.dagger:dagger-lint-aar:2.41
+ +--- com.google.dagger:hilt-core:2.41
+ | +--- com.google.dagger:dagger:2.41 (*)
+ | +--- com.google.code.findbugs:jsr305:3.0.2
+ | \--- javax.inject:javax.inject:1
+ +--- com.google.code.findbugs:jsr305:3.0.2
+ +--- androidx.activity:activity:1.3.1 (*)
+ +--- androidx.annotation:annotation:1.2.0
+ +--- androidx.fragment:fragment:1.3.6 (*)
+ +--- androidx.lifecycle:lifecycle-common:2.3.1 (*)
+ +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*)
+ +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
+ +--- androidx.savedstate:savedstate:1.1.0 (*)
+ +--- javax.inject:javax.inject:1
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.32 -> 1.6.10 (*)
Please review and act accordingly
|
ovitrif
approved these changes
Apr 22, 2022
Contributor
ovitrif
left a comment
There was a problem hiding this comment.
Good work everyone with the child PRs!
Thank you @irfano for taking and leading this initiative 🙇 !
The code lgtm and I smoke-tested the build from the PR by creating a new site, then going through all the possible screens I could think of, then deleting a site and selecting my main one and proceeding to do the same navigation through all possible screens I could find.
Everything worked as expected 🎉
I'd say 
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the parent feature PR for hilt migration. Child PRs: PR 1, PR 2, PR3
Hilt migration was implemented as an experiment in #15653 before, but it's a big PR and a bit outdated.
This PR aims to implement Hilt with minimum required changes. Dagger will not be removed completely. Hilt and Dagger will be used together.
To test:
There is no user-facing change. Build the app with different variants to see if it's still buildable and tests are working.
Regression Notes
Potential unintended areas of impact
Some tests might be broken. Debug and release builds might work wrong.
What I did to test those areas of impact (or what existing automated tests I relied on)
I run current tests. I built the debug app. I relied on automated tests for release build.
What automated tests I added (or what prevented me from doing so)
There is no new feature. No tests are added.
PR submission checklist:
RELEASE-NOTES.txtif necessary.