Render comments in list using same logic as comments details.#16000
Render comments in list using same logic as comments details.#16000
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @khaykov !
Thank you so much for opening this PR and making the switch, this is awesome! 💯
This PR improves the way we render HTML content in Site Comment list, and removes reliance on TagSoup library in WpHtml.
I switched to using same rendering logic that is used for comment content, which means we are finally rendering mentions and images (including gifs), also HTML content, like quotes, is styled properly.
After reviewing and testing this PR I can verify that the rendering of comments looks actually better now than before. It is a 🟢 light from my side. This also means that we can now remove the whole WPHtml and HtmlToSpannedCoverter functionality altogether, which will allow us to free ourselves from the TagSoup library dependency. 🎉
I am going to request changes on removing the TagSoup library and all its references as part of this PR as well. You can follow this 8552141 commit as a reference on what needs and can be removed as part of this change. As a quick reference I am listing those changes for you:
implementation 'org.ccil.cowan.tagsoup:tagsoup:1.2.1'dependency.void inject(HtmlToSpannedConverter object);Dagger injection.WPHtml.javamain class.WPHtmlTest.javatest class.HtmlToSpannedCovertermain class.- 3 x
media_image_placeholder.pngdrawable resources.
Once more, great work and thank you so much on following-up with #15882! 🥇
Generated by 🚫 dangerJS |
|
@ParaskP7 Thanks! Removed the code you mentioned 🚀 |
Fixes #15882
(cc @ParaskP7 )
This PR improves the way we render HTML content in Site Comment list, and removes reliance on TagSoup library in WpHtml.
I switched to using same rendering logic that is used for comment content, which means we are finally rendering mentions and images (including gifs), also HTML content, like quotes, is styled properly.
To test:
Regression Notes
Potential unintended areas of impact
Some HTML elements might render in unexpected way.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
No way to test html rendering at this time.
PR submission checklist:
RELEASE-NOTES.txtif necessary.