Media picker library integration#15608
Closed
irfano wants to merge 3 commits intowordpress-mobile:developfrom
irfano:feature/media-picker-library
Closed
Media picker library integration#15608irfano wants to merge 3 commits intowordpress-mobile:developfrom irfano:feature/media-picker-library
irfano wants to merge 3 commits intowordpress-mobile:developfrom
irfano:feature/media-picker-library
Conversation
- Removed mediapicker dependency. Mediapicker need extra steps to work with Hilt. - Added Hilt infrastructure to use with Dagger together.
Generated by 🚫 dangerJS |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
Contributor
|
Closing this in favor of #15653 (internal ref: pbMoDN-35Z-p2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes current media picker screens and uses Media Picker Library for the same feature. The library provides exact same functions and design.
WP app is using MediaPickerLauncher to view media picking screens. MediaPickerLauncher has different public functions which are starting MediaPickerActivity and showing different versions of the picker (Like different buttons and titles). Other classes which use MediaPickerLauncher shouldn’t need any changes basically for this task.
To test: Need to check every place which media picker can be opened. Because media pickers screen has different views for different functions. All functions, buttons, texts must be the same as before integration. (There might be some updates for titles maybe. If there are, they will be discussed here.)
Test cases will be added.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.