Skip to content

[Gutenberg][TEST][DO NOT MERGE] Test react-native-prompt-android package integration#14713

Closed
fluiddot wants to merge 18 commits intodevelopfrom
gutenberg/test/react-native-prompt-android-integration
Closed

[Gutenberg][TEST][DO NOT MERGE] Test react-native-prompt-android package integration#14713
fluiddot wants to merge 18 commits intodevelopfrom
gutenberg/test/react-native-prompt-android-integration

Conversation

@fluiddot
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot commented May 25, 2021

NOTE: This PR is meant to be only for testing so it shouldn't be merged.

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3548

This PR includes the changes from #14623.

To test:

  1. Open a post/page
  2. Observe that the app doesn't crash

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels May 25, 2021
@fluiddot fluiddot self-assigned this May 25, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 25, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@fluiddot fluiddot changed the title [Gutenberg][DO NOT MERGE] Test react native prompt android integration [Gutenberg][DO NOT MERGE] Test react-native-prompt-android package integration May 25, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 25, 2021

You can test the changes on this Pull Request by downloading the APK here.

@fluiddot fluiddot changed the title [Gutenberg][DO NOT MERGE] Test react-native-prompt-android package integration [Gutenberg][TEST][DO NOT MERGE] Test react-native-prompt-android package integration May 25, 2021
@fluiddot fluiddot closed this May 27, 2021
@fluiddot fluiddot deleted the gutenberg/test/react-native-prompt-android-integration branch May 27, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant