Merged
Conversation
update gb-mobile ref
# Conflicts: # libs/gutenberg-mobile
# Conflicts: # libs/gutenberg-mobile
# Conflicts: # libs/gutenberg-mobile
# Conflicts: # libs/gutenberg-mobile
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
7 tasks
Contributor
Author
13 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
|
Moving this PR to next milestone, since 17.6 goes into code freeze today. |
hypest
approved these changes
Jun 15, 2021
Contributor
hypest
left a comment
There was a problem hiding this comment.
LGTM! The writing flow tests worked for me (via a sibling PR). As usual, we'll wait for thumbs-ups in gutenberg-mobile and Gutenberg to do the domino merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading react-native to version 0.64.0
To test: Follow instructions on gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3430
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.